commit | 4c8353e20a18973acd0838795bd39ad8d7ea8543 | [log] [tgz] |
---|---|---|
author | Antonio Gomes <tonikitoo@igalia.com> | Wed Oct 13 13:34:08 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Oct 13 13:34:08 2021 |
tree | 88f6338d79bdb4f027c22d4673acbf5a5f28d74e | |
parent | 0ccd4037268bc54c002f631bf7ce9050511ba3f3 [diff] |
Reland "Change the ownership of ash::TabDragDropDelegate" This is a reland of 1654d660fb0159a5f57d78d9be8a1f37a9c079bf Same as original; The reverted CL was not the one causing the failure. Details in: [1]. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1259127#c2 Original change's description: > Change the ownership of ash::TabDragDropDelegate > > In the current implementation, TabDragDropDelegate runs all its methods > synchronously and the deletion model is simple: object is deleted > when it goes out of scope. > However, to support Lacros' WebUI tab drop, TabDragDropDelegate::Drop() > becomes naturally asynchronous, since its closure routine needs to > be called by Lacros. > Hence, the current ownership model does not work well for lacros, > since one can not predict when the Drop() closure routine is called. > > This CL fixes this by changing the ownership model of > ash::TabDragDropDelegate to self delete after the Drop()'s closure > routine is called. > > This is a preparation email for fully support WebUI tab drop. > > BUG=1236708 > R=oshima@chromium.org > > Change-Id: I330f35f9697a27fc3a35454f059cb3377378a718 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203250 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/main@{#930161} Bug: 1236708 Change-Id: I4d09f225c7e9c8d76613ff693ac03152f2c7b27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220950 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/main@{#931022}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.