commit | 555f0137dea73441b2b4dd0f59b8307068973078 | [log] [tgz] |
---|---|---|
author | Finnur Thorarinsson <finnur@chromium.org> | Tue Mar 05 17:59:45 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 05 17:59:45 2024 |
tree | a9d8ad6b62bcf8d64e0e1f17e6169c2caed47339 | |
parent | 2699b3bec75ea818286c10b574061ddb558fdf50 [diff] |
[UniversalInstall]: Fix incorrect CHECK condition. The CHECK needs to be updated to catch up with the fact that we now support homebrew webapps (aka. DIY webapps). It is therefore incorrect to warn when the user opts to create a shortcut to a homebrew app (instead of installing). It is an already supported use case that works fine if we augment the CHECK. (cherry picked from commit 8b080baade8f5388e3df7a0fbc974d8712c04b76) Bug: 328023335 Change-Id: I8db54b0bb3151e09909f0ab1bb6f07cd2f9c68ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5340529 Reviewed-by: Ella Ge <eirage@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1267839} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5340379 Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/6312@{#398} Cr-Branched-From: 6711dcdae48edaf98cbc6964f90fac85b7d9986e-refs/heads/main@{#1262506}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.