commit | 55a2e37d9958ab360a36069f70129b42291c97ee | [log] [tgz] |
---|---|---|
author | Peter Birk Pakkenberg <pbirk@chromium.org> | Wed Jun 19 08:54:10 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jun 19 08:54:10 2024 |
tree | 3f3596034b5dc06aa0f118b8f138aacfa7191706 | |
parent | 5770980a4c1d848a6b12028aea996c3d7df311a9 [diff] |
Add UMA logging of implemented WebView callbacks This change was previously submitted as crrev.com/c/5611342, but reverted because it caused StrictMode violations. This change reintroduces the method logging, but explicitly allows the NonSdkApiAccessed violation to occur. The cause for the violation is that WebViewClient and WebChromeClient contains methods at runtime that are no longer part of the Android SDK because they were removed in earlier versions. When we then try to get a method reference on an implementation of one of those classes to one of those removed methods, we will then get a violation. To avoid this warning, we only try to access methods that are still part of the public API. Original change's description: > Revert "Add UMA logging of implemented WebView callbacks" > > This reverts commit 8251daa6c77876c83f3fedcad6cd0779b57b25e6. > > Reason for revert: Reflection causes NonSdkApiUsedViolation > b/339432838 > > Original change's description: > > Add UMA logging of implemented WebView callbacks > > > > Bug: 339432838 > > Change-Id: I1a28801ca612a3f7f14bdb7cf91de5239430f6c6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526660 > > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > > Reviewed-by: Peter Conn <peconn@chromium.org> > > Commit-Queue: Peter Pakkenberg <pbirk@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1298598} > > Bug: 339432838 > Change-Id: I0d3484e0d1cd223329c86dbb68f9f04e4937d745 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5611342 > Commit-Queue: Peter Pakkenberg <pbirk@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1312679} Bug: 339432838 Change-Id: I1a4ee165d155a48a83abad1ef148efcd1b37224c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5621177 Commit-Queue: Peter Pakkenberg <pbirk@chromium.org> Reviewed-by: Richard (Torne) Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1316916}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.