commit | 586beba86669612885f477f7cf28993eaa432455 | [log] [tgz] |
---|---|---|
author | Sujie Zhu <sujiezhu@google.com> | Mon Aug 13 22:54:29 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Aug 13 22:54:29 2018 |
tree | 62b4533beb81e3b114b3fcb518dee1d0deedefa6 | |
parent | 7673f05afe28e4f840eef4c958718f151babfb73 [diff] |
[Autofill local card migration] Refactor the local_card_migration_manager To simplify the logic of triggering from settings page, we need to refactor the current local_card_migration_manager: 1. Move the isServerCard to the personal_data_manager. To determine a card is whether a server card or has server dup only depends on the personal_data_manager. So later we can use this function directly without create local_card_migration_manager when we create new attribute for each credit card entry for the settings page. Add unittests in the personal_data_manager. 2. Extract the prepare migratable credit cards to a helper function. Later, when we implement checking migration requirements in the settings page, we do not need to check the migration requirement twice after we bridge back. So we can directly call PrepareMigratableCreditCard() and AttemptToOfferLocalCardMigration() for the settings page. Bug: 852904 Change-Id: I12b90054e96a9cafb6905c39608c7a5c1cbc2f8c Reviewed-on: https://chromium-review.googlesource.com/1167796 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#582729}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .