[go: nahoru, domu]
Google Git
Sign in
chromium / chromium / src / 591902ddb33041641dcd975269c58775958144e7
commit591902ddb33041641dcd975269c58775958144e7[log] [tgz]
authorCalder Kitagawa <ckitagawa@chromium.org>Wed Feb 14 19:50:16 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Feb 14 19:50:16 2024
tree5f53ecf694d5a87d00bd9e241019cbe464161c22
parent40d3b66cfa66d31913c2d864f699be2703690caa [diff]
[Tab Switcher] Fix crash in snackbar creation

There appears to be a crash where the quick delete menu triggers the
navigation to tab switcher while the app is exiting and the current
activity is being destroyed. This CL skips snackbar manager creation
if the activity is being destroyed as that crashes.

We should probably skip this behavior in quick delete itself, but
I'll leave that to the incognito/quick delete owners.

Bug: b/324996488
Change-Id: I70f19290b6e6399f7d1aed70d41b6313d2b7ce67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5293274
Reviewed-by: Zaina Al-Mashni <zalmashni@google.com>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1260651}
3 files changed
tree: 5f53ecf694d5a87d00bd9e241019cbe464161c22
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.