commit | 5925c47876fa755404cdffea61c87d2b19ff2bc8 | [log] [tgz] |
---|---|---|
author | Tom Anderson <thomasanderson@chromium.org> | Thu Aug 24 19:12:46 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Aug 24 19:12:46 2017 |
tree | e8910a46e795802c87c6e6aabdb23e61642a1472 | |
parent | 36ff06054b44acdaf6897d15d499e78f74b8071d [diff] |
Don't PCHECK() in SetGidAndUidMaps CanCreateProcessInNewUserNS() forks and the child process checks if processes can be created in a new user namespace. It winds up calling SetGidAndUidMaps(), which had a PCHECK() that can get triggered under some unknown conditions that shows up in our crash reports. This PCHECK() causes the forked child to crash, and because of this, Chrome correctly concludes that it cannot create processes in a new user NS. This behavior is correct, but we would like for these crashes to not be reported to us. This CL changes the PCHECK() to a 'return false'. There are only 2 usages of SetGidAndUidMaps(), and one of them _exit(1)'s on failure, while the other has a PCHECK(), so this CL shouldn't change any functional behavior. BUG=685717 R=jorgelo@chromium.org Change-Id: I6bb7c86fbe63737b879feaa01bbe14ce9c009197 Reviewed-on: https://chromium-review.googlesource.com/633907 Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#497149}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .