tree 5e1aa353da10c5041453cc1438171a50d6fd0da3
parent e1678d4bbdc0c9518c427b1d276188d18646c654
author sbingler <bingler@chromium.org> 1706806580 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1706806580 +0000

Rename CanonicalCookie::IsSecure to SecureAttribute

CanonicalCookie::IsSecure() is a simple getter that returns if a
cookie's "Secure" attribute was set or not.

I.e.: Set-Cookie: "foo=bar; Secure"

With the introduction of "source_scheme" a cookie could also be
considered secure if their setting scheme was secure. To try and help
reduce potential confusion this CL renames IsSecure() to
SecureAttribute() to hopefully indicate that this is a getter and not a
function which is trying to answer the question "was this cookie created
in a secure context?".

This CL is a simple renaming and does not change any logic.

Bug: 1170548
Change-Id: I01141da043604e793eed2277fe28b4bb8ff58bfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5245913
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1255100}