commit | 50658cc043f4a929820207691fa965937cb95cac | [log] [tgz] |
---|---|---|
author | gloam <gaoqingguang@kuaishou.com> | Thu Nov 02 19:31:23 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Nov 02 19:31:23 2023 |
tree | eef1fbb5d6055be597cc752237aba8659269be45 | |
parent | ec47f2ee01a6e04d5625f22770553ebc398cb837 [diff] |
aw: Release its reference when the RenderFrameHost is destroyed. Iframes within a page can be dynamically deleted, triggering the destruction of the RenderFrameHost (RFH). However, the hosts_ and hosts_is_in_primary_main_frame_ within the GinJavaBridgeMessageFilter still hold references to the RFH. This can lead to a continuous increase in hosts_ and hosts_is_in_primary_main_frame_ when iframes are frequently created and destroyed Additionally, when RenderFrameCreated is called, there's no need to iterate through all frames and attempt to add a filter. We can simply add a filter to this particular RFH. This approach is more efficient and easier to understand. R=torne@chromium.org Low-Coverage-Reason: HARD_TO_TEST manually tested on crbug.com/1481603 Bug: 1481603,1481037 Change-Id: I69e80b55e356f59aab68c929cb328e590375a05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4958082 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Auto-Submit: gloam <gaoqingguang@kuaishou.com> Reviewed-by: Richard (Torne) Coles <torne@chromium.org> Commit-Queue: Richard (Torne) Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1219036}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.