[go: nahoru, domu]

aw: Release its reference when the RenderFrameHost is destroyed.

Iframes within a page can be dynamically deleted, triggering the
destruction of the RenderFrameHost (RFH). However, the hosts_ and
hosts_is_in_primary_main_frame_ within the GinJavaBridgeMessageFilter
still hold references to the RFH. This can lead to a continuous
increase in hosts_ and hosts_is_in_primary_main_frame_ when iframes
are frequently created and destroyed

Additionally, when RenderFrameCreated is called, there's no need to
iterate through all frames and attempt to add a filter. We can simply
add a filter to this particular RFH. This approach is more efficient
and easier to understand.

R=​torne@chromium.org

Low-Coverage-Reason: HARD_TO_TEST manually tested on crbug.com/1481603
Bug: 1481603,1481037
Change-Id: I69e80b55e356f59aab68c929cb328e590375a05b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4958082
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Auto-Submit: gloam <gaoqingguang@kuaishou.com>
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Commit-Queue: Richard (Torne) Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1219036}
5 files changed
tree: eef1fbb5d6055be597cc752237aba8659269be45
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.