[go: nahoru, domu]

Revert "Promote most UBSan flags to the ASan configuration on non-Windows"

This reverts commit 36c0df1671dccd3a8f76248d521c918e6c873afc.

Reason for revert: It seems the combination of UBSan, ASan, and fuzzer
instrumentation makes browser tests run far too slow. (Or there's some
deeper error being suppressed that I can't figure out, but it seems to
just be slow.) I suspect we'll need to make UBSan into a separate
bot.

Original change's description:
> Promote most UBSan flags to the ASan configuration on non-Windows
>
> This ratchets these in so we don't regress them. The alignment and null
> checks are not yet clear, so keep them on the FYI configuration for now.
> To avoid needing to introduce another set of builders, enable them on
> the ASan builders.
>
> This does not enable on Windows yet because the bots are not yet
> clear. First, -fsanitize=object-size will need to be suppressed due
> to https://github.com/llvm/llvm-project/issues/31914. Beyond that,
> there are some issues in
> https://ci.chromium.org/ui/p/chromium/builders/try/win-asan/11240/overview
> that I have not been able to diagnose yet.
>
> Bug: 40248746
> Change-Id: I970266c9ea3eb6b8c911f1bec5e29fc6e0198d4a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5646784
> Reviewed-by: Titouan Rigoudy <titouan@chromium.org>
> Auto-Submit: David Benjamin <davidben@chromium.org>
> Commit-Queue: Titouan Rigoudy <titouan@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1319068}

Bug: 40248746, 349978811
Change-Id: I0803bc52fbd6f33da9a1f24a143458a1982305ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5663719
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1321866}
3 files changed
tree: 3e65824df62f5452909577cd54fdec3cec670d8d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.