commit | 5be9f071ca1e98a03737f01e7746c7aecd22ac4d | [log] [tgz] |
---|---|---|
author | Gauthier Ambard <gambard@chromium.org> | Thu Mar 07 09:12:25 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 07 09:12:25 2024 |
tree | ca4fa6d6f99d2f49e7e2bb5a4af4b486f5f9d780 | |
parent | e9a9f0be1ef5b9d0441189b66fa3431def86d691 [diff] |
[123][iOS] Remove CHECK for the SendTabToSelf coordinator When the SendTabToSelf UI is presented after a Sign-in, there is a delay between the moment the Sign-in is done and the UI is shown, allowing the Sync model to get the "other devices" data. It seems that in some cases, this is slow enough for the user to open the SendTabToSelf UI another time. The correct fix is to show a spinner or something indicating to the user that something is happening. However, considering the usage of this feature, it is not worth adding this level of complexity. This CL removes the CHECK, allowing to re-enter the feature. (cherry picked from commit e1552e9dfb68e3725238d3d55daafd1e30345e34) Fixed: 326131561 Change-Id: I840705b7290ceb86435cf3b4a56ef643c5a20d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5340110 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1267803} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5349699 Cr-Commit-Position: refs/branch-heads/6312@{#446} Cr-Branched-From: 6711dcdae48edaf98cbc6964f90fac85b7d9986e-refs/heads/main@{#1262506}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.