| commit | 5c8332592d898c1785a4a6792e0ea0bb725d0e49 | [log] [tgz] |
|---|---|---|
| author | Antonio Gomes <tonikitoo@igalia.com> | Tue Oct 13 18:42:19 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Tue Oct 13 18:42:19 2020 |
| tree | 2bd2f19b089ae586b921bfba97a12325d4154203 | |
| parent | 4533937603194627f1d67a5a59def9270128bbaa [diff] |
Reland "Move //ash/public/cpp/caption_buttons to //chromeos/ui" This is a reland of 7ea4118ec37c7a99bcc8d38402ea0f587a3541bb The reland fixes the wrong `defines` declaration in //chromeos/ui/frame/BUILD.gn : - defines = [ "IS_CHROMEOS_UI_FRAME" ] + defines = [ "IS_CHROMEOS_UI_FRAME_IMPL" ] which was causing the wrong symbols being loaded. Original change's description: > Move //ash/public/cpp/caption_buttons to //chromeos/ui > > This is step 1.2 on the design document [1]. > > [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/edit > > BUG=1113900 > R=jamescook@chromium.org, sky@chromium.org > > Change-Id: Ic625b887b00538d758260a3f35426c346bcdbabf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458768 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816200} TBR=jamescook@chromium.org Bug: 1113900 Change-Id: I332e087c0eadd333aef96e2acb7d9f0c9a259f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466739 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#816671}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.