[go: nahoru, domu]

Fix Find behaving like Find Next

This bug happened in two cases when using Find:
1) On macOS, always
2) On all platforms, when text is selected

This change fixes both cases, while also unifying macOS behavior with
other platforms. (I think the previous exclusion of macOS from the
find-from-selection behavior may have been due to a misunderstanding of
some mac-specific code/comments.)

Now, when doing a find-from-selection, the initial result is the same
selected text, rather than the next occurrence. So it's a no-op
(as it should be) in terms of the selection and the document scroll
position.

Bug: 1043550
Change-Id: I78a27b74324f74b1e3c7528fc91badf85f65d22f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145247
Auto-Submit: Russell Davis <russell.davis@gmail.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Commit-Queue: Jeff Fisher <jeffish@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#759048}
3 files changed
tree: af47c79f8636e84bce57cf3c4b573989f266005c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.