commit | 5cc4cc8d349bb47b5bc0efc0a2672366489879d9 | [log] [tgz] |
---|---|---|
author | Russell Davis <russell.davis@gmail.com> | Tue Apr 14 22:56:56 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Apr 14 22:56:56 2020 |
tree | af47c79f8636e84bce57cf3c4b573989f266005c | |
parent | 709fad70a98c25ab4cbee9ede634be741debc5ab [diff] |
Fix Find behaving like Find Next This bug happened in two cases when using Find: 1) On macOS, always 2) On all platforms, when text is selected This change fixes both cases, while also unifying macOS behavior with other platforms. (I think the previous exclusion of macOS from the find-from-selection behavior may have been due to a misunderstanding of some mac-specific code/comments.) Now, when doing a find-from-selection, the initial result is the same selected text, rather than the next occurrence. So it's a no-op (as it should be) in terms of the selection and the document scroll position. Bug: 1043550 Change-Id: I78a27b74324f74b1e3c7528fc91badf85f65d22f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145247 Auto-Submit: Russell Davis <russell.davis@gmail.com> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Jeff Fisher <jeffish@microsoft.com> Commit-Queue: Jeff Fisher <jeffish@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759048}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.