commit | 5e65e3a4fbb5d4815760fc9b31f3bb5fb81bfbc9 | [log] [tgz] |
---|---|---|
author | scottmg <scottmg@chromium.org> | Wed Mar 08 08:48:46 2017 |
committer | Commit bot <commit-bot@chromium.org> | Wed Mar 08 08:48:46 2017 |
tree | dac363b64cccffd063d44836991f21301cefbe49 | |
parent | f44c2f8d3e188f4e4bca155d34ab5f6edbf0964a [diff] |
Require explicit selection of traits for LazyInstance This change requires the user of LazyInstance to explicitly select either ::DestructorAtExit or ::Leaky. It seems clear that many users of LazyInstance have just gone with default and are either unaware or didn't consider that the default requires running an AtExit at process shutdown. As a first step, make this choice explicit, and update current users to be ::DestructorAtExit to maintain current behaviour. Follow ups can then attempt to consider individual switches from DestructorAtExit to Leaky including reviewers with domain-specific knowledge. i.e. No intended behaviour change from this CL. R=thakis@chromium.org Lots of TBRs for mechanical changes: boliu: android_webview/ danakj: cc/ dmurph: storage/ jam: content/ ipc/, mojo/ jbauman: gpu/ jochen: gin/ oshima: chromeos/ raymes: ppapi/ rdevlin.cronin: extensions/ rockot: device/, services/ rogerta: google_apis/ rsleevi: net/, crypto/ sdefresne: components/, ios/ sergeyu: jingle/ slan: chromecast/ thakis: base/, chrome/, third_party/, tools/, ui/ vitalybuka: printing/ wez: remoting/ TBR=above BUG=698982 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2733283002 Cr-Commit-Position: refs/heads/master@{#455405}