commit | 66702158f87ee7f32d25907089163e87f111a650 | [log] [tgz] |
---|---|---|
author | Elie Maamari <emaamari@google.com> | Wed Apr 06 12:03:50 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 06 12:03:50 2022 |
tree | 6f442f02df849edbae09afad6603a4a177297399 | |
parent | 31cd145fdf787cb7f6f740eb3a31d939f0177a1c [diff] |
Make FakeUserDataAuthClient create profile directory in browser tests Some browser tests save user in local state in a PRE test before running the actual test, with the assumption that the user will be recognized as a returning user during the actual test. This assumption breaks with AuthSession enabled + FakeUserDataAuthClient as AuthSessionAuthenticator::OnAuthSessionCreatedGeneric gets notified that the user doesn't exist and is new. This CL makes FakeUserDataAuthClient create a profile directory under the user data directory in the PRE test so that we'll be able to recognize the user during the actual test. It also parametrizes the tests that were fixed as a function of auth session feature state. Bug: 1274116 Change-Id: I2d1723c0367b3dbe71ae78cbcda4a6b782504a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537129 Reviewed-by: Pavol Marko <pmarko@chromium.org> Reviewed-by: Denis Kuznetsov <antrim@chromium.org> Reviewed-by: Polina Bondarenko <pbond@chromium.org> Reviewed-by: Yves Arrouye <drcrash@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Elie Maamari <emaamari@google.com> Cr-Commit-Position: refs/heads/main@{#989379}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.