[go: nahoru, domu]
Google Git
Sign in
chromium / chromium / src / 68705a5791553735dbf13d178fcbe3cab9067122
commit68705a5791553735dbf13d178fcbe3cab9067122[log] [tgz]
authorYuichiro Hanada <yhanada@google.com>Wed Mar 06 23:23:09 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Mar 06 23:23:09 2024
tree63ad748f53cc915854c4503086082e996c107c7c
parentadcea4dee94b23702651d508e1315ccc1e81528e [diff]
[Merge to M123] wm: Fix crash when there is no limit of max size

WindowDelegate::GetMaximumSize() returns 0x0 if there is no limit,
but gfx::SizeRectToAspectRatio expects std::nullopt in this case.
Passing gfx::SizeRectToAspectRatio causes the crash in std::clamp.

(cherry picked from commit 67f77562a2fe6198b40b085a004b8a7b0c2d14c1)

Bug: 322282313
Test: manual - follow the steps described in the bug and interact with a pip window. Chrome doesn't crash.
Change-Id: I06ebb632faf734f14c4d87faa7df472951bb588a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5334542
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1267659}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5348478
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuichiro Hanada <yhanada@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6312@{#436}
Cr-Branched-From: 6711dcdae48edaf98cbc6964f90fac85b7d9986e-refs/heads/main@{#1262506}
1 file changed
tree: 63ad748f53cc915854c4503086082e996c107c7c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.