tree 6f06e94fd844f2bf5b847dd6b2a03af95e263c7c
parent eb57aab35a21496d234bbd753db69bac5e72bdee
author Andy Phan <andyphan@chromium.org> 1708137685 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1708137685 +0000

[OOPIF PDF] Fix presentation mode not working correctly

Fix presentation mode failing to work by changing the PDF outer <embed>
to an <iframe>. Give the iframe the 'allow' attribute and allow
fullscreen for all origins so that the PDF extension in the iframe can
use Element.requestFullscreen().

The web spec for Element.requestFullscreen() requires that the element
requesting fullscreen must be in the top-level document or in an
<iframe> with the 'allow' attribute allowing fullscreen. The element
requesting fullscreen resides in the PDF extension.

In GuestView PDF viewer, the PDF extension is in the top-level document
of the inner WebContents, so the element is allowed to fullscreen.

In OOPIF PDF viewer, the PDF extension is no longer in the top-level
document. This CL uses the other <iframe> requirement to allow
fullscreen.

The <embed> used to be an <iframe>, but was changed in
https://crrev.com/659508. After https://crrev.com/1257705, OOPIF tests
don't need the element to be an <embed> anymore.

Bug: 41495166
Change-Id: I4031c782f24e7f3656c430767f2a6e67ba8d01b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5269765
Commit-Queue: Andy Phan <andyphan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1262032}