commit | 69dc1ea10c3aadd5dac7f524c78471c08c6c67aa | [log] [tgz] |
---|---|---|
author | Bert Belder <bertbelder@gmail.com> | Thu Dec 13 02:02:46 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Dec 13 02:02:46 2018 |
tree | 6ca7ed57f3777f9f6427900bffcd5b60c945c121 | |
parent | 4534f493a03b9510055516a5bd13898f4e74601c [diff] |
Control windows lld-link thin archive flag with config("thin_archive") We're trying to build a self-contained static library of V8, for inclusion in a Cargo crate. This is part of the broader effort to make Deno (https://github.com/denoland/deno) available as a crate. Currently it's not possible to build 'fat' static libraries with lld-link, because the `/llvmlibthin` flag is hard-coded into the windows toolchain. The equivalent on posix platforms, ar's `-T` flag, is managed by the `thin_archive` config. This config is enabled by default, but it can be explicitly removed from a target when necessary. This patch changes places the `/llvmlibthin` flag under control of config("thin_archive") also. This causes static_library targets that use the thin_archive machinery to not be thin archives on Windows either. There aren't many of these targets, and this looks like a neutral-to-vaguely-good change for these targets on Windows. Change-Id: If756650146459c4029d7925592e32dbe74650edf Reviewed-on: https://chromium-review.googlesource.com/c/1372633 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#616162}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .