commit | 617088e810f99bc6b48157840666bedc85b0ca13 | [log] [tgz] |
---|---|---|
author | luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> | Thu Jan 25 04:05:55 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 25 04:05:55 2024 |
tree | 6354cfbd883a692390d4412d18883ef18cb50ca4 | |
parent | 01fd8b0a803e636f2bc8340a62353d8b0800e2db [diff] |
Revert "Revert^2 "Revert "Reapply "Reland "webauthn: add EnclaveManager""""" This reverts commit 8edb95bf324912599185daafabda4aa3df641f36. Reason for revert: LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8757961552273000001 Sample failed build: https://ci.chromium.org/b/8757961552273000001 If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8757961552273000001&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5233429 Original change's description: > Revert^2 "Revert "Reapply "Reland "webauthn: add EnclaveManager"""" > > This reverts commit 401be556c01bda223bdbb902dc957494c629df33. > > Reason for revert: resolved by crrev.com/c/5232771 > > Original change's description: > > Revert "Revert "Reapply "Reland "webauthn: add EnclaveManager"""" > > > > This reverts commit dbe53526028de702601002734dbd961b8005cb1e. > > > > Reason for revert: > > LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8757963839160801713 > > > > Sample failed build: https://ci.chromium.org/b/8757963839160801713 > > > > If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8757963839160801713&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5233385 > > > > Original change's description: > > > Revert "Reapply "Reland "webauthn: add EnclaveManager""" > > > > > > This reverts commit 837d08123460366085e05bb0b31c688fade1b70e. > > > > > > Reason for revert: > > > EnclaveManagerTest is failing on the Linux MSan bot: > > > https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/45569/overview > > > > > > Original change's description: > > > > Reapply "Reland "webauthn: add EnclaveManager"" > > > > > > > > Landed in bb39fe0dd8f71795882de57f6ec4d0027528a7da but collided with a > > > > change to Rust GN and we mutually broke each other. > > > > > > > > Reverted in df4f3f5e506ed21be7aecaa85de30be8110ad010. Then I reverted > > > > the revert and set the CQ running figuring that it would land if it was > > > > ok now. However, the CQ doesn't run in that case and it landed > > > > immediately! So I reverted immediately again in > > > > 48711548e9add0a0303944e8241f238051948ddc because it was late. > > > > > > > > Thus this this is the 3rd attempt. > > > > > > > > Bug: 1459620 > > > > Change-Id: I539fa2321a8b7b9919f8226f1fe25dfa8e78c78a > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5235058 > > > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > > > Auto-Submit: Adam Langley <agl@chromium.org> > > > > Commit-Queue: Robert Sesek <rsesek@chromium.org> > > > > Cr-Commit-Position: refs/heads/main@{#1251743} > > > > > > Bug: 1459620 > > > Change-Id: I2a7fedef27edb00c224ee792d08f08615fdd181c > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5233385 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > > > Owners-Override: Hiroki Nakagawa <nhiroki@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#1251875} > > > > > > > Bug: 1459620 > > Change-Id: Ia2b2d2c4338b75bb91d3372be5292512ee539235 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5235766 > > Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> > > Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> > > Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/main@{#1251880} > > Bug: 1459620 > Change-Id: I72edb671a3a32e22995e06205eab58c13b0e2d14 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5233429 > Auto-Submit: Eriko Kurimoto <elkurin@chromium.org> > Owners-Override: Eriko Kurimoto <elkurin@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1251881} > Bug: 1459620 Change-Id: I2a7acbccd87bda19d2003a8f8539f0e91484ee66 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5235432 Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1251891}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.