commit | 6be0d4c7bbe4a30a8d21c37b7ee91b49496ac31e | [log] [tgz] |
---|---|---|
author | Simon Zünd <szuend@chromium.org> | Mon Oct 25 14:16:32 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Oct 25 14:16:32 2021 |
tree | 53528ac28b4418443ec82a6320e9e758363469c9 | |
parent | 69f6b39ad47a46985362fda4734d4be613c062b1 [diff] |
[devtools] Fix flaky ExecutionContext events inspector test A recent CL changed the timing when ExecutionContexts are destroyed. For iframes, ExecutionContexts are kept alive even when the iframe is disconnected from the page. This makes ExecutionContext destruction timing depended on GC timing. This CL fixes a related inspector-protocol test by doing the following: 1) Wait for iframe content to be loaded. Otherwise we attempt to remove an iframe that's maybe not there. 2) Rather than hard coding the order of ExecutionContextDestroyed events, we simply wait at the end of the test and make sure that all created contexts are also destroyed. It doesn't really matter when, as long as they are properly cleaned up. The test is still rather slow due to all the navigations. Locally, it hovers around the 6 second runtime mark, causing sporadic timeouts. This CL also marks the test as "Slow", so it is run with a larger timeout window. R=wolfi@chromium.org Fixed: 1236466 Change-Id: Ieaad8887c7f4e3f4415a59d778218f4ac817b707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3240967 Reviewed-by: Wolfgang Beyer <wolfi@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#934518}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.