commit | 6eb8ee780269aef5cb975999e3575d0831275b40 | [log] [tgz] |
---|---|---|
author | Andrew Xu <andrewxu@chromium.org> | Tue Jul 26 00:11:01 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jul 26 00:11:01 2022 |
tree | d5c953ae8b7f56612034404cbc664a73f84635f6 | |
parent | 62eb5653348b53690dc7baa4487d73c163097cfc [diff] |
[Shelf] Add LoginShelfWidget that contains LoginShelfView Currently, `LoginShelfView` lives in `ShelfWidget` along with other Shelf components, such as the opaque background. As a result, when the login shelf is focused, `ShelfWidget` is stacked above its sibling widgets, which brings some unexpected side effects. To fix this issue, this CL adds a widget called `LoginShelfWidget` to contain `LoginShelfView`. `LoginShelfWidget` is used only when the corresponding feature flag is enabled. This CL should not bring any noticeable differences since the flag is still disabled. Bug: 1197052 Change-Id: Ib5992a70fcd841976430bab5097339ee6718ed22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3760071 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1028015}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.