[go: nahoru, domu]

Fix unrecognised args error in android/resource_sizes.py.

build/android/resource_sizes.py does not recognize
--isolated-script-test-repeat or
--isolated-script-test-launcher-retry-limit,
but apparently is now being passed those arguments on the bots, blocking
certain CLs from changing.

This behavion seems to have been introduced sometime in the past few
weeks.

This CL mirrors
https://chromium-review.googlesource.com/c/chromium/src/+/4737972,
which did the same for tools/binary_size/sizes.py, and landed last
year.

Sample error:

swarming_bot_logs: 2024-07-01 16:29:03.983: run_command(['/b/s/w/ir/.task_template_packages/rdb', 'stream', '-test-id-prefix', 'ninja://components/cronet/android:resource_sizes_cronet_sample_apk/', '-var', 'builder:android-cronet-x64-rel', '-var', 'os:Ubuntu-22.04', '-var', 'test_suite:resource_sizes_cronet_sample_apk', '-tag', 'step_name:resource_sizes_cronet_sample_apk (check flakiness shard #0) on Ubuntu-22.04', '-tag', 'target_platform:android', '-coerce-negative-duration', '-location-tags-file', '../../testing/location_tags.json', '-exonerate-unexpected-pass', '-inherit-sources', '-baseline-id', 'try:android-cronet-x64-rel', '--', 'result_adapter', 'single', '-result-file', '/b/s/w/iouufxrx9u/output.json', '-artifact-directory', '/b/s/w/iouufxrx9u', '--', 'luci-auth', 'context', '--', 'bin/run_resource_sizes_cronet_sample_apk', '--isolated-script-test-output=/b/s/w/iouufxrx9u/output.json', '--isolated-script-test-perf-output=/b/s/w/iouufxrx9u/perftest-output.json', '--isolated-script-test-filter=', '--isolated-script-test-repeat=20', '--isolated-script-test-launcher-retry-limit=0'], /b/s/w/ir/out/Release, 3600.0, 30.0, False, Containment<NONE, 0, 0>)
[W2024-07-01T09:29:04.225417-07:00 522989 0 cmd_stream.go:507] rdb-stream: ../../testing/location_tags.json does not exist
[I2024-07-01T09:29:04.225917-07:00 522989 0 sink.go:276] SinkServer: warm-up started
[I2024-07-01T09:29:04.226046-07:00 522989 0 sink.go:346] SinkServer: starting HTTP server...
[I2024-07-01T09:29:04.227057-07:00 522989 0 sink.go:281] SinkServer: warm-up ended
[I2024-07-01T09:29:04.227325-07:00 522989 0 cmd_stream.go:487] rdb-stream: starting the test command - ["result_adapter" "single" "-result-file" "/b/s/w/iouufxrx9u/output.json" "-artifact-directory" "/b/s/w/iouufxrx9u" "--" "luci-auth" "context" "--" "bin/run_resource_sizes_cronet_sample_apk" "--isolated-script-test-output=/b/s/w/iouufxrx9u/output.json" "--isolated-script-test-perf-output=/b/s/w/iouufxrx9u/perftest-output.json" "--isolated-script-test-filter=" "--isolated-script-test-repeat=20" "--isolated-script-test-launcher-retry-limit=0"]
usage: resource_sizes.py [-h] [--min-pak-resource-size MIN_PAK_RESOURCE_SIZE]
                         [--chromium-output-directory OUT_DIR] [--chartjson]
                         [--output-format {chartjson,histograms}]
                         [--loadable_module LOADABLE_MODULE]
                         [--output-dir OUTPUT_DIR | --output-file OUTPUT_FILE | --isolated-script-test-output ISOLATED_SCRIPT_TEST_OUTPUT]
                         [--trichrome-chrome TRICHROME_CHROME]
                         [--trichrome-webview TRICHROME_WEBVIEW]
                         [--trichrome-library TRICHROME_LIBRARY]
                         input
resource_sizes.py: error: unrecognized arguments: --isolated-script-test-repeat=20 --isolated-script-test-launcher-retry-limit=0
result_adapter: open result file: open /b/s/w/iouufxrx9u/output.json: no such file or directory

Bug: 1463948, 1469002
Change-Id: Ifccaa436b8d9dec6b55c208ee4dafcdbfc0a04d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5667086
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322154}
1 file changed
tree: 8c951fbb592623b8c0701859a843c76ebd9c4caa
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.