| commit | 6f505633a4330bf6877eed5aa391fa92a3eef223 | [log] [tgz] |
|---|---|---|
| author | Zhe Li <zheliooo@google.com> | Fri Sep 08 18:16:01 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Sep 08 18:16:01 2023 |
| tree | 1e3f04e1b9901c1c04a7e20363542db963bc9b80 | |
| parent | 2426030d97d52c8e5ff544cd87643ebc335823bf [diff] |
[APS] Center hover highlight on phones
- Create new style @style/ToolbarHoverableButton and use this for toolbar buttons that will use the custom hover state.
- Center hover highlight for optional and tab switcher button
- Change toolbar_phone_optional_button_foreground_start_padding from 20dp to 16dp to center optional button
- apply a toolbar_tab_switcher_button_ripple(with rightPadding) to tab_switcher_button in toolbar_phone
Optional button(profile):
https://screenshot.googleplex.com/8983xJBpGy9c8P5
Optional button(share): https://screenshot.googleplex.com/A4Vabe5g75VZBHs
Optional button(voice search): https://screenshot.googleplex.com/BTeSdTW2Wwe4G86
Demo: https://drive.google.com/file/d/1DLcvvymEZiouPfxwp1VSrx2SIAbgpd76/view?usp=sharing
Bug: 1475891
Change-Id: Iaf052f5b4a9fe8344d84563a1590e3bedebb8efa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4827665
Reviewed-by: Sirisha Kavuluru <skavuluru@google.com>
Commit-Queue: Zhe Li <zheliooo@google.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1194223}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.