| commit | 76eb5175c491e5e1d1f5081371048c473113b5d8 | [log] [tgz] |
|---|---|---|
| author | Michael Ludwig <michaelludwig@google.com> | Wed Sep 06 02:00:02 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Sep 06 02:00:02 2023 |
| tree | 08fc55435150522472f9aa17c42b4e24e4b71ae5 | |
| parent | 282ca5f52ed356dc61fe2ed47c8b96d7dde73ad2 [diff] |
Reland "Remove SK_USE_LEGACY_BLUR_IMAGEFILTER staging flag" This reverts commit 7a9d922349b9381e0bf8b21eddb9b9bd7f774713. Reason for revert: msan crash is a red herring; suppressing the test, landing this, and then fixing the crash cause in skia with another round of rebaseline+re-enables afterwards. Original change's description: > Revert "Remove SK_USE_LEGACY_BLUR_IMAGEFILTER staging flag" > > This reverts commit 069d3d9db0b3093fec0edee412abfbdb9316f460. > > Reason for revert: Linux MSan failures; see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/42742/overview. > > Original change's description: > > Remove SK_USE_LEGACY_BLUR_IMAGEFILTER staging flag > > > > With the removal of this flag, CPU-based blurs will now respect the > > SkTileMode passed to the blur image filter. Both GPU and CPU blurs > > will tend to have more optimal image sizes (smaller) when using > > kDecal. kDecal should also use fewer renderpasses. There is a > > temporary regression in image size and renderpasses for other tile > > modes but this is a required step in the overall blur refactoring. > > > > It also fixes a bug where decal would be applied to the intersection > > of both the filter region and primitive subregion when performing > > blurs in SVGs. This is why there are larger changes to the > > `effect-reference-subregion`: the blur is able to read the hidden color cells of the input image, some of which are red so the overall blur color shifts from green to brownish. > > > > Most viz pixel tests have benign updates. However, the blur_filter_with_clip test is meant to have clamped content. The SW > > expected image had baked in the previous limitation of decal-only > > blurs which is no longer the case. However, the software_renderer > > compositor seems to be sizing images a little off so the clamp is only > > applying to the top and left edges. Now the new expected image is > > just half wrong :) > > > > Chromium is still relying on deprecated behavior for clamped blurs > > where it doesn't specify the clamping geometry with the image filter. > > This will require more changes but would likely get around the issue > > with how the software_renderer prepares the images to be blurred. > > > > Numerous ash pixel tests had to be updated, but I couldn't spot any > > meaningful differences in their content. My guess is that the widgets > > and windows all had some amount of blur use, so this change touched > > everywhere. > > > > Bug: b/294100597 > > Bug: b/40040586 > > Change-Id: I67d5840113e87cfbed1d3a2c4d624c8216991775 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4818347 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > > Cr-Commit-Position: refs/heads/main@{#1191026} > > Bug: b/294100597 > Bug: b/40040586 > Change-Id: I9e8a7b8d6d046e68de3324a4a9f1a11c82897baa > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4835971 > Commit-Queue: Greg Thompson <grt@chromium.org> > Auto-Submit: Greg Thompson <grt@chromium.org> > Owners-Override: Greg Thompson <grt@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1191235} Bug: b/294100597 Bug: b/40040586 Bug: chromium:1324336 Change-Id: I56a3acbf42adbd86c864fb1c5ba8f85d5bf1b58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4843688 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#1192818}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.