[go: nahoru, domu]

assistant: Remove feature flag AssistantLearnMore

Currently there are two feature flags.
Feature engagement feature: IPH_LauncherSearchHelpUi
and feature: AssistantLearnMore

We could consolidate them by removing AssistantLearnMore to simplify the
code and testing.

Bug: b/316167902
Test: passed current tests
Change-Id: I61f02d5e7ac68bac52aec408acad2a4e231ace3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5118624
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Yuki Awano <yawano@google.com>
Cr-Commit-Position: refs/heads/main@{#1238279}
diff --git a/ash/BUILD.gn b/ash/BUILD.gn
index f5845dd..797536a 100644
--- a/ash/BUILD.gn
+++ b/ash/BUILD.gn
@@ -3993,6 +3993,7 @@
     "//components/app_restore",
     "//components/desks_storage",
     "//components/desks_storage:test_support",
+    "//components/feature_engagement/public",
     "//components/global_media_controls",
     "//components/language/core/browser:browser",
     "//components/live_caption:constants",
@@ -4185,6 +4186,7 @@
     "//chromeos/dbus/power:power",
     "//chromeos/dbus/power:power_manager_proto",
     "//chromeos/services/network_config/public/cpp:test_support",
+    "//components/feature_engagement/public",
     "//components/user_education/common",
     "//components/user_education/views",
     "//components/user_manager",
diff --git a/ash/app_list/BUILD.gn b/ash/app_list/BUILD.gn
index 1bb7d7d..593449dd 100644
--- a/ash/app_list/BUILD.gn
+++ b/ash/app_list/BUILD.gn
@@ -184,6 +184,7 @@
     "//chromeos/ui/vector_icons",
     "//chromeos/ui/wm",
     "//chromeos/utils",
+    "//components/feature_engagement/public",
     "//components/keyed_service/core",
     "//components/pref_registry",
     "//components/prefs",
@@ -329,6 +330,7 @@
     "//base/test:test_support",
     "//chromeos/ash/components/feature_usage",
     "//chromeos/ash/services/assistant/public/cpp",
+    "//components/feature_engagement/public",
     "//mojo/core/embedder",
     "//mojo/public/cpp/bindings",
     "//skia",
diff --git a/ash/app_list/DEPS b/ash/app_list/DEPS
index f66bdb7..ef5e9546 100644
--- a/ash/app_list/DEPS
+++ b/ash/app_list/DEPS
@@ -5,6 +5,7 @@
   "+ash/resources/vector_icons",
   "+ash/strings",
   "+chromeos/utils",
+  "+components/feature_engagement/public/feature_constants.h",
   "+components/keyed_service/core",
   "+components/sync",
   "+mojo/public/cpp",
diff --git a/ash/app_list/views/app_list_view_pixeltest.cc b/ash/app_list/views/app_list_view_pixeltest.cc
index 8ccf9d28..22e660e 100644
--- a/ash/app_list/views/app_list_view_pixeltest.cc
+++ b/ash/app_list/views/app_list_view_pixeltest.cc
@@ -24,8 +24,7 @@
 #include "ash/wm/tablet_mode/tablet_mode_controller.h"
 #include "base/run_loop.h"
 #include "base/test/scoped_feature_list.h"
-#include "chromeos/ash/services/assistant/public/cpp/features.h"
-#include "chromeos/constants/chromeos_features.h"
+#include "components/feature_engagement/public/feature_constants.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/events/test/event_generator.h"
 #include "ui/events/types/event_type.h"
@@ -461,8 +460,8 @@
   }
 
   void SetUp() override {
-    scoped_features_.InitWithFeatureStates(
-        {{assistant::features::kEnableAssistantLearnMore, true}});
+    scoped_feature_list_.InitAndEnableFeature(
+        feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
     AssistantAshTestBase::SetUp();
     SetNumberOfSessionsWhereOnboardingShown(
@@ -475,7 +474,7 @@
   }
 
  private:
-  base::test::ScopedFeatureList scoped_features_;
+  base::test::ScopedFeatureList scoped_feature_list_;
 };
 
 INSTANTIATE_TEST_SUITE_P(RTL,
diff --git a/ash/app_list/views/assistant/assistant_main_stage.cc b/ash/app_list/views/assistant/assistant_main_stage.cc
index add1322..b8edaf2 100644
--- a/ash/app_list/views/assistant/assistant_main_stage.cc
+++ b/ash/app_list/views/assistant/assistant_main_stage.cc
@@ -18,13 +18,13 @@
 #include "ash/assistant/ui/main_stage/ui_element_container_view.h"
 #include "ash/assistant/util/animation_util.h"
 #include "ash/assistant/util/assistant_util.h"
-#include "ash/constants/ash_features.h"
 #include "ash/public/cpp/assistant/controller/assistant_interaction_controller.h"
 #include "ash/public/cpp/assistant/controller/assistant_ui_controller.h"
 #include "ash/public/cpp/style/color_provider.h"
+#include "base/feature_list.h"
 #include "base/functional/bind.h"
 #include "base/time/time.h"
-#include "chromeos/ash/services/assistant/public/cpp/features.h"
+#include "components/feature_engagement/public/feature_constants.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/metadata/metadata_impl_macros.h"
 #include "ui/color/color_id.h"
@@ -120,7 +120,8 @@
     AssistantViewDelegate* delegate)
     : delegate_(delegate) {
   SetID(AssistantViewID::kMainStage);
-  if (assistant::features::IsAssistantLearnMoreEnabled()) {
+  if (base::FeatureList::IsEnabled(
+          feature_engagement::kIPHLauncherSearchHelpUiFeature)) {
     InitLayoutWithIph();
   } else {
     InitLayout();
@@ -480,7 +481,8 @@
   assistant::util::FadeOutAndHide(zero_state_view_,
                                   kZeroStateAnimationFadeOutDuration);
 
-  if (assistant::features::IsAssistantLearnMoreEnabled()) {
+  if (base::FeatureList::IsEnabled(
+          feature_engagement::kIPHLauncherSearchHelpUiFeature)) {
     AnimateInFooter();
   }
 }
@@ -499,7 +501,8 @@
   } else {
     AnimateInZeroState();
 
-    if (assistant::features::IsAssistantLearnMoreEnabled()) {
+    if (base::FeatureList::IsEnabled(
+            feature_engagement::kIPHLauncherSearchHelpUiFeature)) {
       footer_->SetVisible(false);
     } else {
       AnimateInFooter();
diff --git a/ash/app_list/views/assistant/assistant_main_stage_unittest.cc b/ash/app_list/views/assistant/assistant_main_stage_unittest.cc
index 181e835..ba1798a 100644
--- a/ash/app_list/views/assistant/assistant_main_stage_unittest.cc
+++ b/ash/app_list/views/assistant/assistant_main_stage_unittest.cc
@@ -12,7 +12,7 @@
 #include "ash/style/ash_color_provider.h"
 #include "ash/style/dark_light_mode_controller_impl.h"
 #include "base/test/scoped_feature_list.h"
-#include "chromeos/ash/services/assistant/public/cpp/features.h"
+#include "components/feature_engagement/public/feature_constants.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/color/color_id.h"
 #include "ui/gfx/canvas.h"
@@ -72,7 +72,7 @@
 TEST_F(AssistantMainStageTest, FooterIsVisible) {
   base::test::ScopedFeatureList scoped_feature_list;
   scoped_feature_list.InitAndDisableFeature(
-      assistant::features::kEnableAssistantLearnMore);
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   ShowAssistantUi();
 
@@ -82,7 +82,7 @@
 
 TEST_F(AssistantMainStageTest, FooterIsNotVisible) {
   base::test::ScopedFeatureList scoped_feature_list(
-      assistant::features::kEnableAssistantLearnMore);
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   ShowAssistantUi();
 
@@ -92,7 +92,7 @@
 
 TEST_F(AssistantMainStageTest, FooterIsVisibleAfterQuery) {
   base::test::ScopedFeatureList scoped_feature_list(
-      assistant::features::kEnableAssistantLearnMore);
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   ShowAssistantUi();
 
@@ -105,7 +105,7 @@
 
 TEST_F(AssistantMainStageTest, FooterIsVisibleAfterResponse) {
   base::test::ScopedFeatureList scoped_feature_list(
-      assistant::features::kEnableAssistantLearnMore);
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   ShowAssistantUi();
 
@@ -119,7 +119,7 @@
 TEST_F(AssistantMainStageTest, FooterIsVisible_Tablet) {
   base::test::ScopedFeatureList scoped_feature_list;
   scoped_feature_list.InitAndDisableFeature(
-      assistant::features::kEnableAssistantLearnMore);
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   SetTabletMode(true);
   ShowAssistantUi();
@@ -130,7 +130,7 @@
 
 TEST_F(AssistantMainStageTest, FooterIsNotVisible_Tablet) {
   base::test::ScopedFeatureList scoped_feature_list(
-      assistant::features::kEnableAssistantLearnMore);
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   SetTabletMode(true);
   ShowAssistantUi();
@@ -141,7 +141,7 @@
 
 TEST_F(AssistantMainStageTest, FooterIsVisibleAfterQuery_Tablet) {
   base::test::ScopedFeatureList scoped_feature_list(
-      assistant::features::kEnableAssistantLearnMore);
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   SetTabletMode(true);
   ShowAssistantUi();
@@ -157,7 +157,7 @@
 
 TEST_F(AssistantMainStageTest, FooterIsVisibleAfterResponse_Tablet) {
   base::test::ScopedFeatureList scoped_feature_list(
-      assistant::features::kEnableAssistantLearnMore);
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   SetTabletMode(true);
   ShowAssistantUi();
diff --git a/ash/assistant/ui/BUILD.gn b/ash/assistant/ui/BUILD.gn
index a6b07d1..089fbec 100644
--- a/ash/assistant/ui/BUILD.gn
+++ b/ash/assistant/ui/BUILD.gn
@@ -103,6 +103,7 @@
     "//chromeos/ash/services/assistant/public/mojom",
     "//chromeos/ash/services/libassistant/public/cpp:structs",
     "//chromeos/ui/vector_icons",
+    "//components/feature_engagement/public",
     "//components/vector_icons",
     "//ui/aura",
     "//ui/chromeos/styles:cros_styles_views",
diff --git a/ash/assistant/ui/DEPS b/ash/assistant/ui/DEPS
index b28d5de..484c287 100644
--- a/ash/assistant/ui/DEPS
+++ b/ash/assistant/ui/DEPS
@@ -19,6 +19,7 @@
   "+chromeos/ash/services/assistant/public/cpp",
   "+chromeos/ash/services/libassistant/public/cpp",
   "+chromeos/constants",
+  "+components/feature_engagement/public/feature_constants.h",
   "+mojo/public/cpp",
   "+net/base",
   "+third_party/skia/include/core",
diff --git a/ash/assistant/ui/main_stage/assistant_zero_state_view.cc b/ash/assistant/ui/main_stage/assistant_zero_state_view.cc
index 034dcb2f..a80b9d669 100644
--- a/ash/assistant/ui/main_stage/assistant_zero_state_view.cc
+++ b/ash/assistant/ui/main_stage/assistant_zero_state_view.cc
@@ -12,15 +12,15 @@
 #include "ash/assistant/ui/assistant_view_ids.h"
 #include "ash/assistant/ui/main_stage/assistant_onboarding_view.h"
 #include "ash/assistant/ui/main_stage/launcher_search_iph_view.h"
-#include "ash/constants/ash_features.h"
 #include "ash/public/cpp/assistant/assistant_state.h"
 #include "ash/public/cpp/assistant/controller/assistant_controller.h"
 #include "ash/public/cpp/assistant/controller/assistant_ui_controller.h"
 #include "ash/strings/grit/ash_strings.h"
 #include "ash/style/ash_color_id.h"
+#include "base/feature_list.h"
 #include "base/notreached.h"
 #include "base/strings/string_piece.h"
-#include "chromeos/ash/services/assistant/public/cpp/features.h"
+#include "components/feature_engagement/public/feature_constants.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/metadata/metadata_impl_macros.h"
@@ -44,14 +44,16 @@
 constexpr int kOnboardingViewTopMarginDip = 48;
 
 bool ShouldShowGreetingOrOnboarding(bool in_tablet_mode) {
-  if (assistant::features::IsAssistantLearnMoreEnabled()) {
+  if (base::FeatureList::IsEnabled(
+          feature_engagement::kIPHLauncherSearchHelpUiFeature)) {
     return !in_tablet_mode;
   }
   return true;
 }
 
 bool ShouldShowIph() {
-  return assistant::features::IsAssistantLearnMoreEnabled();
+  return base::FeatureList::IsEnabled(
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 }
 
 }  // namespace
diff --git a/ash/assistant/ui/main_stage/assistant_zero_state_view_unittest.cc b/ash/assistant/ui/main_stage/assistant_zero_state_view_unittest.cc
index 793d6e6..7651ce78 100644
--- a/ash/assistant/ui/main_stage/assistant_zero_state_view_unittest.cc
+++ b/ash/assistant/ui/main_stage/assistant_zero_state_view_unittest.cc
@@ -17,6 +17,7 @@
 #include "base/test/scoped_feature_list.h"
 #include "chromeos/ash/services/assistant/public/cpp/features.h"
 #include "chromeos/constants/chromeos_features.h"
+#include "components/feature_engagement/public/feature_constants.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/chromeos/styles/cros_styles.h"
 #include "ui/chromeos/styles/cros_tokens_color_mappings.h"
@@ -168,9 +169,9 @@
 }
 
 TEST_F(AssistantZeroStateViewUnittest, IphViewIsNotVisible) {
-  base::test::ScopedFeatureList feature_list_;
-  feature_list_.InitAndDisableFeature(
-      assistant::features::kEnableAssistantLearnMore);
+  base::test::ScopedFeatureList feature_list;
+  feature_list.InitAndDisableFeature(
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   ShowAssistantUi();
 
@@ -183,8 +184,8 @@
 }
 
 TEST_F(AssistantZeroStateViewUnittest, IphViewIsVisible) {
-  base::test::ScopedFeatureList scoped_feature_list(
-      assistant::features::kEnableAssistantLearnMore);
+  base::test::ScopedFeatureList feature_list(
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   ShowAssistantUi();
 
@@ -197,8 +198,8 @@
 }
 
 TEST_F(AssistantZeroStateViewUnittest, IphViewIsNotVisibleAfterResponse) {
-  base::test::ScopedFeatureList scoped_feature_list(
-      assistant::features::kEnableAssistantLearnMore);
+  base::test::ScopedFeatureList feature_list(
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   ShowAssistantUi();
 
@@ -217,7 +218,7 @@
 TEST_F(AssistantZeroStateViewUnittest, IphViewIsNotVisible_TabletMode) {
   base::test::ScopedFeatureList feature_list_;
   feature_list_.InitAndDisableFeature(
-      assistant::features::kEnableAssistantLearnMore);
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   SetNumberOfSessionsWhereOnboardingShown(
       assistant::ui::kOnboardingMaxSessionsShown);
@@ -239,8 +240,8 @@
 }
 
 TEST_F(AssistantZeroStateViewUnittest, IphViewIsVisible_TabletMode) {
-  base::test::ScopedFeatureList scoped_feature_list(
-      assistant::features::kEnableAssistantLearnMore);
+  base::test::ScopedFeatureList feature_list(
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   SetNumberOfSessionsWhereOnboardingShown(
       assistant::ui::kOnboardingMaxSessionsShown);
@@ -263,8 +264,8 @@
 
 TEST_F(AssistantZeroStateViewUnittest,
        IphViewIsNotVisibleAfterResponse_TabletMode) {
-  base::test::ScopedFeatureList scoped_feature_list(
-      assistant::features::kEnableAssistantLearnMore);
+  base::test::ScopedFeatureList feature_list(
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   SetNumberOfSessionsWhereOnboardingShown(
       assistant::ui::kOnboardingMaxSessionsShown);
diff --git a/ash/assistant/ui/main_stage/launcher_search_iph_view_unittest.cc b/ash/assistant/ui/main_stage/launcher_search_iph_view_unittest.cc
index 9146a59..39d18e1d 100644
--- a/ash/assistant/ui/main_stage/launcher_search_iph_view_unittest.cc
+++ b/ash/assistant/ui/main_stage/launcher_search_iph_view_unittest.cc
@@ -9,7 +9,7 @@
 #include "ash/assistant/ui/main_stage/chip_view.h"
 #include "base/memory/raw_ptr.h"
 #include "base/test/scoped_feature_list.h"
-#include "chromeos/ash/services/assistant/public/cpp/features.h"
+#include "components/feature_engagement/public/feature_constants.h"
 
 namespace ash {
 
@@ -22,7 +22,7 @@
 TEST_F(LauncherSearchIphViewTest,
        ShouldShuffleQueriesWhenShowingAssistantPage) {
   base::test::ScopedFeatureList scoped_feature_list(
-      assistant::features::kEnableAssistantLearnMore);
+      feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
   ShowAssistantUi();
   LauncherSearchIphView* iph_view = static_cast<LauncherSearchIphView*>(
diff --git a/ash/assistant/ui/main_stage/suggestion_container_view.cc b/ash/assistant/ui/main_stage/suggestion_container_view.cc
index 2f8ae18..09f3c92 100644
--- a/ash/assistant/ui/main_stage/suggestion_container_view.cc
+++ b/ash/assistant/ui/main_stage/suggestion_container_view.cc
@@ -18,14 +18,14 @@
 #include "ash/assistant/ui/main_stage/element_animator.h"
 #include "ash/assistant/util/animation_util.h"
 #include "ash/assistant/util/assistant_util.h"
-#include "ash/constants/ash_features.h"
 #include "ash/public/cpp/assistant/assistant_state.h"
 #include "ash/public/cpp/assistant/controller/assistant_suggestions_controller.h"
 #include "ash/public/cpp/assistant/controller/assistant_ui_controller.h"
+#include "base/feature_list.h"
 #include "base/functional/bind.h"
 #include "base/memory/raw_ptr.h"
 #include "base/metrics/histogram_functions.h"
-#include "chromeos/ash/services/assistant/public/cpp/features.h"
+#include "components/feature_engagement/public/feature_constants.h"
 #include "ui/base/metadata/metadata_impl_macros.h"
 #include "ui/compositor/callback_layer_animation_observer.h"
 #include "ui/compositor/layer.h"
@@ -178,7 +178,8 @@
     return;
   }
 
-  if (assistant::features::IsAssistantLearnMoreEnabled()) {
+  if (base::FeatureList::IsEnabled(
+          feature_engagement::kIPHLauncherSearchHelpUiFeature)) {
     return;
   }
 
diff --git a/chrome/browser/ash/app_list/launcher_search_iph_browsertest.cc b/chrome/browser/ash/app_list/launcher_search_iph_browsertest.cc
index 619741d9..19cd5b53 100644
--- a/chrome/browser/ash/app_list/launcher_search_iph_browsertest.cc
+++ b/chrome/browser/ash/app_list/launcher_search_iph_browsertest.cc
@@ -499,12 +499,13 @@
   EXPECT_FALSE(search_box_view()->assistant_button()->GetBackground());
 }
 
-// The bool param indicates if the AssistantLearnMore feature is enabled or not.
+// The bool param indicates if the kIPHLauncherSearchHelpUiFeature feature is
+// enabled or not.
 class AppListIphBrowserTestAssistantZeroState : public AppListIphBrowserTest {
  public:
   void SetUpCommandLine(base::CommandLine* command_line) override {
     scoped_feature_list_.InitAndEnableFeature(
-        ash::assistant::features::kEnableAssistantLearnMore);
+        feature_engagement::kIPHLauncherSearchHelpUiFeature);
 
     MixinBasedInProcessBrowserTest::SetUpCommandLine(command_line);
   }
@@ -515,7 +516,7 @@
 
 IN_PROC_BROWSER_TEST_P(AppListIphBrowserTest, NoAssistantZeroStateIphFlagOff) {
   ASSERT_FALSE(base::FeatureList::IsEnabled(
-      ash::assistant::features::kEnableAssistantLearnMore));
+      feature_engagement::kIPHLauncherSearchHelpUiFeature));
 
   OpenAppList();
 
diff --git a/chrome/browser/ash/app_list/search/assistant_text_search_provider.cc b/chrome/browser/ash/app_list/search/assistant_text_search_provider.cc
index 9b590c6..72b75ec 100644
--- a/chrome/browser/ash/app_list/search/assistant_text_search_provider.cc
+++ b/chrome/browser/ash/app_list/search/assistant_text_search_provider.cc
@@ -14,12 +14,13 @@
 #include "ash/public/cpp/assistant/controller/assistant_controller.h"
 #include "ash/public/cpp/assistant/controller/assistant_suggestions_controller.h"
 #include "ash/strings/grit/ash_strings.h"
+#include "base/feature_list.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ash/app_list/search/chrome_search_result.h"
 #include "chrome/browser/ash/app_list/search/common/icon_constants.h"
 #include "chromeos/ash/services/assistant/public/cpp/assistant_service.h"
-#include "chromeos/ash/services/assistant/public/cpp/features.h"
 #include "chromeos/ui/vector_icons/vector_icons.h"
+#include "components/feature_engagement/public/feature_constants.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/color_palette.h"
 #include "ui/gfx/paint_vector_icon.h"
@@ -37,7 +38,8 @@
 // Returns if the Assistant omnibox search provider is allowed to contribute
 // results.
 bool AreResultsAllowed() {
-  if (ash::assistant::features::IsAssistantLearnMoreEnabled()) {
+  if (base::FeatureList::IsEnabled(
+          feature_engagement::kIPHLauncherSearchHelpUiFeature)) {
     return false;
   }
 
diff --git a/chromeos/ash/services/assistant/public/cpp/features.cc b/chromeos/ash/services/assistant/public/cpp/features.cc
index b6596a7..f5abcc1 100644
--- a/chromeos/ash/services/assistant/public/cpp/features.cc
+++ b/chromeos/ash/services/assistant/public/cpp/features.cc
@@ -52,10 +52,6 @@
              "LibAssistantDLC",
              base::FEATURE_ENABLED_BY_DEFAULT);
 
-BASE_FEATURE(kEnableAssistantLearnMore,
-             "AssistantLearnMore",
-             base::FEATURE_DISABLED_BY_DEFAULT);
-
 BASE_FEATURE(kEnableAssistantOnboarding,
              "AssistantOnboarding",
              base::FEATURE_DISABLED_BY_DEFAULT);
@@ -108,10 +104,6 @@
   return base::FeatureList::IsEnabled(kEnableLibAssistantDLC);
 }
 
-bool IsAssistantLearnMoreEnabled() {
-  return base::FeatureList::IsEnabled(kEnableAssistantLearnMore);
-}
-
 bool IsOnboardingEnabled() {
   return base::FeatureList::IsEnabled(kEnableAssistantOnboarding);
 }
diff --git a/chromeos/ash/services/assistant/public/cpp/features.h b/chromeos/ash/services/assistant/public/cpp/features.h
index c39a4f8d..a09a037 100644
--- a/chromeos/ash/services/assistant/public/cpp/features.h
+++ b/chromeos/ash/services/assistant/public/cpp/features.h
@@ -50,9 +50,6 @@
 BASE_DECLARE_FEATURE(kEnableLibAssistantDLC);
 
 COMPONENT_EXPORT(ASSISTANT_SERVICE_PUBLIC)
-BASE_DECLARE_FEATURE(kEnableAssistantLearnMore);
-
-COMPONENT_EXPORT(ASSISTANT_SERVICE_PUBLIC)
 BASE_DECLARE_FEATURE(kEnableAssistantOnboarding);
 
 COMPONENT_EXPORT(ASSISTANT_SERVICE_PUBLIC) bool IsAppSupportEnabled();
@@ -80,8 +77,6 @@
 
 COMPONENT_EXPORT(ASSISTANT_SERVICE_PUBLIC) bool IsLibAssistantDLCEnabled();
 
-COMPONENT_EXPORT(ASSISTANT_SERVICE_PUBLIC) bool IsAssistantLearnMoreEnabled();
-
 COMPONENT_EXPORT(ASSISTANT_SERVICE_PUBLIC) bool IsOnboardingEnabled();
 
 }  // namespace ash::assistant::features