commit | 70039f1108b2dbf054200737179f34449fc4879e | [log] [tgz] |
---|---|---|
author | Maks Orlovich <morlovich@chromium.org> | Wed Nov 07 18:52:57 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Nov 07 18:52:57 2018 |
tree | aa9362fea4282d28268d8666e6af131579b13f77 | |
parent | 1abafc4947c106666856b343838b0e4b6094ddd3 [diff] |
HttpCache: be more conservative when trying to reconstruct a full resource from partial one. (With partial resource being a 206, not a truncated one). Previously we would happily use a first chunk from cache, then fail in panic when validation of the second chunk failed; this was especially bad for servers whose validation fails to match for resources for which headers suggest it should. After this change, in this case, we force a validation of the first chunk, and if it fails re-fetch the entire resource. This is far from ideal, but we have limitations when it comes to converting a pre-existing 206 entry to a 200 one that make using somewhat-better-in-this-case If-Range really painful (and there is no multi-range support, that would be useful for these sorts of reconstructions, either). (Heavily affects the lazyload experiment) Bug: 888742 Change-Id: I7f3f3b40dc1e2a98dd093ac09c98fe43eee5f3bd Reviewed-on: https://chromium-review.googlesource.com/c/1291595 Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#606092}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .