commit | 724339a80492d7504d8c9520f60ce0a7fc03809c | [log] [tgz] |
---|---|---|
author | David Bertoni <dbertoni@chromium.org> | Thu Jan 04 23:50:28 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 04 23:50:28 2024 |
tree | 0a7f7aec74e57940fcdc290a9b9f1bb78edcb41a | |
parent | a72b00436169ce2a05a62b85cb1b05980e5ba745 [diff] |
[Code Health] Remove uses of base::SupportsWeakPtr. (sync) This CL removes a use of base::SupportsWeakPtr from SyncableService abstract base class by: 1. Adding a pure virtual function to return a base::WeakPtr. 2. Adding base::WeakPtrFactory class instances to the deriving classes, if they don't already have one. 3. Implementing the function in the derived classes. In most cases, leaf classes that have WeakPtrFactory instances are marked as final for safety. However, there are some cases where test classes extends some production classes, so they are not marked as final. This can be fixed by expanding the class hierarchies, but that adds more work and complexity, so I didn't pursue that. Bug: 100114, 647430 Change-Id: Ia1e39071fd28130c8ea84e2282928350ddb43f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5165864 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1243158}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.