| commit | 72e9e3758c3009e9295f288470962073d53133cd | [log] [tgz] |
|---|---|---|
| author | Eriko Kurimoto <elkurin@chromium.org> | Wed Apr 20 17:00:29 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 20 17:00:29 2022 |
| tree | 7d4ec6592b4239131d0861a51bcb22d988748678 | |
| parent | 65d47d14be8d4319f8176175fc7c5ea4f525fa95 [diff] |
Reland "[Resource file sharing]: Initialize BrowserInitParams before PreSandboxStartup in browser process" This is a reland of commit fadc113a593e30ca2a3a0c00f5c8dd04af88af31 The diff between the original reverted change and the fix change can be checked by Patchset1 -> Patchset 2. BrowserInitParams class should be declared as COMPOENT_EXPORT since it is used from chromeos/lacros library. Original change's description: > [Resource file sharing]: Initialize BrowserInitParams before PreSandboxStartup in browser process > > This CL changes when to initialize BrowserInitParams to > PreSandboxStartup(). > > This is a part of resource file sharing work which requires ash resource > dir inside PreSandboxStartup(). > Ash resource dir path is given by BrowserInitParams, so needs to be > initialized before or inside PreSandboxStartup() while it was > initialized on PostEarlyInitialization() as a part of LacrosService in the previous implementation. > > This CL doesn't affect the behavior. > This change will be used in the following CLs. > > Bug: 1253280 > Change-Id: I64c2454f09e2b4a667005d7eea9565f12c626f32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3580292 > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Anqing Zhao <anqing@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#993594} Bug: 1253280 Change-Id: Idab9069fa704be42da641275d78e739e8c6cd10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3592116 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Anqing Zhao <anqing@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/main@{#994159}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.