commit | 7319bbdb7d6ea97ef3237381e4a88b7a465dd0da | [log] [tgz] |
---|---|---|
author | Peter Boström <pbos@chromium.org> | Wed Sep 15 22:59:38 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Sep 15 22:59:38 2021 |
tree | 1b35115afcb0b6299c534e1464f756f56b2f4273 | |
parent | 226bed55fdb4e4ba59dcd8ee7c9df451227544db [diff] |
Replace DISALLOW_COPY_AND_ASSIGN in base/ This replaces DISALLOW_COPY_AND_ASSIGN with explicit constructor deletes where a local script is able to detect its insertion place (~Foo() is public => insert before this line). This logic is wrong if ~Foo() has comments above it, as it should be inserted before that. This is incomplete as not all classes have a public ~Foo() declared, so not all DISALLOW_COPY_AND_ASSIGN occurrences are replaced. IWYU cleanup is left as a separate pass that is easier when these macros go away. Bug: 1010217 Change-Id: Ia83e0ea9132ef47450b22a6b4331a242e7519e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3163384 Reviewed-by: Lei Zhang <thestig@chromium.org> Owners-Override: Lei Zhang <thestig@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#921905}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.