Run clang-tidy modernize-use-equals-{delete,default} on //net, pt 2
See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8
This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md
In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
git diff --name-only | \
xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'
BUG=778959,778957
This CL was uploaded by git cl split.
R=eroman@chromium.org
Change-Id: I0c2a41fbeee3648e886b70f259e333176ffa4334
Reviewed-on: https://chromium-review.googlesource.com/799595
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520798}diff --git a/net/http/bidirectional_stream.cc b/net/http/bidirectional_stream.cc
index e13e3f7d..3c72898a 100644
--- a/net/http/bidirectional_stream.cc
+++ b/net/http/bidirectional_stream.cc
@@ -59,9 +59,9 @@
} // namespace
-BidirectionalStream::Delegate::Delegate() {}
+BidirectionalStream::Delegate::Delegate() = default;
-BidirectionalStream::Delegate::~Delegate() {}
+BidirectionalStream::Delegate::~Delegate() = default;
BidirectionalStream::BidirectionalStream(
std::unique_ptr<BidirectionalStreamRequestInfo> request_info,
diff --git a/net/http/bidirectional_stream_impl.cc b/net/http/bidirectional_stream_impl.cc
index 6cbf69f..b8d11dbc 100644
--- a/net/http/bidirectional_stream_impl.cc
+++ b/net/http/bidirectional_stream_impl.cc
@@ -6,12 +6,12 @@
namespace net {
-BidirectionalStreamImpl::Delegate::Delegate() {}
+BidirectionalStreamImpl::Delegate::Delegate() = default;
-BidirectionalStreamImpl::Delegate::~Delegate() {}
+BidirectionalStreamImpl::Delegate::~Delegate() = default;
-BidirectionalStreamImpl::BidirectionalStreamImpl() {}
+BidirectionalStreamImpl::BidirectionalStreamImpl() = default;
-BidirectionalStreamImpl::~BidirectionalStreamImpl() {}
+BidirectionalStreamImpl::~BidirectionalStreamImpl() = default;
} // namespace net
diff --git a/net/http/bidirectional_stream_request_info.cc b/net/http/bidirectional_stream_request_info.cc
index 309606e..e79c16b 100644
--- a/net/http/bidirectional_stream_request_info.cc
+++ b/net/http/bidirectional_stream_request_info.cc
@@ -9,6 +9,6 @@
BidirectionalStreamRequestInfo::BidirectionalStreamRequestInfo()
: priority(LOW), end_stream_on_headers(false) {}
-BidirectionalStreamRequestInfo::~BidirectionalStreamRequestInfo() {}
+BidirectionalStreamRequestInfo::~BidirectionalStreamRequestInfo() = default;
} // namespace net
diff --git a/net/http/bidirectional_stream_unittest.cc b/net/http/bidirectional_stream_unittest.cc
index 1d1cfe7..7ea853b 100644
--- a/net/http/bidirectional_stream_unittest.cc
+++ b/net/http/bidirectional_stream_unittest.cc
@@ -106,7 +106,7 @@
run_until_completion_(false),
not_expect_callback_(false) {}
- ~TestDelegateBase() override {}
+ ~TestDelegateBase() override = default;
void OnStreamReady(bool request_headers_sent) override {
// Request headers should always be sent in H2's case, because the
@@ -312,7 +312,7 @@
DeleteStreamDelegate(IOBuffer* buf, int buf_len, Phase phase)
: TestDelegateBase(buf, buf_len), phase_(phase) {}
- ~DeleteStreamDelegate() override {}
+ ~DeleteStreamDelegate() override = default;
void OnHeadersReceived(const SpdyHeaderBlock& response_headers) override {
TestDelegateBase::OnHeadersReceived(response_headers);
@@ -370,7 +370,7 @@
class MockTimer : public base::MockTimer {
public:
MockTimer() : base::MockTimer(false, false) {}
- ~MockTimer() override {}
+ ~MockTimer() override = default;
void Start(const base::Location& posted_from,
base::TimeDelta delay,
diff --git a/net/http/broken_alternative_services.cc b/net/http/broken_alternative_services.cc
index 2cb8cca8..0c42626f 100644
--- a/net/http/broken_alternative_services.cc
+++ b/net/http/broken_alternative_services.cc
@@ -39,7 +39,7 @@
DCHECK(clock_);
}
-BrokenAlternativeServices::~BrokenAlternativeServices() {}
+BrokenAlternativeServices::~BrokenAlternativeServices() = default;
void BrokenAlternativeServices::Clear() {
expiration_timer_.Stop();
diff --git a/net/http/failing_http_transaction_factory.cc b/net/http/failing_http_transaction_factory.cc
index d6202bf..ec8d9d0f 100644
--- a/net/http/failing_http_transaction_factory.cc
+++ b/net/http/failing_http_transaction_factory.cc
@@ -82,7 +82,7 @@
DCHECK_LT(error, OK);
}
-FailingHttpTransaction::~FailingHttpTransaction() {}
+FailingHttpTransaction::~FailingHttpTransaction() = default;
int FailingHttpTransaction::Start(const HttpRequestInfo* request_info,
const CompletionCallback& callback,
@@ -197,7 +197,7 @@
DCHECK_LT(error, OK);
}
-FailingHttpTransactionFactory::~FailingHttpTransactionFactory() {}
+FailingHttpTransactionFactory::~FailingHttpTransactionFactory() = default;
// HttpTransactionFactory:
int FailingHttpTransactionFactory::CreateTransaction(
diff --git a/net/http/http_auth_cache.cc b/net/http/http_auth_cache.cc
index 75f794d..57c1fe6 100644
--- a/net/http/http_auth_cache.cc
+++ b/net/http/http_auth_cache.cc
@@ -72,11 +72,9 @@
namespace net {
-HttpAuthCache::HttpAuthCache() {
-}
+HttpAuthCache::HttpAuthCache() = default;
-HttpAuthCache::~HttpAuthCache() {
-}
+HttpAuthCache::~HttpAuthCache() = default;
// Performance: O(n), where n is the number of realm entries.
HttpAuthCache::Entry* HttpAuthCache::Lookup(const GURL& origin,
@@ -183,8 +181,7 @@
HttpAuthCache::Entry::Entry(const Entry& other) = default;
-HttpAuthCache::Entry::~Entry() {
-}
+HttpAuthCache::Entry::~Entry() = default;
void HttpAuthCache::Entry::UpdateStaleChallenge(
const std::string& auth_challenge) {
diff --git a/net/http/http_auth_cache_unittest.cc b/net/http/http_auth_cache_unittest.cc
index 6ab67c4c..da2be13 100644
--- a/net/http/http_auth_cache_unittest.cc
+++ b/net/http/http_auth_cache_unittest.cc
@@ -53,7 +53,7 @@
private:
- ~MockAuthHandler() override {}
+ ~MockAuthHandler() override = default;
};
const char kRealm1[] = "Realm1";
diff --git a/net/http/http_auth_challenge_tokenizer.cc b/net/http/http_auth_challenge_tokenizer.cc
index 75c2d673..7ccd60b2 100644
--- a/net/http/http_auth_challenge_tokenizer.cc
+++ b/net/http/http_auth_challenge_tokenizer.cc
@@ -20,8 +20,7 @@
Init(begin, end);
}
-HttpAuthChallengeTokenizer::~HttpAuthChallengeTokenizer() {
-}
+HttpAuthChallengeTokenizer::~HttpAuthChallengeTokenizer() = default;
HttpUtil::NameValuePairsIterator HttpAuthChallengeTokenizer::param_pairs()
const {
diff --git a/net/http/http_auth_filter.cc b/net/http/http_auth_filter.cc
index 53d81ea..4d92591 100644
--- a/net/http/http_auth_filter.cc
+++ b/net/http/http_auth_filter.cc
@@ -21,8 +21,7 @@
SetWhitelist(server_whitelist);
}
-HttpAuthFilterWhitelist::~HttpAuthFilterWhitelist() {
-}
+HttpAuthFilterWhitelist::~HttpAuthFilterWhitelist() = default;
// Add a new domain |filter| to the whitelist, if it's not already there
bool HttpAuthFilterWhitelist::AddFilter(const std::string& filter,
diff --git a/net/http/http_auth_gssapi_posix.cc b/net/http/http_auth_gssapi_posix.cc
index 9838571..2ca0859 100644
--- a/net/http/http_auth_gssapi_posix.cc
+++ b/net/http/http_auth_gssapi_posix.cc
@@ -667,8 +667,7 @@
DCHECK(library_);
}
-HttpAuthGSSAPI::~HttpAuthGSSAPI() {
-}
+HttpAuthGSSAPI::~HttpAuthGSSAPI() = default;
bool HttpAuthGSSAPI::Init() {
if (!library_)
diff --git a/net/http/http_auth_handler.cc b/net/http/http_auth_handler.cc
index 3b0a4dce..5f035e0c 100644
--- a/net/http/http_auth_handler.cc
+++ b/net/http/http_auth_handler.cc
@@ -20,8 +20,7 @@
properties_(-1) {
}
-HttpAuthHandler::~HttpAuthHandler() {
-}
+HttpAuthHandler::~HttpAuthHandler() = default;
bool HttpAuthHandler::InitFromChallenge(HttpAuthChallengeTokenizer* challenge,
HttpAuth::Target target,
diff --git a/net/http/http_auth_handler_basic.cc b/net/http/http_auth_handler_basic.cc
index f756f05..ffec236 100644
--- a/net/http/http_auth_handler_basic.cc
+++ b/net/http/http_auth_handler_basic.cc
@@ -101,11 +101,9 @@
return OK;
}
-HttpAuthHandlerBasic::Factory::Factory() {
-}
+HttpAuthHandlerBasic::Factory::Factory() = default;
-HttpAuthHandlerBasic::Factory::~Factory() {
-}
+HttpAuthHandlerBasic::Factory::~Factory() = default;
int HttpAuthHandlerBasic::Factory::CreateAuthHandler(
HttpAuthChallengeTokenizer* challenge,
diff --git a/net/http/http_auth_handler_digest.cc b/net/http/http_auth_handler_digest.cc
index 39015ae7..58350701 100644
--- a/net/http/http_auth_handler_digest.cc
+++ b/net/http/http_auth_handler_digest.cc
@@ -49,14 +49,11 @@
// auth-int | | req-method:req-uri:MD5(req-entity-body) |
//=====================+==========================================+
-HttpAuthHandlerDigest::NonceGenerator::NonceGenerator() {
-}
+HttpAuthHandlerDigest::NonceGenerator::NonceGenerator() = default;
-HttpAuthHandlerDigest::NonceGenerator::~NonceGenerator() {
-}
+HttpAuthHandlerDigest::NonceGenerator::~NonceGenerator() = default;
-HttpAuthHandlerDigest::DynamicNonceGenerator::DynamicNonceGenerator() {
-}
+HttpAuthHandlerDigest::DynamicNonceGenerator::DynamicNonceGenerator() = default;
std::string HttpAuthHandlerDigest::DynamicNonceGenerator::GenerateNonce()
const {
@@ -82,8 +79,7 @@
: nonce_generator_(new DynamicNonceGenerator()) {
}
-HttpAuthHandlerDigest::Factory::~Factory() {
-}
+HttpAuthHandlerDigest::Factory::~Factory() = default;
void HttpAuthHandlerDigest::Factory::set_nonce_generator(
const NonceGenerator* nonce_generator) {
@@ -169,8 +165,7 @@
DCHECK(nonce_generator_);
}
-HttpAuthHandlerDigest::~HttpAuthHandlerDigest() {
-}
+HttpAuthHandlerDigest::~HttpAuthHandlerDigest() = default;
// The digest challenge header looks like:
// WWW-Authenticate: Digest
diff --git a/net/http/http_auth_handler_factory.cc b/net/http/http_auth_handler_factory.cc
index 97f3f2f7..c04ed23 100644
--- a/net/http/http_auth_handler_factory.cc
+++ b/net/http/http_auth_handler_factory.cc
@@ -104,11 +104,9 @@
} // namespace
-HttpAuthHandlerRegistryFactory::HttpAuthHandlerRegistryFactory() {
-}
+HttpAuthHandlerRegistryFactory::HttpAuthHandlerRegistryFactory() = default;
-HttpAuthHandlerRegistryFactory::~HttpAuthHandlerRegistryFactory() {
-}
+HttpAuthHandlerRegistryFactory::~HttpAuthHandlerRegistryFactory() = default;
void HttpAuthHandlerRegistryFactory::SetHttpAuthPreferences(
const std::string& scheme,
diff --git a/net/http/http_auth_handler_factory_unittest.cc b/net/http/http_auth_handler_factory_unittest.cc
index a0e6bafd..277a776 100644
--- a/net/http/http_auth_handler_factory_unittest.cc
+++ b/net/http/http_auth_handler_factory_unittest.cc
@@ -29,7 +29,7 @@
public:
explicit MockHttpAuthHandlerFactory(int return_code) :
return_code_(return_code) {}
- ~MockHttpAuthHandlerFactory() override {}
+ ~MockHttpAuthHandlerFactory() override = default;
int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge,
HttpAuth::Target target,
diff --git a/net/http/http_auth_handler_mock.cc b/net/http/http_auth_handler_mock.cc
index 061f99b..c908100 100644
--- a/net/http/http_auth_handler_mock.cc
+++ b/net/http/http_auth_handler_mock.cc
@@ -50,8 +50,7 @@
allows_explicit_credentials_(true),
weak_factory_(this) {}
-HttpAuthHandlerMock::~HttpAuthHandlerMock() {
-}
+HttpAuthHandlerMock::~HttpAuthHandlerMock() = default;
void HttpAuthHandlerMock::SetResolveExpectation(Resolve resolve) {
EXPECT_EQ(RESOLVE_INIT, resolve_);
@@ -203,8 +202,7 @@
// TODO(cbentzel): Default do_init_from_challenge_ to true.
}
-HttpAuthHandlerMock::Factory::~Factory() {
-}
+HttpAuthHandlerMock::Factory::~Factory() = default;
void HttpAuthHandlerMock::Factory::AddMockHandler(
HttpAuthHandler* handler, HttpAuth::Target target) {
diff --git a/net/http/http_auth_handler_negotiate.cc b/net/http/http_auth_handler_negotiate.cc
index afe8c00..cfce66fb4 100644
--- a/net/http/http_auth_handler_negotiate.cc
+++ b/net/http/http_auth_handler_negotiate.cc
@@ -49,8 +49,7 @@
is_unsupported_(false) {
}
-HttpAuthHandlerNegotiate::Factory::~Factory() {
-}
+HttpAuthHandlerNegotiate::Factory::~Factory() = default;
void HttpAuthHandlerNegotiate::Factory::set_host_resolver(
HostResolver* resolver) {
@@ -139,8 +138,7 @@
http_auth_preferences_(prefs) {
}
-HttpAuthHandlerNegotiate::~HttpAuthHandlerNegotiate() {
-}
+HttpAuthHandlerNegotiate::~HttpAuthHandlerNegotiate() = default;
std::string HttpAuthHandlerNegotiate::CreateSPN(const AddressList& address_list,
const GURL& origin) {
diff --git a/net/http/http_auth_handler_ntlm_portable.cc b/net/http/http_auth_handler_ntlm_portable.cc
index 2251b49..140bf6c 100644
--- a/net/http/http_auth_handler_ntlm_portable.cc
+++ b/net/http/http_auth_handler_ntlm_portable.cc
@@ -59,7 +59,7 @@
return OK;
}
-HttpAuthHandlerNTLM::~HttpAuthHandlerNTLM() {}
+HttpAuthHandlerNTLM::~HttpAuthHandlerNTLM() = default;
// static
HttpAuthHandlerNTLM::GetMSTimeProc HttpAuthHandlerNTLM::SetGetMSTimeProc(
@@ -85,9 +85,9 @@
return old_proc;
}
-HttpAuthHandlerNTLM::Factory::Factory() {}
+HttpAuthHandlerNTLM::Factory::Factory() = default;
-HttpAuthHandlerNTLM::Factory::~Factory() {}
+HttpAuthHandlerNTLM::Factory::~Factory() = default;
ntlm::Buffer HttpAuthHandlerNTLM::GetNextToken(const ntlm::Buffer& in_token) {
// If in_token is non-empty, then assume it contains a challenge message,
diff --git a/net/http/http_auth_preferences.cc b/net/http/http_auth_preferences.cc
index 64171d2..90848be 100644
--- a/net/http/http_auth_preferences.cc
+++ b/net/http/http_auth_preferences.cc
@@ -54,7 +54,7 @@
security_manager_(URLSecurityManager::Create()) {
}
-HttpAuthPreferences::~HttpAuthPreferences() {}
+HttpAuthPreferences::~HttpAuthPreferences() = default;
bool HttpAuthPreferences::IsSupportedScheme(const std::string& scheme) const {
return base::ContainsKey(auth_schemes_, scheme);
diff --git a/net/http/http_basic_state.cc b/net/http/http_basic_state.cc
index 90a2212c..0690de6 100644
--- a/net/http/http_basic_state.cc
+++ b/net/http/http_basic_state.cc
@@ -26,7 +26,7 @@
http_09_on_non_default_ports_enabled_(
http_09_on_non_default_ports_enabled) {}
-HttpBasicState::~HttpBasicState() {}
+HttpBasicState::~HttpBasicState() = default;
int HttpBasicState::Initialize(const HttpRequestInfo* request_info,
RequestPriority priority,
diff --git a/net/http/http_basic_stream.cc b/net/http/http_basic_stream.cc
index d47e3f3..2fc6c4e 100644
--- a/net/http/http_basic_stream.cc
+++ b/net/http/http_basic_stream.cc
@@ -21,7 +21,7 @@
using_proxy,
http_09_on_non_default_ports_enabled) {}
-HttpBasicStream::~HttpBasicStream() {}
+HttpBasicStream::~HttpBasicStream() = default;
int HttpBasicStream::InitializeStream(const HttpRequestInfo* request_info,
RequestPriority priority,
diff --git a/net/http/http_cache.cc b/net/http/http_cache.cc
index 7caf85c..0653b25 100644
--- a/net/http/http_cache.cc
+++ b/net/http/http_cache.cc
@@ -63,7 +63,7 @@
path_(path),
max_bytes_(max_bytes) {}
-HttpCache::DefaultBackend::~DefaultBackend() {}
+HttpCache::DefaultBackend::~DefaultBackend() = default;
// static
std::unique_ptr<HttpCache::BackendFactory> HttpCache::DefaultBackend::InMemory(
@@ -127,7 +127,7 @@
// open cache entries or the backend itself.
struct HttpCache::PendingOp {
PendingOp() : disk_entry(NULL) {}
- ~PendingOp() {}
+ ~PendingOp() = default;
// Returns the estimate of dynamically allocated memory in bytes.
size_t EstimateMemoryUsage() const {
@@ -172,7 +172,7 @@
entry_(NULL),
callback_(cb),
backend_(backend) {}
- ~WorkItem() {}
+ ~WorkItem() = default;
// Calls back the transaction with the result of the operation.
void NotifyTransaction(int result, ActiveEntry* entry) {
@@ -222,7 +222,7 @@
explicit MetadataWriter(HttpCache::Transaction* trans)
: verified_(false), buf_len_(0), transaction_(trans) {}
- ~MetadataWriter() {}
+ ~MetadataWriter() = default;
// Implements the bulk of HttpCache::WriteMetadata.
void Write(const GURL& url,
diff --git a/net/http/http_cache_lookup_manager.cc b/net/http/http_cache_lookup_manager.cc
index 804c384..d3f1ef53 100644
--- a/net/http/http_cache_lookup_manager.cc
+++ b/net/http/http_cache_lookup_manager.cc
@@ -33,7 +33,7 @@
net_log,
NetLogSourceType::SERVER_PUSH_LOOKUP_TRANSACTION)) {}
-HttpCacheLookupManager::LookupTransaction::~LookupTransaction() {}
+HttpCacheLookupManager::LookupTransaction::~LookupTransaction() = default;
int HttpCacheLookupManager::LookupTransaction::StartLookup(
HttpCache* cache,
@@ -62,7 +62,7 @@
HttpCacheLookupManager::HttpCacheLookupManager(HttpCache* http_cache)
: http_cache_(http_cache), weak_factory_(this) {}
-HttpCacheLookupManager::~HttpCacheLookupManager() {}
+HttpCacheLookupManager::~HttpCacheLookupManager() = default;
void HttpCacheLookupManager::OnPush(
std::unique_ptr<ServerPushHelper> push_helper,
diff --git a/net/http/http_cache_unittest.cc b/net/http/http_cache_unittest.cc
index 883575c..4a6fbe8 100644
--- a/net/http/http_cache_unittest.cc
+++ b/net/http/http_cache_unittest.cc
@@ -341,7 +341,7 @@
FastTransactionServer() {
no_store = false;
}
- ~FastTransactionServer() {}
+ ~FastTransactionServer() = default;
void set_no_store(bool value) { no_store = value; }
@@ -639,7 +639,7 @@
class FakeWebSocketHandshakeStreamCreateHelper
: public WebSocketHandshakeStreamBase::CreateHelper {
public:
- ~FakeWebSocketHandshakeStreamCreateHelper() override {}
+ ~FakeWebSocketHandshakeStreamCreateHelper() override = default;
std::unique_ptr<WebSocketHandshakeStreamBase> CreateBasicStream(
std::unique_ptr<ClientSocketHandle> connect,
bool using_proxy) override {
diff --git a/net/http/http_cache_writers.cc b/net/http/http_cache_writers.cc
index 7c348381..0fcf1c6a 100644
--- a/net/http/http_cache_writers.cc
+++ b/net/http/http_cache_writers.cc
@@ -50,7 +50,7 @@
HttpCache::Writers::Writers(HttpCache* cache, HttpCache::ActiveEntry* entry)
: cache_(cache), entry_(entry), weak_factory_(this) {}
-HttpCache::Writers::~Writers() {}
+HttpCache::Writers::~Writers() = default;
int HttpCache::Writers::Read(scoped_refptr<IOBuffer> buf,
int buf_len,
@@ -323,7 +323,7 @@
DCHECK(!consumer_callback.is_null());
}
-HttpCache::Writers::WaitingForRead::~WaitingForRead() {}
+HttpCache::Writers::WaitingForRead::~WaitingForRead() = default;
HttpCache::Writers::WaitingForRead::WaitingForRead(const WaitingForRead&) =
default;
diff --git a/net/http/http_cache_writers_unittest.cc b/net/http/http_cache_writers_unittest.cc
index 911cd2b2..cb05ec4 100644
--- a/net/http/http_cache_writers_unittest.cc
+++ b/net/http/http_cache_writers_unittest.cc
@@ -33,7 +33,8 @@
public:
TestHttpCacheTransaction(RequestPriority priority, HttpCache* cache)
: HttpCache::Transaction(priority, cache){};
- ~TestHttpCacheTransaction() override{};
+ ~TestHttpCacheTransaction() override = default;
+ ;
Transaction::Mode mode() const override { return Transaction::READ_WRITE; }
};
diff --git a/net/http/http_content_disposition.cc b/net/http/http_content_disposition.cc
index 05f3e193..da72593 100644
--- a/net/http/http_content_disposition.cc
+++ b/net/http/http_content_disposition.cc
@@ -339,8 +339,7 @@
Parse(header, referrer_charset);
}
-HttpContentDisposition::~HttpContentDisposition() {
-}
+HttpContentDisposition::~HttpContentDisposition() = default;
std::string::const_iterator HttpContentDisposition::ConsumeDispositionType(
std::string::const_iterator begin, std::string::const_iterator end) {
diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc
index 3d8b9d51..bcced4e 100644
--- a/net/http/http_network_session.cc
+++ b/net/http/http_network_session.cc
@@ -138,7 +138,7 @@
HttpNetworkSession::Params::Params(const Params& other) = default;
-HttpNetworkSession::Params::~Params() {}
+HttpNetworkSession::Params::~Params() = default;
HttpNetworkSession::Context::Context()
: client_socket_factory(nullptr),
@@ -162,7 +162,7 @@
HttpNetworkSession::Context::Context(const Context& other) = default;
-HttpNetworkSession::Context::~Context() {}
+HttpNetworkSession::Context::~Context() = default;
// TODO(mbelshe): Move the socket factories into HttpStreamFactory.
HttpNetworkSession::HttpNetworkSession(const Params& params,
diff --git a/net/http/http_network_session_peer.cc b/net/http/http_network_session_peer.cc
index 4a42dc2..9b33d98 100644
--- a/net/http/http_network_session_peer.cc
+++ b/net/http/http_network_session_peer.cc
@@ -17,7 +17,7 @@
HttpNetworkSessionPeer::HttpNetworkSessionPeer(HttpNetworkSession* session)
: session_(session) {}
-HttpNetworkSessionPeer::~HttpNetworkSessionPeer() {}
+HttpNetworkSessionPeer::~HttpNetworkSessionPeer() = default;
void HttpNetworkSessionPeer::SetClientSocketPoolManager(
std::unique_ptr<ClientSocketPoolManager> socket_pool_manager) {
diff --git a/net/http/http_network_transaction_ssl_unittest.cc b/net/http/http_network_transaction_ssl_unittest.cc
index b61a1e2..76f5e8c8 100644
--- a/net/http/http_network_transaction_ssl_unittest.cc
+++ b/net/http/http_network_transaction_ssl_unittest.cc
@@ -46,7 +46,7 @@
void GetSSLConfig(SSLConfig* config) override { *config = ssl_config_; }
private:
- ~TokenBindingSSLConfigService() override {}
+ ~TokenBindingSSLConfigService() override = default;
SSLConfig ssl_config_;
};
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index dc821cf..615019c 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -10183,8 +10183,8 @@
TEST_F(HttpNetworkTransactionTest, CancelDuringInitRequestBody) {
class FakeUploadElementReader : public UploadElementReader {
public:
- FakeUploadElementReader() {}
- ~FakeUploadElementReader() override {}
+ FakeUploadElementReader() = default;
+ ~FakeUploadElementReader() override = default;
const CompletionCallback& callback() const { return callback_; }
@@ -11513,8 +11513,8 @@
class CapturingProxyResolver : public ProxyResolver {
public:
- CapturingProxyResolver() {}
- ~CapturingProxyResolver() override {}
+ CapturingProxyResolver() = default;
+ ~CapturingProxyResolver() override = default;
int GetProxyForURL(const GURL& url,
ProxyInfo* results,
@@ -13061,7 +13061,7 @@
public:
explicit UrlRecordingHttpAuthHandlerMock(GURL* url) : url_(url) {}
- ~UrlRecordingHttpAuthHandlerMock() override {}
+ ~UrlRecordingHttpAuthHandlerMock() override = default;
protected:
int GenerateAuthTokenImpl(const AuthCredentials* credentials,
@@ -14263,7 +14263,7 @@
public:
explicit OneTimeCachingHostResolver(const HostPortPair& host_port)
: MockHostResolverBase(/* use_caching = */ true), host_port_(host_port) {}
- ~OneTimeCachingHostResolver() override {}
+ ~OneTimeCachingHostResolver() override = default;
int ResolveFromCache(const RequestInfo& info,
AddressList* addresses,
@@ -15425,7 +15425,7 @@
public base::SupportsWeakPtr<FakeStream> {
public:
explicit FakeStream(RequestPriority priority) : priority_(priority) {}
- ~FakeStream() override {}
+ ~FakeStream() override = default;
RequestPriority priority() const { return priority_; }
@@ -15541,7 +15541,7 @@
delegate_(delegate),
websocket_stream_create_helper_(create_helper) {}
- ~FakeStreamRequest() override {}
+ ~FakeStreamRequest() override = default;
RequestPriority priority() const { return priority_; }
@@ -15595,8 +15595,8 @@
// Fake HttpStreamFactory that vends FakeStreamRequests.
class FakeStreamFactory : public HttpStreamFactory {
public:
- FakeStreamFactory() {}
- ~FakeStreamFactory() override {}
+ FakeStreamFactory() = default;
+ ~FakeStreamFactory() override = default;
// Returns a WeakPtr<> to the last HttpStreamRequest returned by
// RequestStream() (which may be NULL if it was destroyed already).
@@ -15798,7 +15798,7 @@
std::move(connection), using_proxy);
}
- ~FakeWebSocketStreamCreateHelper() override {}
+ ~FakeWebSocketStreamCreateHelper() override = default;
virtual std::unique_ptr<WebSocketStream> Upgrade() {
NOTREACHED();
diff --git a/net/http/http_proxy_client_socket_pool.cc b/net/http/http_proxy_client_socket_pool.cc
index 6dabad1..ab7bbb3 100644
--- a/net/http/http_proxy_client_socket_pool.cc
+++ b/net/http/http_proxy_client_socket_pool.cc
@@ -115,7 +115,7 @@
}
}
-HttpProxySocketParams::~HttpProxySocketParams() {}
+HttpProxySocketParams::~HttpProxySocketParams() = default;
HttpProxyConnectJob::HttpProxyConnectJob(
const std::string& group_name,
@@ -156,7 +156,7 @@
params->proxy_delegate(),
this->net_log())) {}
-HttpProxyConnectJob::~HttpProxyConnectJob() {}
+HttpProxyConnectJob::~HttpProxyConnectJob() = default;
LoadState HttpProxyConnectJob::GetLoadState() const {
return client_socket_->GetConnectLoadState();
@@ -285,8 +285,7 @@
base_.AddLowerLayeredPool(ssl_pool_);
}
-HttpProxyClientSocketPool::~HttpProxyClientSocketPool() {
-}
+HttpProxyClientSocketPool::~HttpProxyClientSocketPool() = default;
int HttpProxyClientSocketPool::RequestSocket(const std::string& group_name,
const void* socket_params,
diff --git a/net/http/http_proxy_client_socket_pool_unittest.cc b/net/http/http_proxy_client_socket_pool_unittest.cc
index 39eb4e14..2cf01c15 100644
--- a/net/http/http_proxy_client_socket_pool_unittest.cc
+++ b/net/http/http_proxy_client_socket_pool_unittest.cc
@@ -92,7 +92,7 @@
session_ = CreateNetworkSession();
}
- virtual ~HttpProxyClientSocketPoolTest() {}
+ virtual ~HttpProxyClientSocketPoolTest() = default;
// Initializes the field trial paramters for the field trial that determines
// connection timeout based on the network quality.
diff --git a/net/http/http_proxy_client_socket_wrapper_unittest.cc b/net/http/http_proxy_client_socket_wrapper_unittest.cc
index bff691c..63398086 100644
--- a/net/http/http_proxy_client_socket_wrapper_unittest.cc
+++ b/net/http/http_proxy_client_socket_wrapper_unittest.cc
@@ -43,12 +43,12 @@
class MockSSLConfigService : public SSLConfigService {
public:
- MockSSLConfigService() {}
+ MockSSLConfigService() = default;
void GetSSLConfig(SSLConfig* config) override { *config = config_; }
private:
- ~MockSSLConfigService() override {}
+ ~MockSSLConfigService() override = default;
SSLConfig config_;
};
diff --git a/net/http/http_request_headers.cc b/net/http/http_request_headers.cc
index cf9433e..49881ea 100644
--- a/net/http/http_request_headers.cc
+++ b/net/http/http_request_headers.cc
@@ -44,8 +44,7 @@
const char HttpRequestHeaders::kTokenBinding[] = "Sec-Token-Binding";
const char HttpRequestHeaders::kUserAgent[] = "User-Agent";
-HttpRequestHeaders::HeaderKeyValuePair::HeaderKeyValuePair() {
-}
+HttpRequestHeaders::HeaderKeyValuePair::HeaderKeyValuePair() = default;
HttpRequestHeaders::HeaderKeyValuePair::HeaderKeyValuePair(
const base::StringPiece& key, const base::StringPiece& value)
@@ -58,7 +57,7 @@
curr_(headers.headers_.begin()),
end_(headers.headers_.end()) {}
-HttpRequestHeaders::Iterator::~Iterator() {}
+HttpRequestHeaders::Iterator::~Iterator() = default;
bool HttpRequestHeaders::Iterator::GetNext() {
if (!started_) {
@@ -73,10 +72,10 @@
return curr_ != end_;
}
-HttpRequestHeaders::HttpRequestHeaders() {}
+HttpRequestHeaders::HttpRequestHeaders() = default;
HttpRequestHeaders::HttpRequestHeaders(const HttpRequestHeaders& other) =
default;
-HttpRequestHeaders::~HttpRequestHeaders() {}
+HttpRequestHeaders::~HttpRequestHeaders() = default;
bool HttpRequestHeaders::GetHeader(const base::StringPiece& key,
std::string* out) const {
diff --git a/net/http/http_request_info.cc b/net/http/http_request_info.cc
index d51d3d0..8b0c010c 100644
--- a/net/http/http_request_info.cc
+++ b/net/http/http_request_info.cc
@@ -15,6 +15,6 @@
HttpRequestInfo::HttpRequestInfo(const HttpRequestInfo& other) = default;
-HttpRequestInfo::~HttpRequestInfo() {}
+HttpRequestInfo::~HttpRequestInfo() = default;
} // namespace net
diff --git a/net/http/http_response_body_drainer.cc b/net/http/http_response_body_drainer.cc
index 4091c85..d6ad2a4 100644
--- a/net/http/http_response_body_drainer.cc
+++ b/net/http/http_response_body_drainer.cc
@@ -20,7 +20,7 @@
total_read_(0),
session_(NULL) {}
-HttpResponseBodyDrainer::~HttpResponseBodyDrainer() {}
+HttpResponseBodyDrainer::~HttpResponseBodyDrainer() = default;
void HttpResponseBodyDrainer::Start(HttpNetworkSession* session) {
read_buf_ = new IOBuffer(kDrainBodyBufferSize);
diff --git a/net/http/http_response_body_drainer_unittest.cc b/net/http/http_response_body_drainer_unittest.cc
index 422b5b9..9c5dfa8 100644
--- a/net/http/http_response_body_drainer_unittest.cc
+++ b/net/http/http_response_body_drainer_unittest.cc
@@ -84,7 +84,7 @@
is_complete_(false),
can_reuse_connection_(true),
weak_factory_(this) {}
- ~MockHttpStream() override {}
+ ~MockHttpStream() override = default;
// HttpStream implementation.
int InitializeStream(const HttpRequestInfo* request_info,
@@ -243,7 +243,7 @@
mock_stream_(new MockHttpStream(&result_waiter_)),
drainer_(new HttpResponseBodyDrainer(mock_stream_)) {}
- ~HttpResponseBodyDrainerTest() override {}
+ ~HttpResponseBodyDrainerTest() override = default;
HttpNetworkSession* CreateNetworkSession() {
HttpNetworkSession::Context context;
diff --git a/net/http/http_response_headers.cc b/net/http/http_response_headers.cc
index 85d321d2..59a8dd9 100644
--- a/net/http/http_response_headers.cc
+++ b/net/http/http_response_headers.cc
@@ -582,8 +582,7 @@
return FindHeader(0, name) != std::string::npos;
}
-HttpResponseHeaders::~HttpResponseHeaders() {
-}
+HttpResponseHeaders::~HttpResponseHeaders() = default;
// Note: this implementation implicitly assumes that line_end points at a valid
// sentinel character (such as '\0').
diff --git a/net/http/http_response_info.cc b/net/http/http_response_info.cc
index 21dd793a..35993f3 100644
--- a/net/http/http_response_info.cc
+++ b/net/http/http_response_info.cc
@@ -120,56 +120,12 @@
unused_since_prefetch(false),
connection_info(CONNECTION_INFO_UNKNOWN) {}
-HttpResponseInfo::HttpResponseInfo(const HttpResponseInfo& rhs)
- : was_cached(rhs.was_cached),
- cache_entry_status(rhs.cache_entry_status),
- server_data_unavailable(rhs.server_data_unavailable),
- network_accessed(rhs.network_accessed),
- was_fetched_via_spdy(rhs.was_fetched_via_spdy),
- was_alpn_negotiated(rhs.was_alpn_negotiated),
- was_fetched_via_proxy(rhs.was_fetched_via_proxy),
- proxy_server(rhs.proxy_server),
- did_use_http_auth(rhs.did_use_http_auth),
- unused_since_prefetch(rhs.unused_since_prefetch),
- socket_address(rhs.socket_address),
- alpn_negotiated_protocol(rhs.alpn_negotiated_protocol),
- connection_info(rhs.connection_info),
- request_time(rhs.request_time),
- response_time(rhs.response_time),
- auth_challenge(rhs.auth_challenge),
- cert_request_info(rhs.cert_request_info),
- ssl_info(rhs.ssl_info),
- headers(rhs.headers),
- vary_data(rhs.vary_data),
- metadata(rhs.metadata) {}
+HttpResponseInfo::HttpResponseInfo(const HttpResponseInfo& rhs) = default;
-HttpResponseInfo::~HttpResponseInfo() {
-}
+HttpResponseInfo::~HttpResponseInfo() = default;
-HttpResponseInfo& HttpResponseInfo::operator=(const HttpResponseInfo& rhs) {
- was_cached = rhs.was_cached;
- cache_entry_status = rhs.cache_entry_status;
- server_data_unavailable = rhs.server_data_unavailable;
- network_accessed = rhs.network_accessed;
- was_fetched_via_spdy = rhs.was_fetched_via_spdy;
- proxy_server = rhs.proxy_server;
- was_alpn_negotiated = rhs.was_alpn_negotiated;
- was_fetched_via_proxy = rhs.was_fetched_via_proxy;
- did_use_http_auth = rhs.did_use_http_auth;
- unused_since_prefetch = rhs.unused_since_prefetch;
- socket_address = rhs.socket_address;
- alpn_negotiated_protocol = rhs.alpn_negotiated_protocol;
- connection_info = rhs.connection_info;
- request_time = rhs.request_time;
- response_time = rhs.response_time;
- auth_challenge = rhs.auth_challenge;
- cert_request_info = rhs.cert_request_info;
- ssl_info = rhs.ssl_info;
- headers = rhs.headers;
- vary_data = rhs.vary_data;
- metadata = rhs.metadata;
- return *this;
-}
+HttpResponseInfo& HttpResponseInfo::operator=(const HttpResponseInfo& rhs) =
+ default;
bool HttpResponseInfo::InitFromPickle(const base::Pickle& pickle,
bool* response_truncated) {
diff --git a/net/http/http_server_properties.cc b/net/http/http_server_properties.cc
index b28084586..7abba85 100644
--- a/net/http/http_server_properties.cc
+++ b/net/http/http_server_properties.cc
@@ -101,7 +101,7 @@
AlternativeServiceInfo::AlternativeServiceInfo() : alternative_service_() {}
-AlternativeServiceInfo::~AlternativeServiceInfo() {}
+AlternativeServiceInfo::~AlternativeServiceInfo() = default;
AlternativeServiceInfo::AlternativeServiceInfo(
const AlternativeService& alternative_service,
diff --git a/net/http/http_server_properties_manager.cc b/net/http/http_server_properties_manager.cc
index c7bb25b..3894871 100644
--- a/net/http/http_server_properties_manager.cc
+++ b/net/http/http_server_properties_manager.cc
@@ -91,7 +91,7 @@
////////////////////////////////////////////////////////////////////////////////
// HttpServerPropertiesManager
-HttpServerPropertiesManager::PrefDelegate::~PrefDelegate() {}
+HttpServerPropertiesManager::PrefDelegate::~PrefDelegate() = default;
HttpServerPropertiesManager::HttpServerPropertiesManager(
std::unique_ptr<PrefDelegate> pref_delegate,
diff --git a/net/http/http_server_properties_manager_unittest.cc b/net/http/http_server_properties_manager_unittest.cc
index 0c5484da..e5eea96 100644
--- a/net/http/http_server_properties_manager_unittest.cc
+++ b/net/http/http_server_properties_manager_unittest.cc
@@ -39,8 +39,8 @@
class MockPrefDelegate : public net::HttpServerPropertiesManager::PrefDelegate {
public:
- MockPrefDelegate() {}
- ~MockPrefDelegate() override {}
+ MockPrefDelegate() = default;
+ ~MockPrefDelegate() override = default;
// HttpServerPropertiesManager::PrefDelegate implementation.
const base::DictionaryValue* GetServerProperties() const override {
diff --git a/net/http/http_stream_factory.cc b/net/http/http_stream_factory.cc
index 6a8cfa6..077ec56c 100644
--- a/net/http/http_stream_factory.cc
+++ b/net/http/http_stream_factory.cc
@@ -22,7 +22,7 @@
namespace net {
-HttpStreamFactory::~HttpStreamFactory() {}
+HttpStreamFactory::~HttpStreamFactory() = default;
void HttpStreamFactory::ProcessAlternativeServices(
HttpNetworkSession* session,
@@ -84,7 +84,7 @@
RewriteHost(http_server), alternative_service_info_vector);
}
-HttpStreamFactory::HttpStreamFactory() {}
+HttpStreamFactory::HttpStreamFactory() = default;
url::SchemeHostPort HttpStreamFactory::RewriteHost(
const url::SchemeHostPort& server) {
diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc
index e344d9b..8b1a2a4 100644
--- a/net/http/http_stream_factory_impl_job.cc
+++ b/net/http/http_stream_factory_impl_job.cc
@@ -1456,9 +1456,9 @@
delegate_->AddConnectionAttemptsToRequest(this, socket_attempts);
}
-HttpStreamFactoryImpl::JobFactory::JobFactory() {}
+HttpStreamFactoryImpl::JobFactory::JobFactory() = default;
-HttpStreamFactoryImpl::JobFactory::~JobFactory() {}
+HttpStreamFactoryImpl::JobFactory::~JobFactory() = default;
std::unique_ptr<HttpStreamFactoryImpl::Job>
HttpStreamFactoryImpl::JobFactory::CreateMainJob(
diff --git a/net/http/http_stream_factory_impl_job_controller_unittest.cc b/net/http/http_stream_factory_impl_job_controller_unittest.cc
index 43c03f7f..ac8124d 100644
--- a/net/http/http_stream_factory_impl_job_controller_unittest.cc
+++ b/net/http/http_stream_factory_impl_job_controller_unittest.cc
@@ -91,7 +91,7 @@
class FailingHostResolver : public MockHostResolverBase {
public:
FailingHostResolver() : MockHostResolverBase(false /*use_caching*/) {}
- ~FailingHostResolver() override {}
+ ~FailingHostResolver() override = default;
int Resolve(const RequestInfo& info,
RequestPriority priority,
@@ -108,7 +108,7 @@
class HangingResolver : public MockHostResolverBase {
public:
HangingResolver() : MockHostResolverBase(false /*use_caching*/) {}
- ~HangingResolver() override {}
+ ~HangingResolver() override = default;
int Resolve(const RequestInfo& info,
RequestPriority priority,
@@ -123,8 +123,8 @@
// A mock HttpServerProperties that always returns false for IsInitialized().
class MockHttpServerProperties : public HttpServerPropertiesImpl {
public:
- MockHttpServerProperties() {}
- ~MockHttpServerProperties() override {}
+ MockHttpServerProperties() = default;
+ ~MockHttpServerProperties() override = default;
bool IsInitialized() const override { return false; }
};
diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc
index 5c3a0a0..b6a1a48 100644
--- a/net/http/http_stream_factory_impl_unittest.cc
+++ b/net/http/http_stream_factory_impl_unittest.cc
@@ -91,7 +91,7 @@
explicit MockWebSocketHandshakeStream(StreamType type) : type_(type) {}
- ~MockWebSocketHandshakeStream() override {}
+ ~MockWebSocketHandshakeStream() override = default;
StreamType type() const {
return type_;
@@ -318,7 +318,7 @@
class WebSocketStreamCreateHelper
: public WebSocketHandshakeStreamBase::CreateHelper {
public:
- ~WebSocketStreamCreateHelper() override {}
+ ~WebSocketStreamCreateHelper() override = default;
std::unique_ptr<WebSocketHandshakeStreamBase> CreateBasicStream(
std::unique_ptr<ClientSocketHandle> connection,
@@ -835,7 +835,7 @@
public:
MockQuicData() : packet_number_(0) {}
- ~MockQuicData() {}
+ ~MockQuicData() = default;
void AddRead(std::unique_ptr<QuicEncryptedPacket> packet) {
reads_.push_back(
diff --git a/net/http/http_stream_factory_test_util.cc b/net/http/http_stream_factory_test_util.cc
index fff12f7..264030e 100644
--- a/net/http/http_stream_factory_test_util.cc
+++ b/net/http/http_stream_factory_test_util.cc
@@ -11,9 +11,9 @@
using ::testing::_;
namespace net {
-MockHttpStreamRequestDelegate::MockHttpStreamRequestDelegate() {}
+MockHttpStreamRequestDelegate::MockHttpStreamRequestDelegate() = default;
-MockHttpStreamRequestDelegate::~MockHttpStreamRequestDelegate() {}
+MockHttpStreamRequestDelegate::~MockHttpStreamRequestDelegate() = default;
MockHttpStreamFactoryImplJob::MockHttpStreamFactoryImplJob(
HttpStreamFactoryImpl::Job::Delegate* delegate,
@@ -49,14 +49,14 @@
DCHECK(!is_waiting());
}
-MockHttpStreamFactoryImplJob::~MockHttpStreamFactoryImplJob() {}
+MockHttpStreamFactoryImplJob::~MockHttpStreamFactoryImplJob() = default;
TestJobFactory::TestJobFactory()
: main_job_(nullptr),
alternative_job_(nullptr),
override_main_job_url_(false) {}
-TestJobFactory::~TestJobFactory() {}
+TestJobFactory::~TestJobFactory() = default;
std::unique_ptr<HttpStreamFactoryImpl::Job> TestJobFactory::CreateMainJob(
HttpStreamFactoryImpl::Job::Delegate* delegate,
diff --git a/net/http/http_stream_parser.cc b/net/http/http_stream_parser.cc
index 1d5dec49..ced3da36 100644
--- a/net/http/http_stream_parser.cc
+++ b/net/http/http_stream_parser.cc
@@ -211,8 +211,7 @@
weak_ptr_factory_.GetWeakPtr());
}
-HttpStreamParser::~HttpStreamParser() {
-}
+HttpStreamParser::~HttpStreamParser() = default;
int HttpStreamParser::SendRequest(const std::string& request_line,
const HttpRequestHeaders& headers,
diff --git a/net/http/http_transaction_test_util.cc b/net/http/http_transaction_test_util.cc
index 8a481e0..9ab28f7 100644
--- a/net/http/http_transaction_test_util.cc
+++ b/net/http/http_transaction_test_util.cc
@@ -189,8 +189,7 @@
++quit_counter_;
}
-TestTransactionConsumer::~TestTransactionConsumer() {
-}
+TestTransactionConsumer::~TestTransactionConsumer() = default;
void TestTransactionConsumer::Start(const HttpRequestInfo* request,
const NetLogWithSource& net_log) {
@@ -558,7 +557,7 @@
clock_(nullptr) {
}
-MockNetworkLayer::~MockNetworkLayer() {}
+MockNetworkLayer::~MockNetworkLayer() = default;
void MockNetworkLayer::TransactionDoneReading() {
CHECK(!done_reading_called_);
diff --git a/net/http/http_util.cc b/net/http/http_util.cc
index 0bf40c3..9361272 100644
--- a/net/http/http_util.cc
+++ b/net/http/http_util.cc
@@ -870,8 +870,7 @@
: lines_(headers_begin, headers_end, line_delimiter) {
}
-HttpUtil::HeadersIterator::~HeadersIterator() {
-}
+HttpUtil::HeadersIterator::~HeadersIterator() = default;
bool HttpUtil::HeadersIterator::GetNext() {
while (lines_.GetNext()) {
@@ -929,8 +928,7 @@
HttpUtil::ValuesIterator::ValuesIterator(const ValuesIterator& other) = default;
-HttpUtil::ValuesIterator::~ValuesIterator() {
-}
+HttpUtil::ValuesIterator::~ValuesIterator() = default;
bool HttpUtil::ValuesIterator::GetNext() {
while (values_.GetNext()) {
@@ -977,7 +975,7 @@
HttpUtil::NameValuePairsIterator::NameValuePairsIterator(
const NameValuePairsIterator& other) = default;
-HttpUtil::NameValuePairsIterator::~NameValuePairsIterator() {}
+HttpUtil::NameValuePairsIterator::~NameValuePairsIterator() = default;
// We expect properties to be formatted as one of:
// name="value"
diff --git a/net/http/mock_allow_http_auth_preferences.cc b/net/http/mock_allow_http_auth_preferences.cc
index 12a4867..12ccfe2 100644
--- a/net/http/mock_allow_http_auth_preferences.cc
+++ b/net/http/mock_allow_http_auth_preferences.cc
@@ -7,9 +7,9 @@
namespace net {
-MockAllowHttpAuthPreferences::MockAllowHttpAuthPreferences() {}
+MockAllowHttpAuthPreferences::MockAllowHttpAuthPreferences() = default;
-MockAllowHttpAuthPreferences::~MockAllowHttpAuthPreferences() {}
+MockAllowHttpAuthPreferences::~MockAllowHttpAuthPreferences() = default;
bool MockAllowHttpAuthPreferences::CanUseDefaultCredentials(
const GURL& auth_origin) const {
diff --git a/net/http/mock_gssapi_library_posix.cc b/net/http/mock_gssapi_library_posix.cc
index 2e4c3c11..b129f2e 100644
--- a/net/http/mock_gssapi_library_posix.cc
+++ b/net/http/mock_gssapi_library_posix.cc
@@ -229,13 +229,11 @@
MockGSSAPILibrary::SecurityContextQuery::SecurityContextQuery(
const SecurityContextQuery& other) = default;
-MockGSSAPILibrary::SecurityContextQuery::~SecurityContextQuery() {}
+MockGSSAPILibrary::SecurityContextQuery::~SecurityContextQuery() = default;
-MockGSSAPILibrary::MockGSSAPILibrary() {
-}
+MockGSSAPILibrary::MockGSSAPILibrary() = default;
-MockGSSAPILibrary::~MockGSSAPILibrary() {
-}
+MockGSSAPILibrary::~MockGSSAPILibrary() = default;
void MockGSSAPILibrary::ExpectSecurityContext(
const std::string& expected_package,
diff --git a/net/http/mock_http_cache.cc b/net/http/mock_http_cache.cc
index f1cb3a27..8c940f3 100644
--- a/net/http/mock_http_cache.cc
+++ b/net/http/mock_http_cache.cc
@@ -328,8 +328,7 @@
StoreAndDeliverCallbacks(false, NULL, CompletionCallback(), 0);
}
-MockDiskEntry::~MockDiskEntry() {
-}
+MockDiskEntry::~MockDiskEntry() = default;
// Unlike the callbacks for MockHttpTransaction, we want this one to run even
// if the consumer called Close on the MockDiskEntry. We achieve that by
@@ -779,8 +778,7 @@
fail_(false) {
}
-MockBlockingBackendFactory::~MockBlockingBackendFactory() {
-}
+MockBlockingBackendFactory::~MockBlockingBackendFactory() = default;
int MockBlockingBackendFactory::CreateBackend(
NetLog* net_log,
diff --git a/net/http/partial_data.cc b/net/http/partial_data.cc
index dceea25b..7243fcf 100644
--- a/net/http/partial_data.cc
+++ b/net/http/partial_data.cc
@@ -43,8 +43,7 @@
weak_factory_(this) {
}
-PartialData::~PartialData() {
-}
+PartialData::~PartialData() = default;
bool PartialData::Init(const HttpRequestHeaders& headers) {
std::string range_header;
diff --git a/net/http/proxy_connect_redirect_http_stream.cc b/net/http/proxy_connect_redirect_http_stream.cc
index 26e5b6a..2fc8eb8 100644
--- a/net/http/proxy_connect_redirect_http_stream.cc
+++ b/net/http/proxy_connect_redirect_http_stream.cc
@@ -18,7 +18,7 @@
load_timing_info_ = *load_timing_info;
}
-ProxyConnectRedirectHttpStream::~ProxyConnectRedirectHttpStream() {}
+ProxyConnectRedirectHttpStream::~ProxyConnectRedirectHttpStream() = default;
int ProxyConnectRedirectHttpStream::InitializeStream(
const HttpRequestInfo* request_info,
diff --git a/net/http/transport_security_persister_unittest.cc b/net/http/transport_security_persister_unittest.cc
index b742353..3ad2988 100644
--- a/net/http/transport_security_persister_unittest.cc
+++ b/net/http/transport_security_persister_unittest.cc
@@ -27,8 +27,7 @@
class TransportSecurityPersisterTest : public testing::Test {
public:
- TransportSecurityPersisterTest() {
- }
+ TransportSecurityPersisterTest() = default;
~TransportSecurityPersisterTest() override {
EXPECT_TRUE(base::MessageLoopForIO::IsCurrent());
diff --git a/net/http/transport_security_state.cc b/net/http/transport_security_state.cc
index 425b387..a433afd 100644
--- a/net/http/transport_security_state.cc
+++ b/net/http/transport_security_state.cc
@@ -1775,8 +1775,7 @@
: upgrade_mode(MODE_DEFAULT), include_subdomains(false) {
}
-TransportSecurityState::STSState::~STSState() {
-}
+TransportSecurityState::STSState::~STSState() = default;
bool TransportSecurityState::STSState::ShouldUpgradeToSSL() const {
return upgrade_mode == MODE_FORCE_HTTPS;
@@ -1788,20 +1787,18 @@
end_(state.enabled_sts_hosts_.end()) {
}
-TransportSecurityState::STSStateIterator::~STSStateIterator() {
-}
+TransportSecurityState::STSStateIterator::~STSStateIterator() = default;
TransportSecurityState::PKPState::PKPState() : include_subdomains(false) {
}
TransportSecurityState::PKPState::PKPState(const PKPState& other) = default;
-TransportSecurityState::PKPState::~PKPState() {
-}
+TransportSecurityState::PKPState::~PKPState() = default;
TransportSecurityState::ExpectCTState::ExpectCTState() : enforce(false) {}
-TransportSecurityState::ExpectCTState::~ExpectCTState() {}
+TransportSecurityState::ExpectCTState::~ExpectCTState() = default;
TransportSecurityState::ExpectCTStateIterator::ExpectCTStateIterator(
const TransportSecurityState& state)
@@ -1810,12 +1807,13 @@
state.AssertCalledOnValidThread();
}
-TransportSecurityState::ExpectCTStateIterator::~ExpectCTStateIterator() {}
+TransportSecurityState::ExpectCTStateIterator::~ExpectCTStateIterator() =
+ default;
TransportSecurityState::ExpectStapleState::ExpectStapleState()
: include_subdomains(false) {}
-TransportSecurityState::ExpectStapleState::~ExpectStapleState() {}
+TransportSecurityState::ExpectStapleState::~ExpectStapleState() = default;
bool TransportSecurityState::PKPState::CheckPublicKeyPins(
const HashValueVector& hashes,
@@ -1862,7 +1860,6 @@
end_(state.enabled_pkp_hosts_.end()) {
}
-TransportSecurityState::PKPStateIterator::~PKPStateIterator() {
-}
+TransportSecurityState::PKPStateIterator::~PKPStateIterator() = default;
} // namespace net
diff --git a/net/http/transport_security_state_unittest.cc b/net/http/transport_security_state_unittest.cc
index 373e176..d7a0df2 100644
--- a/net/http/transport_security_state_unittest.cc
+++ b/net/http/transport_security_state_unittest.cc
@@ -113,8 +113,8 @@
class MockCertificateReportSender
: public TransportSecurityState::ReportSenderInterface {
public:
- MockCertificateReportSender() {}
- ~MockCertificateReportSender() override {}
+ MockCertificateReportSender() = default;
+ ~MockCertificateReportSender() override = default;
void Send(const GURL& report_uri,
base::StringPiece content_type,
@@ -148,7 +148,7 @@
: public TransportSecurityState::ReportSenderInterface {
public:
MockFailingCertificateReportSender() : net_error_(ERR_CONNECTION_FAILED) {}
- ~MockFailingCertificateReportSender() override {}
+ ~MockFailingCertificateReportSender() override = default;
int net_error() { return net_error_; }
@@ -172,7 +172,7 @@
class MockExpectCTReporter : public TransportSecurityState::ExpectCTReporter {
public:
MockExpectCTReporter() : num_failures_(0) {}
- ~MockExpectCTReporter() override {}
+ ~MockExpectCTReporter() override = default;
void OnExpectCTFailed(const HostPortPair& host_port_pair,
const GURL& report_uri,
diff --git a/net/http/url_security_manager.cc b/net/http/url_security_manager.cc
index 0d992919..9c94243 100644
--- a/net/http/url_security_manager.cc
+++ b/net/http/url_security_manager.cc
@@ -10,9 +10,9 @@
namespace net {
-URLSecurityManagerWhitelist::URLSecurityManagerWhitelist() {}
+URLSecurityManagerWhitelist::URLSecurityManagerWhitelist() = default;
-URLSecurityManagerWhitelist::~URLSecurityManagerWhitelist() {}
+URLSecurityManagerWhitelist::~URLSecurityManagerWhitelist() = default;
bool URLSecurityManagerWhitelist::CanUseDefaultCredentials(
const GURL& auth_origin) const {
diff --git a/net/network_error_logging/network_error_logging_service.cc b/net/network_error_logging/network_error_logging_service.cc
index bb2b152..b1773129 100644
--- a/net/network_error_logging/network_error_logging_service.cc
+++ b/net/network_error_logging/network_error_logging_service.cc
@@ -134,7 +134,7 @@
return base::WrapUnique(new NetworkErrorLoggingService());
}
-NetworkErrorLoggingService::~NetworkErrorLoggingService() {}
+NetworkErrorLoggingService::~NetworkErrorLoggingService() = default;
void NetworkErrorLoggingService::SetReportingService(
ReportingService* reporting_service) {
diff --git a/net/network_error_logging/network_error_logging_service_unittest.cc b/net/network_error_logging/network_error_logging_service_unittest.cc
index a41d2b1..e7192e0f 100644
--- a/net/network_error_logging/network_error_logging_service_unittest.cc
+++ b/net/network_error_logging/network_error_logging_service_unittest.cc
@@ -29,7 +29,7 @@
class TestReportingService : public ReportingService {
public:
struct Report {
- Report() {}
+ Report() = default;
Report(Report&& other)
: url(other.url),
@@ -43,7 +43,7 @@
std::unique_ptr<const base::Value> body)
: url(url), group(group), type(type), body(std::move(body)) {}
- ~Report() {}
+ ~Report() = default;
GURL url;
std::string group;
@@ -54,13 +54,13 @@
DISALLOW_COPY(Report);
};
- TestReportingService() {}
+ TestReportingService() = default;
const std::vector<Report>& reports() const { return reports_; }
// ReportingService implementation:
- ~TestReportingService() override {}
+ ~TestReportingService() override = default;
void QueueReport(const GURL& url,
const std::string& group,
diff --git a/net/server/http_connection.cc b/net/server/http_connection.cc
index 092b4e9f..99324350 100644
--- a/net/server/http_connection.cc
+++ b/net/server/http_connection.cc
@@ -156,8 +156,7 @@
read_buf_(new ReadIOBuffer()),
write_buf_(new QueuedWriteIOBuffer()) {}
-HttpConnection::~HttpConnection() {
-}
+HttpConnection::~HttpConnection() = default;
void HttpConnection::SetWebSocket(std::unique_ptr<WebSocket> web_socket) {
DCHECK(!web_socket_);
diff --git a/net/server/http_server.cc b/net/server/http_server.cc
index a647e2ce..142c2e36 100644
--- a/net/server/http_server.cc
+++ b/net/server/http_server.cc
@@ -41,8 +41,7 @@
base::Bind(&HttpServer::DoAcceptLoop, weak_ptr_factory_.GetWeakPtr()));
}
-HttpServer::~HttpServer() {
-}
+HttpServer::~HttpServer() = default;
void HttpServer::AcceptWebSocket(
int connection_id,
diff --git a/net/server/http_server_request_info.cc b/net/server/http_server_request_info.cc
index 765ddc0..58021cf 100644
--- a/net/server/http_server_request_info.cc
+++ b/net/server/http_server_request_info.cc
@@ -9,12 +9,12 @@
namespace net {
-HttpServerRequestInfo::HttpServerRequestInfo() {}
+HttpServerRequestInfo::HttpServerRequestInfo() = default;
HttpServerRequestInfo::HttpServerRequestInfo(
const HttpServerRequestInfo& other) = default;
-HttpServerRequestInfo::~HttpServerRequestInfo() {}
+HttpServerRequestInfo::~HttpServerRequestInfo() = default;
std::string HttpServerRequestInfo::GetHeaderValue(
const std::string& header_name) const {
diff --git a/net/server/http_server_response_info.cc b/net/server/http_server_response_info.cc
index 7c195812..7a81025 100644
--- a/net/server/http_server_response_info.cc
+++ b/net/server/http_server_response_info.cc
@@ -18,7 +18,7 @@
HttpServerResponseInfo::HttpServerResponseInfo(
const HttpServerResponseInfo& other) = default;
-HttpServerResponseInfo::~HttpServerResponseInfo() {}
+HttpServerResponseInfo::~HttpServerResponseInfo() = default;
// static
HttpServerResponseInfo HttpServerResponseInfo::CreateFor404() {
diff --git a/net/server/http_server_unittest.cc b/net/server/http_server_unittest.cc
index af4ab98..cd60a7f 100644
--- a/net/server/http_server_unittest.cc
+++ b/net/server/http_server_unittest.cc
@@ -61,7 +61,7 @@
class TestHttpClient {
public:
- TestHttpClient() {}
+ TestHttpClient() = default;
int ConnectAndWait(const IPEndPoint& address) {
AddressList addresses(address);
@@ -453,7 +453,7 @@
public:
TestURLFetcherDelegate(const base::Closure& quit_loop_func)
: quit_loop_func_(quit_loop_func) {}
- ~TestURLFetcherDelegate() override {}
+ ~TestURLFetcherDelegate() override = default;
void OnURLFetchComplete(const URLFetcher* source) override {
EXPECT_EQ(HTTP_INTERNAL_SERVER_ERROR, source->GetResponseCode());
@@ -624,7 +624,7 @@
}
private:
- ~MockStreamSocket() override {}
+ ~MockStreamSocket() override = default;
bool connected_;
scoped_refptr<IOBuffer> read_buf_;
diff --git a/net/server/web_socket.cc b/net/server/web_socket.cc
index bd3d9e49..59879e6 100644
--- a/net/server/web_socket.cc
+++ b/net/server/web_socket.cc
@@ -54,7 +54,7 @@
WebSocket::WebSocket(HttpServer* server, HttpConnection* connection)
: server_(server), connection_(connection), closed_(false) {}
-WebSocket::~WebSocket() {}
+WebSocket::~WebSocket() = default;
void WebSocket::Accept(const HttpServerRequestInfo& request) {
std::string version = request.GetHeaderValue("sec-websocket-version");
diff --git a/net/server/web_socket_encoder.cc b/net/server/web_socket_encoder.cc
index 0240be3..bec3c83 100644
--- a/net/server/web_socket_encoder.cc
+++ b/net/server/web_socket_encoder.cc
@@ -285,7 +285,7 @@
deflater_(std::move(deflater)),
inflater_(std::move(inflater)) {}
-WebSocketEncoder::~WebSocketEncoder() {}
+WebSocketEncoder::~WebSocketEncoder() = default;
WebSocket::ParseResult WebSocketEncoder::DecodeFrame(
const base::StringPiece& frame,
diff --git a/net/server/web_socket_encoder_unittest.cc b/net/server/web_socket_encoder_unittest.cc
index 711a852..4a180ab 100644
--- a/net/server/web_socket_encoder_unittest.cc
+++ b/net/server/web_socket_encoder_unittest.cc
@@ -77,7 +77,7 @@
class WebSocketEncoderTest : public testing::Test {
public:
- WebSocketEncoderTest() {}
+ WebSocketEncoderTest() = default;
void SetUp() override {
std::string response_extensions;
diff --git a/net/socket/client_socket_pool.cc b/net/socket/client_socket_pool.cc
index 5d12324..4c9f13d 100644
--- a/net/socket/client_socket_pool.cc
+++ b/net/socket/client_socket_pool.cc
@@ -43,8 +43,8 @@
g_used_idle_socket_timeout_s = timeout.InSeconds();
}
-ClientSocketPool::ClientSocketPool() {}
+ClientSocketPool::ClientSocketPool() = default;
-ClientSocketPool::~ClientSocketPool() {}
+ClientSocketPool::~ClientSocketPool() = default;
} // namespace net
diff --git a/net/socket/client_socket_pool_base.cc b/net/socket/client_socket_pool_base.cc
index 73700ba0..d80dc8e 100644
--- a/net/socket/client_socket_pool_base.cc
+++ b/net/socket/client_socket_pool_base.cc
@@ -225,7 +225,7 @@
ClientSocketPoolBaseHelper::CallbackResultPair::CallbackResultPair(
const CallbackResultPair& other) = default;
-ClientSocketPoolBaseHelper::CallbackResultPair::~CallbackResultPair() {}
+ClientSocketPoolBaseHelper::CallbackResultPair::~CallbackResultPair() = default;
bool ClientSocketPoolBaseHelper::IsStalled() const {
// If a lower layer pool is stalled, consider |this| stalled as well.
diff --git a/net/socket/client_socket_pool_base_unittest.cc b/net/socket/client_socket_pool_base_unittest.cc
index 4911242..41dbccf 100644
--- a/net/socket/client_socket_pool_base_unittest.cc
+++ b/net/socket/client_socket_pool_base_unittest.cc
@@ -114,11 +114,11 @@
class TestSocketParams : public base::RefCounted<TestSocketParams> {
public:
- explicit TestSocketParams() {}
+ explicit TestSocketParams() = default;
private:
friend class base::RefCounted<TestSocketParams>;
- ~TestSocketParams() {}
+ ~TestSocketParams() = default;
};
typedef ClientSocketPoolBase<TestSocketParams> TestClientSocketPoolBase;
@@ -451,7 +451,7 @@
net_log_(net_log) {
}
- ~TestConnectJobFactory() override {}
+ ~TestConnectJobFactory() override = default;
void set_job_type(TestConnectJob::JobType job_type) { job_type_ = job_type; }
@@ -512,7 +512,7 @@
used_idle_socket_timeout,
connect_job_factory) {}
- ~TestClientSocketPool() override {}
+ ~TestClientSocketPool() override = default;
int RequestSocket(const std::string& group_name,
const void* params,
@@ -656,7 +656,7 @@
public:
TestConnectJobDelegate()
: have_result_(false), waiting_for_result_(false), result_(OK) {}
- ~TestConnectJobDelegate() override {}
+ ~TestConnectJobDelegate() override = default;
void OnConnectJobComplete(int result, ConnectJob* job) override {
result_ = result;
@@ -2560,7 +2560,7 @@
base::Unretained(this))) {
}
- ~TestReleasingSocketRequest() override {}
+ ~TestReleasingSocketRequest() override = default;
ClientSocketHandle* handle() { return &handle_; }
@@ -2681,7 +2681,7 @@
base::Unretained(this))) {
}
- ~ConnectWithinCallback() override {}
+ ~ConnectWithinCallback() override = default;
int WaitForNestedResult() {
return nested_callback_.WaitForResult();
diff --git a/net/socket/client_socket_pool_manager.cc b/net/socket/client_socket_pool_manager.cc
index 81a7fab..ffec16f 100644
--- a/net/socket/client_socket_pool_manager.cc
+++ b/net/socket/client_socket_pool_manager.cc
@@ -275,8 +275,8 @@
} // namespace
-ClientSocketPoolManager::ClientSocketPoolManager() {}
-ClientSocketPoolManager::~ClientSocketPoolManager() {}
+ClientSocketPoolManager::ClientSocketPoolManager() = default;
+ClientSocketPoolManager::~ClientSocketPoolManager() = default;
// static
int ClientSocketPoolManager::max_sockets_per_pool(
diff --git a/net/socket/fuzzed_datagram_client_socket.cc b/net/socket/fuzzed_datagram_client_socket.cc
index 328a1c8..85db485 100644
--- a/net/socket/fuzzed_datagram_client_socket.cc
+++ b/net/socket/fuzzed_datagram_client_socket.cc
@@ -30,7 +30,7 @@
base::FuzzedDataProvider* data_provider)
: data_provider_(data_provider), weak_factory_(this) {}
-FuzzedDatagramClientSocket::~FuzzedDatagramClientSocket() {}
+FuzzedDatagramClientSocket::~FuzzedDatagramClientSocket() = default;
int FuzzedDatagramClientSocket::Connect(const IPEndPoint& address) {
CHECK(!connected_);
diff --git a/net/socket/fuzzed_server_socket.cc b/net/socket/fuzzed_server_socket.cc
index 5de7fb6..d2b84f5 100644
--- a/net/socket/fuzzed_server_socket.cc
+++ b/net/socket/fuzzed_server_socket.cc
@@ -19,7 +19,7 @@
listen_called_(false),
weak_factory_(this) {}
-FuzzedServerSocket::~FuzzedServerSocket() {}
+FuzzedServerSocket::~FuzzedServerSocket() = default;
int FuzzedServerSocket::Listen(const IPEndPoint& address, int backlog) {
DCHECK(!listen_called_);
diff --git a/net/socket/fuzzed_socket.cc b/net/socket/fuzzed_socket.cc
index 6c1a75c..08be4bf 100644
--- a/net/socket/fuzzed_socket.cc
+++ b/net/socket/fuzzed_socket.cc
@@ -40,7 +40,7 @@
remote_address_(IPEndPoint(IPAddress::IPv4Localhost(), 80)),
weak_factory_(this) {}
-FuzzedSocket::~FuzzedSocket() {}
+FuzzedSocket::~FuzzedSocket() = default;
int FuzzedSocket::Read(IOBuffer* buf,
int buf_len,
diff --git a/net/socket/fuzzed_socket_factory.cc b/net/socket/fuzzed_socket_factory.cc
index 8e99cb6..55ffd99 100644
--- a/net/socket/fuzzed_socket_factory.cc
+++ b/net/socket/fuzzed_socket_factory.cc
@@ -26,8 +26,8 @@
// SSLClientSocket implementation that always fails to connect.
class FailingSSLClientSocket : public SSLClientSocket {
public:
- FailingSSLClientSocket() {}
- ~FailingSSLClientSocket() override {}
+ FailingSSLClientSocket() = default;
+ ~FailingSSLClientSocket() override = default;
// Socket implementation:
int Read(IOBuffer* buf,
@@ -130,7 +130,7 @@
base::FuzzedDataProvider* data_provider)
: data_provider_(data_provider), fuzz_connect_result_(true) {}
-FuzzedSocketFactory::~FuzzedSocketFactory() {}
+FuzzedSocketFactory::~FuzzedSocketFactory() = default;
std::unique_ptr<DatagramClientSocket>
FuzzedSocketFactory::CreateDatagramClientSocket(
diff --git a/net/socket/mock_client_socket_pool_manager.cc b/net/socket/mock_client_socket_pool_manager.cc
index 3c80ac6..a638653 100644
--- a/net/socket/mock_client_socket_pool_manager.cc
+++ b/net/socket/mock_client_socket_pool_manager.cc
@@ -12,8 +12,8 @@
namespace net {
-MockClientSocketPoolManager::MockClientSocketPoolManager() {}
-MockClientSocketPoolManager::~MockClientSocketPoolManager() {}
+MockClientSocketPoolManager::MockClientSocketPoolManager() = default;
+MockClientSocketPoolManager::~MockClientSocketPoolManager() = default;
void MockClientSocketPoolManager::SetTransportSocketPool(
TransportClientSocketPool* pool) {
diff --git a/net/socket/server_socket.cc b/net/socket/server_socket.cc
index f2c2383a..ebf5a22d 100644
--- a/net/socket/server_socket.cc
+++ b/net/socket/server_socket.cc
@@ -10,11 +10,9 @@
namespace net {
-ServerSocket::ServerSocket() {
-}
+ServerSocket::ServerSocket() = default;
-ServerSocket::~ServerSocket() {
-}
+ServerSocket::~ServerSocket() = default;
int ServerSocket::ListenWithAddressAndPort(const std::string& address_string,
uint16_t port,
diff --git a/net/socket/socket_test_util.cc b/net/socket/socket_test_util.cc
index 5c0b0b7..e6b5253 100644
--- a/net/socket/socket_test_util.cc
+++ b/net/socket/socket_test_util.cc
@@ -139,7 +139,7 @@
peer_addr(addr) {
}
-MockConnect::~MockConnect() {}
+MockConnect::~MockConnect() = default;
void SocketDataProvider::OnEnableTCPFastOpenIfSupported() {}
@@ -178,8 +178,7 @@
write_count_(writes_count) {
}
-StaticSocketDataHelper::~StaticSocketDataHelper() {
-}
+StaticSocketDataHelper::~StaticSocketDataHelper() = default;
const MockRead& StaticSocketDataHelper::PeekRead() const {
CHECK(!AllReadDataConsumed());
@@ -248,8 +247,7 @@
: helper_(reads, reads_count, writes, writes_count) {
}
-StaticSocketDataProvider::~StaticSocketDataProvider() {
-}
+StaticSocketDataProvider::~StaticSocketDataProvider() = default;
MockRead StaticSocketDataProvider::OnRead() {
CHECK(!helper_.AllReadDataConsumed());
@@ -307,8 +305,7 @@
SSLSocketDataProvider::SSLSocketDataProvider(
const SSLSocketDataProvider& other) = default;
-SSLSocketDataProvider::~SSLSocketDataProvider() {
-}
+SSLSocketDataProvider::~SSLSocketDataProvider() = default;
SequencedSocketData::SequencedSocketData(MockRead* reads,
size_t reads_count,
@@ -693,13 +690,12 @@
NET_TRACE(1, " *** ") << "Done";
}
-SequencedSocketData::~SequencedSocketData() {
-}
+SequencedSocketData::~SequencedSocketData() = default;
MockClientSocketFactory::MockClientSocketFactory()
: enable_read_if_ready_(false) {}
-MockClientSocketFactory::~MockClientSocketFactory() {}
+MockClientSocketFactory::~MockClientSocketFactory() = default;
void MockClientSocketFactory::AddSocketDataProvider(
SocketDataProvider* data) {
@@ -855,7 +851,7 @@
return NULL;
}
-MockClientSocket::~MockClientSocket() {}
+MockClientSocket::~MockClientSocket() = default;
void MockClientSocket::RunCallbackAsync(const CompletionCallback& callback,
int result) {
@@ -1532,8 +1528,7 @@
DCHECK(completion_count);
}
-TestSocketRequest::~TestSocketRequest() {
-}
+TestSocketRequest::~TestSocketRequest() = default;
void TestSocketRequest::OnComplete(int result) {
SetResult(result);
@@ -1548,7 +1543,7 @@
const int ClientSocketPoolTest::kRequestNotFound = -2;
ClientSocketPoolTest::ClientSocketPoolTest() : completion_count_(0) {}
-ClientSocketPoolTest::~ClientSocketPoolTest() {}
+ClientSocketPoolTest::~ClientSocketPoolTest() = default;
int ClientSocketPoolTest::GetOrderOfRequest(size_t index) const {
index--;
@@ -1588,7 +1583,7 @@
const CompletionCallback& callback)
: socket_(std::move(socket)), handle_(handle), user_callback_(callback) {}
-MockTransportClientSocketPool::MockConnectJob::~MockConnectJob() {}
+MockTransportClientSocketPool::MockConnectJob::~MockConnectJob() = default;
int MockTransportClientSocketPool::MockConnectJob::Connect() {
int rv = socket_->Connect(base::Bind(&MockConnectJob::OnConnect,
@@ -1658,7 +1653,7 @@
release_count_(0),
cancel_count_(0) {}
-MockTransportClientSocketPool::~MockTransportClientSocketPool() {}
+MockTransportClientSocketPool::~MockTransportClientSocketPool() = default;
int MockTransportClientSocketPool::RequestSocket(
const std::string& group_name,
@@ -1714,7 +1709,7 @@
NULL),
transport_pool_(transport_pool) {}
-MockSOCKSClientSocketPool::~MockSOCKSClientSocketPool() {}
+MockSOCKSClientSocketPool::~MockSOCKSClientSocketPool() = default;
int MockSOCKSClientSocketPool::RequestSocket(const std::string& group_name,
const void* socket_params,
diff --git a/net/socket/socks_client_socket_pool.cc b/net/socket/socks_client_socket_pool.cc
index f2632f3..86b4ac0 100644
--- a/net/socket/socks_client_socket_pool.cc
+++ b/net/socket/socks_client_socket_pool.cc
@@ -33,7 +33,7 @@
socks_v5_(socks_v5) {
}
-SOCKSSocketParams::~SOCKSSocketParams() {}
+SOCKSSocketParams::~SOCKSSocketParams() = default;
// SOCKSConnectJobs will time out after this many seconds. Note this is on
// top of the timeout for the transport socket.
@@ -209,8 +209,7 @@
base_.AddLowerLayeredPool(transport_pool_);
}
-SOCKSClientSocketPool::~SOCKSClientSocketPool() {
-}
+SOCKSClientSocketPool::~SOCKSClientSocketPool() = default;
int SOCKSClientSocketPool::RequestSocket(const std::string& group_name,
const void* socket_params,
diff --git a/net/socket/socks_client_socket_pool_unittest.cc b/net/socket/socks_client_socket_pool_unittest.cc
index 5331739..eaafb9d 100644
--- a/net/socket/socks_client_socket_pool_unittest.cc
+++ b/net/socket/socks_client_socket_pool_unittest.cc
@@ -107,7 +107,7 @@
NULL,
NULL) {}
- ~SOCKSClientSocketPoolTest() override {}
+ ~SOCKSClientSocketPoolTest() override = default;
int StartRequestV5(const std::string& group_name, RequestPriority priority) {
return test_base_.StartRequestUsingPool(
diff --git a/net/socket/ssl_client_socket_pool.cc b/net/socket/ssl_client_socket_pool.cc
index bc6960c..8eb860f 100644
--- a/net/socket/ssl_client_socket_pool.cc
+++ b/net/socket/ssl_client_socket_pool.cc
@@ -59,7 +59,7 @@
(!direct_params_ && !socks_proxy_params_ && http_proxy_params_));
}
-SSLSocketParams::~SSLSocketParams() {}
+SSLSocketParams::~SSLSocketParams() = default;
SSLSocketParams::ConnectionType SSLSocketParams::GetConnectionType() const {
if (direct_params_.get()) {
@@ -138,8 +138,7 @@
version_interference_error_(OK),
version_interference_details_(SSLErrorDetails::kOther) {}
-SSLConnectJob::~SSLConnectJob() {
-}
+SSLConnectJob::~SSLConnectJob() = default;
LoadState SSLConnectJob::GetLoadState() const {
switch (next_state_) {
@@ -564,8 +563,7 @@
base::TimeDelta::FromSeconds(kSSLHandshakeTimeoutInSeconds);
}
-SSLClientSocketPool::SSLConnectJobFactory::~SSLConnectJobFactory() {
-}
+SSLClientSocketPool::SSLConnectJobFactory::~SSLConnectJobFactory() = default;
SSLClientSocketPool::SSLClientSocketPool(
int max_sockets,
diff --git a/net/socket/ssl_client_socket_unittest.cc b/net/socket/ssl_client_socket_unittest.cc
index cab4c9ef..d0527ee 100644
--- a/net/socket/ssl_client_socket_unittest.cc
+++ b/net/socket/ssl_client_socket_unittest.cc
@@ -97,7 +97,7 @@
public:
explicit WrappedStreamSocket(std::unique_ptr<StreamSocket> transport)
: transport_(std::move(transport)) {}
- ~WrappedStreamSocket() override {}
+ ~WrappedStreamSocket() override = default;
// StreamSocket implementation:
int Connect(const CompletionCallback& callback) override {
@@ -180,7 +180,7 @@
class ReadBufferingStreamSocket : public WrappedStreamSocket {
public:
explicit ReadBufferingStreamSocket(std::unique_ptr<StreamSocket> transport);
- ~ReadBufferingStreamSocket() override {}
+ ~ReadBufferingStreamSocket() override = default;
// Socket implementation:
int Read(IOBuffer* buf,
@@ -338,7 +338,7 @@
public:
explicit SynchronousErrorStreamSocket(std::unique_ptr<StreamSocket> transport)
: WrappedStreamSocket(std::move(transport)) {}
- ~SynchronousErrorStreamSocket() override {}
+ ~SynchronousErrorStreamSocket() override = default;
// Socket implementation:
int Read(IOBuffer* buf,
@@ -414,7 +414,7 @@
public:
explicit FakeBlockingStreamSocket(std::unique_ptr<StreamSocket> transport)
: WrappedStreamSocket(std::move(transport)) {}
- ~FakeBlockingStreamSocket() override {}
+ ~FakeBlockingStreamSocket() override = default;
// Socket implementation:
int Read(IOBuffer* buf,
@@ -702,7 +702,7 @@
: WrappedStreamSocket(std::move(transport)),
read_count_(0),
write_count_(0) {}
- ~CountingStreamSocket() override {}
+ ~CountingStreamSocket() override = default;
// Socket implementation:
int Read(IOBuffer* buf,
@@ -734,7 +734,7 @@
: socket_(socket),
callback_(base::Bind(&DeleteSocketCallback::OnComplete,
base::Unretained(this))) {}
- ~DeleteSocketCallback() override {}
+ ~DeleteSocketCallback() override = default;
const CompletionCallback& callback() const { return callback_; }
@@ -811,7 +811,7 @@
class MockExpectCTReporter : public TransportSecurityState::ExpectCTReporter {
public:
MockExpectCTReporter() : num_failures_(0) {}
- ~MockExpectCTReporter() override {}
+ ~MockExpectCTReporter() override = default;
void OnExpectCTFailed(const HostPortPair& host_port_pair,
const GURL& report_uri,
diff --git a/net/socket/ssl_server_socket_impl.cc b/net/socket/ssl_server_socket_impl.cc
index da690a4..cba12a6b 100644
--- a/net/socket/ssl_server_socket_impl.cc
+++ b/net/socket/ssl_server_socket_impl.cc
@@ -691,7 +691,7 @@
}
}
-SSLServerContextImpl::~SSLServerContextImpl() {}
+SSLServerContextImpl::~SSLServerContextImpl() = default;
std::unique_ptr<SSLServerSocket> SSLServerContextImpl::CreateSSLServerSocket(
std::unique_ptr<StreamSocket> socket) {
diff --git a/net/socket/ssl_server_socket_unittest.cc b/net/socket/ssl_server_socket_unittest.cc
index 102e8033b..73a038d 100644
--- a/net/socket/ssl_server_socket_unittest.cc
+++ b/net/socket/ssl_server_socket_unittest.cc
@@ -222,7 +222,7 @@
FakeDataChannel* outgoing_channel)
: incoming_(incoming_channel), outgoing_(outgoing_channel) {}
- ~FakeSocket() override {}
+ ~FakeSocket() override = default;
int Read(IOBuffer* buf,
int buf_len,
diff --git a/net/socket/stream_socket.cc b/net/socket/stream_socket.cc
index ec5500a..4eb7e14 100644
--- a/net/socket/stream_socket.cc
+++ b/net/socket/stream_socket.cc
@@ -84,6 +84,6 @@
StreamSocket::SocketMemoryStats::SocketMemoryStats()
: total_size(0), buffer_size(0), cert_count(0), cert_size(0) {}
-StreamSocket::SocketMemoryStats::~SocketMemoryStats() {}
+StreamSocket::SocketMemoryStats::~SocketMemoryStats() = default;
} // namespace net
diff --git a/net/socket/tcp_client_socket_unittest.cc b/net/socket/tcp_client_socket_unittest.cc
index b3257aa6..1766d7f 100644
--- a/net/socket/tcp_client_socket_unittest.cc
+++ b/net/socket/tcp_client_socket_unittest.cc
@@ -115,7 +115,7 @@
class TestSocketPerformanceWatcher : public SocketPerformanceWatcher {
public:
TestSocketPerformanceWatcher() : connection_changed_count_(0u) {}
- ~TestSocketPerformanceWatcher() override {}
+ ~TestSocketPerformanceWatcher() override = default;
bool ShouldNotifyUpdatedRTT() const override { return true; }
diff --git a/net/socket/tcp_server_socket.cc b/net/socket/tcp_server_socket.cc
index 779a24d..2d9c5fd 100644
--- a/net/socket/tcp_server_socket.cc
+++ b/net/socket/tcp_server_socket.cc
@@ -22,8 +22,7 @@
return socket_.AdoptUnconnectedSocket(socket);
}
-TCPServerSocket::~TCPServerSocket() {
-}
+TCPServerSocket::~TCPServerSocket() = default;
int TCPServerSocket::Listen(const IPEndPoint& address, int backlog) {
int result = socket_.Open(address.GetFamily());
diff --git a/net/socket/tcp_socket_posix.cc b/net/socket/tcp_socket_posix.cc
index 7e80ab03..b46ccad 100644
--- a/net/socket/tcp_socket_posix.cc
+++ b/net/socket/tcp_socket_posix.cc
@@ -112,7 +112,7 @@
base::Unretained(this)));
}
- ~FastOpenProbe() {}
+ ~FastOpenProbe() = default;
// Checks if the kernel supports TCP FastOpen. Called only once, on startup.
void DetectTCPFastOpenSupport() {
diff --git a/net/socket/tcp_socket_unittest.cc b/net/socket/tcp_socket_unittest.cc
index 508b2b74..e170f3b 100644
--- a/net/socket/tcp_socket_unittest.cc
+++ b/net/socket/tcp_socket_unittest.cc
@@ -40,7 +40,7 @@
: should_notify_updated_rtt_(should_notify_updated_rtt),
connection_changed_count_(0u),
rtt_notification_count_(0u) {}
- ~TestSocketPerformanceWatcher() override {}
+ ~TestSocketPerformanceWatcher() override = default;
bool ShouldNotifyUpdatedRTT() const override {
return should_notify_updated_rtt_;
diff --git a/net/socket/transport_client_socket_pool.cc b/net/socket/transport_client_socket_pool.cc
index 1288c09..53f2c15 100644
--- a/net/socket/transport_client_socket_pool.cc
+++ b/net/socket/transport_client_socket_pool.cc
@@ -62,7 +62,7 @@
destination_.set_allow_cached_response(false);
}
-TransportSocketParams::~TransportSocketParams() {}
+TransportSocketParams::~TransportSocketParams() = default;
// TODO(eroman): The use of this constant needs to be re-evaluated. The time
// needed for TCPClientSocketXXX::Connect() can be arbitrarily long, since
@@ -483,7 +483,7 @@
base_.EnableConnectBackupJobs();
}
-TransportClientSocketPool::~TransportClientSocketPool() {}
+TransportClientSocketPool::~TransportClientSocketPool() = default;
int TransportClientSocketPool::RequestSocket(const std::string& group_name,
const void* params,
diff --git a/net/socket/transport_client_socket_pool_test_util.cc b/net/socket/transport_client_socket_pool_test_util.cc
index 46d352c6..361d7f8 100644
--- a/net/socket/transport_client_socket_pool_test_util.cc
+++ b/net/socket/transport_client_socket_pool_test_util.cc
@@ -360,7 +360,7 @@
delay_(base::TimeDelta::FromMilliseconds(
ClientSocketPool::kMaxConnectRetryIntervalMs)) {}
-MockTransportClientSocketFactory::~MockTransportClientSocketFactory() {}
+MockTransportClientSocketFactory::~MockTransportClientSocketFactory() = default;
std::unique_ptr<DatagramClientSocket>
MockTransportClientSocketFactory::CreateDatagramClientSocket(
diff --git a/net/socket/transport_client_socket_pool_unittest.cc b/net/socket/transport_client_socket_pool_unittest.cc
index cbe31e1..313c5ba1 100644
--- a/net/socket/transport_client_socket_pool_unittest.cc
+++ b/net/socket/transport_client_socket_pool_unittest.cc
@@ -492,7 +492,7 @@
base::Unretained(this))) {
}
- ~RequestSocketCallback() override {}
+ ~RequestSocketCallback() override = default;
const CompletionCallback& callback() const { return callback_; }
diff --git a/net/socket/transport_client_socket_unittest.cc b/net/socket/transport_client_socket_unittest.cc
index 7db6db4..ba6a76b 100644
--- a/net/socket/transport_client_socket_unittest.cc
+++ b/net/socket/transport_client_socket_unittest.cc
@@ -49,7 +49,7 @@
socket_factory_(ClientSocketFactory::GetDefaultFactory()),
close_server_socket_on_next_send_(false) {}
- virtual ~TransportClientSocketTest() {}
+ virtual ~TransportClientSocketTest() = default;
// Testcase hooks
void SetUp() override;
diff --git a/net/socket/udp_client_socket.cc b/net/socket/udp_client_socket.cc
index 767aa63..aac8ae06 100644
--- a/net/socket/udp_client_socket.cc
+++ b/net/socket/udp_client_socket.cc
@@ -15,8 +15,7 @@
: socket_(bind_type, rand_int_cb, net_log, source),
network_(NetworkChangeNotifier::kInvalidNetworkHandle) {}
-UDPClientSocket::~UDPClientSocket() {
-}
+UDPClientSocket::~UDPClientSocket() = default;
int UDPClientSocket::Connect(const IPEndPoint& address) {
int rv = socket_.Open(address.GetFamily());
diff --git a/net/socket/udp_server_socket.cc b/net/socket/udp_server_socket.cc
index 1b2d74e4..d5f107a 100644
--- a/net/socket/udp_server_socket.cc
+++ b/net/socket/udp_server_socket.cc
@@ -15,8 +15,7 @@
allow_address_reuse_(false),
allow_broadcast_(false) {}
-UDPServerSocket::~UDPServerSocket() {
-}
+UDPServerSocket::~UDPServerSocket() = default;
int UDPServerSocket::Listen(const IPEndPoint& address) {
int rv = socket_.Open(address.GetFamily());
diff --git a/net/socket/unix_domain_server_socket_posix.cc b/net/socket/unix_domain_server_socket_posix.cc
index 86927c8..2bea30e 100644
--- a/net/socket/unix_domain_server_socket_posix.cc
+++ b/net/socket/unix_domain_server_socket_posix.cc
@@ -42,8 +42,7 @@
DCHECK(!auth_callback_.is_null());
}
-UnixDomainServerSocket::~UnixDomainServerSocket() {
-}
+UnixDomainServerSocket::~UnixDomainServerSocket() = default;
// static
bool UnixDomainServerSocket::GetPeerCredentials(SocketDescriptor socket,
diff --git a/net/test/embedded_test_server/default_handlers.cc b/net/test/embedded_test_server/default_handlers.cc
index a1bf86b..a1e984fa 100644
--- a/net/test/embedded_test_server/default_handlers.cc
+++ b/net/test/embedded_test_server/default_handlers.cc
@@ -608,7 +608,7 @@
// Never returns a response.
class HungHttpResponse : public HttpResponse {
public:
- HungHttpResponse() {}
+ HungHttpResponse() = default;
void SendResponse(const SendBytesCallback& send,
const SendCompleteCallback& done) override {}
@@ -626,7 +626,7 @@
// Return headers, then hangs.
class HungAfterHeadersHttpResponse : public HttpResponse {
public:
- HungAfterHeadersHttpResponse() {}
+ HungAfterHeadersHttpResponse() = default;
void SendResponse(const SendBytesCallback& send,
const SendCompleteCallback& done) override {
diff --git a/net/test/embedded_test_server/embedded_test_server_unittest.cc b/net/test/embedded_test_server/embedded_test_server_unittest.cc
index 74b78728..4eec5c5 100644
--- a/net/test/embedded_test_server/embedded_test_server_unittest.cc
+++ b/net/test/embedded_test_server/embedded_test_server_unittest.cc
@@ -78,7 +78,7 @@
did_read_from_socket_(false),
task_runner_(base::ThreadTaskRunnerHandle::Get()) {}
- ~TestConnectionListener() override {}
+ ~TestConnectionListener() override = default;
// Get called from the EmbeddedTestServer thread to be notified that
// a connection was accepted.
@@ -419,8 +419,8 @@
class CancelRequestDelegate : public TestDelegate {
public:
- CancelRequestDelegate() {}
- ~CancelRequestDelegate() override {}
+ CancelRequestDelegate() = default;
+ ~CancelRequestDelegate() override = default;
void OnResponseStarted(URLRequest* request, int net_error) override {
TestDelegate::OnResponseStarted(request, net_error);
diff --git a/net/test/embedded_test_server/http_request.cc b/net/test/embedded_test_server/http_request.cc
index ecac880..a714157d 100644
--- a/net/test/embedded_test_server/http_request.cc
+++ b/net/test/embedded_test_server/http_request.cc
@@ -36,8 +36,7 @@
HttpRequest::HttpRequest(const HttpRequest& other) = default;
-HttpRequest::~HttpRequest() {
-}
+HttpRequest::~HttpRequest() = default;
GURL HttpRequest::GetURL() const {
if (base_url.is_valid())
@@ -52,8 +51,7 @@
declared_content_length_(0) {
}
-HttpRequestParser::~HttpRequestParser() {
-}
+HttpRequestParser::~HttpRequestParser() = default;
void HttpRequestParser::ProcessChunk(const base::StringPiece& data) {
data.AppendToString(&buffer_);
diff --git a/net/test/embedded_test_server/http_response.cc b/net/test/embedded_test_server/http_response.cc
index fd55211..168049e 100644
--- a/net/test/embedded_test_server/http_response.cc
+++ b/net/test/embedded_test_server/http_response.cc
@@ -13,14 +13,13 @@
namespace net {
namespace test_server {
-HttpResponse::~HttpResponse() {
-}
+HttpResponse::~HttpResponse() = default;
RawHttpResponse::RawHttpResponse(const std::string& headers,
const std::string& contents)
: headers_(headers), contents_(contents) {}
-RawHttpResponse::~RawHttpResponse() {}
+RawHttpResponse::~RawHttpResponse() = default;
void RawHttpResponse::SendResponse(const SendBytesCallback& send,
const SendCompleteCallback& done) {
@@ -47,8 +46,7 @@
BasicHttpResponse::BasicHttpResponse() : code_(HTTP_OK) {
}
-BasicHttpResponse::~BasicHttpResponse() {
-}
+BasicHttpResponse::~BasicHttpResponse() = default;
std::string BasicHttpResponse::ToResponseString() const {
// Response line with headers.
diff --git a/net/test/embedded_test_server/simple_connection_listener.cc b/net/test/embedded_test_server/simple_connection_listener.cc
index d2ea1c9..cb36d760 100644
--- a/net/test/embedded_test_server/simple_connection_listener.cc
+++ b/net/test/embedded_test_server/simple_connection_listener.cc
@@ -19,7 +19,7 @@
allow_additional_connections_(allow_additional_connections),
run_loop_task_runner_(base::ThreadTaskRunnerHandle::Get()) {}
-SimpleConnectionListener::~SimpleConnectionListener() {}
+SimpleConnectionListener::~SimpleConnectionListener() = default;
void SimpleConnectionListener::AcceptedSocket(const StreamSocket& socket) {
++seen_connections_;
diff --git a/net/test/scoped_disable_exit_on_dfatal.cc b/net/test/scoped_disable_exit_on_dfatal.cc
index 14821db..4e7b750 100644
--- a/net/test/scoped_disable_exit_on_dfatal.cc
+++ b/net/test/scoped_disable_exit_on_dfatal.cc
@@ -14,7 +14,7 @@
ScopedDisableExitOnDFatal::ScopedDisableExitOnDFatal()
: assert_handler_(base::Bind(LogAssertHandler)) {}
-ScopedDisableExitOnDFatal::~ScopedDisableExitOnDFatal() {}
+ScopedDisableExitOnDFatal::~ScopedDisableExitOnDFatal() = default;
// static
void ScopedDisableExitOnDFatal::LogAssertHandler(
diff --git a/net/test/spawned_test_server/base_test_server.cc b/net/test/spawned_test_server/base_test_server.cc
index 69d9403..c720d64 100644
--- a/net/test/spawned_test_server/base_test_server.cc
+++ b/net/test/spawned_test_server/base_test_server.cc
@@ -164,12 +164,12 @@
} // namespace
-BaseTestServer::SSLOptions::SSLOptions() {}
+BaseTestServer::SSLOptions::SSLOptions() = default;
BaseTestServer::SSLOptions::SSLOptions(ServerCertificate cert)
: server_certificate(cert) {}
BaseTestServer::SSLOptions::SSLOptions(const SSLOptions& other) = default;
-BaseTestServer::SSLOptions::~SSLOptions() {}
+BaseTestServer::SSLOptions::~SSLOptions() = default;
base::FilePath BaseTestServer::SSLOptions::GetCertificateFile() const {
switch (server_certificate) {
@@ -257,7 +257,7 @@
Init(GetHostname(type, ssl_options));
}
-BaseTestServer::~BaseTestServer() {}
+BaseTestServer::~BaseTestServer() = default;
bool BaseTestServer::Start() {
return StartInBackground() && BlockUntilStarted();
diff --git a/net/test/url_request/ssl_certificate_error_job.cc b/net/test/url_request/ssl_certificate_error_job.cc
index 759d545..d23f9ced 100644
--- a/net/test/url_request/ssl_certificate_error_job.cc
+++ b/net/test/url_request/ssl_certificate_error_job.cc
@@ -23,8 +23,8 @@
class MockJobInterceptor : public URLRequestInterceptor {
public:
- MockJobInterceptor() {}
- ~MockJobInterceptor() override {}
+ MockJobInterceptor() = default;
+ ~MockJobInterceptor() override = default;
// URLRequestJobFactory::ProtocolHandler implementation:
URLRequestJob* MaybeInterceptRequest(
@@ -62,8 +62,7 @@
return GURL(base::StringPrintf("https://%s", kMockHostname));
}
-SSLCertificateErrorJob::~SSLCertificateErrorJob() {
-}
+SSLCertificateErrorJob::~SSLCertificateErrorJob() = default;
void SSLCertificateErrorJob::NotifyError() {
SSLInfo info;
diff --git a/net/test/url_request/url_request_failed_job.cc b/net/test/url_request/url_request_failed_job.cc
index d87e5d3..5417deb6 100644
--- a/net/test/url_request/url_request_failed_job.cc
+++ b/net/test/url_request/url_request_failed_job.cc
@@ -37,8 +37,8 @@
class MockJobInterceptor : public URLRequestInterceptor {
public:
- MockJobInterceptor() {}
- ~MockJobInterceptor() override {}
+ MockJobInterceptor() = default;
+ ~MockJobInterceptor() override = default;
// URLRequestJobFactory::ProtocolHandler implementation:
URLRequestJob* MaybeInterceptRequest(
@@ -177,8 +177,7 @@
return GetMockUrl("https", hostname, START, net_error);
}
-URLRequestFailedJob::~URLRequestFailedJob() {
-}
+URLRequestFailedJob::~URLRequestFailedJob() = default;
void URLRequestFailedJob::StartAsync() {
if (phase_ == START) {
diff --git a/net/test/url_request/url_request_hanging_read_job.cc b/net/test/url_request/url_request_hanging_read_job.cc
index 1e19435..006e7bab 100644
--- a/net/test/url_request/url_request_hanging_read_job.cc
+++ b/net/test/url_request/url_request_hanging_read_job.cc
@@ -27,8 +27,8 @@
class MockJobInterceptor : public URLRequestInterceptor {
public:
- MockJobInterceptor() {}
- ~MockJobInterceptor() override {}
+ MockJobInterceptor() = default;
+ ~MockJobInterceptor() override = default;
// URLRequestInterceptor implementation
URLRequestJob* MaybeInterceptRequest(
@@ -58,7 +58,7 @@
weak_factory_.GetWeakPtr()));
}
-URLRequestHangingReadJob::~URLRequestHangingReadJob() {}
+URLRequestHangingReadJob::~URLRequestHangingReadJob() = default;
int URLRequestHangingReadJob::ReadRawData(IOBuffer* buf, int buf_size) {
// Make read hang. It never completes.
diff --git a/net/test/url_request/url_request_mock_data_job.cc b/net/test/url_request/url_request_mock_data_job.cc
index 256acf2b..2e71b9c 100644
--- a/net/test/url_request/url_request_mock_data_job.cc
+++ b/net/test/url_request/url_request_mock_data_job.cc
@@ -75,8 +75,8 @@
class MockJobInterceptor : public URLRequestInterceptor {
public:
- MockJobInterceptor() {}
- ~MockJobInterceptor() override {}
+ MockJobInterceptor() = default;
+ ~MockJobInterceptor() override = default;
// URLRequestInterceptor implementation
URLRequestJob* MaybeInterceptRequest(
@@ -117,8 +117,7 @@
weak_factory_.GetWeakPtr()));
}
-URLRequestMockDataJob::~URLRequestMockDataJob() {
-}
+URLRequestMockDataJob::~URLRequestMockDataJob() = default;
int URLRequestMockDataJob::ReadRawData(IOBuffer* buf, int buf_size) {
int bytes_read =
diff --git a/net/test/url_request/url_request_mock_http_job.cc b/net/test/url_request/url_request_mock_http_job.cc
index f2fb63b..8ca5a69 100644
--- a/net/test/url_request/url_request_mock_http_job.cc
+++ b/net/test/url_request/url_request_mock_http_job.cc
@@ -37,7 +37,7 @@
bool map_all_requests_to_base_path)
: base_path_(base_path),
map_all_requests_to_base_path_(map_all_requests_to_base_path) {}
- ~MockJobInterceptor() override {}
+ ~MockJobInterceptor() override = default;
// URLRequestJobFactory::ProtocolHandler implementation
URLRequestJob* MaybeInterceptRequest(
@@ -133,8 +133,7 @@
base::CreateTaskRunnerWithTraits({base::MayBlock()})),
weak_ptr_factory_(this) {}
-URLRequestMockHTTPJob::~URLRequestMockHTTPJob() {
-}
+URLRequestMockHTTPJob::~URLRequestMockHTTPJob() = default;
// Public virtual version.
void URLRequestMockHTTPJob::GetResponseInfo(HttpResponseInfo* info) {
diff --git a/net/test/url_request/url_request_slow_download_job.cc b/net/test/url_request/url_request_slow_download_job.cc
index 876e54a..dfba97e 100644
--- a/net/test/url_request/url_request_slow_download_job.cc
+++ b/net/test/url_request/url_request_slow_download_job.cc
@@ -37,8 +37,8 @@
class URLRequestSlowDownloadJob::Interceptor : public URLRequestInterceptor {
public:
- Interceptor() {}
- ~Interceptor() override {}
+ Interceptor() = default;
+ ~Interceptor() override = default;
// URLRequestInterceptor implementation:
URLRequestJob* MaybeInterceptRequest(
diff --git a/net/tools/cachetool/cachetool.cc b/net/tools/cachetool/cachetool.cc
index 0b84790d..2c3207f 100644
--- a/net/tools/cachetool/cachetool.cc
+++ b/net/tools/cachetool/cachetool.cc
@@ -81,7 +81,7 @@
public:
explicit CommandMarshal(Backend* cache_backend)
: command_failed_(false), cache_backend_(cache_backend) {}
- virtual ~CommandMarshal() {}
+ virtual ~CommandMarshal() = default;
// Reads the next command's name to execute.
virtual std::string ReadCommandName() = 0;
diff --git a/net/tools/content_decoder_tool/content_decoder_tool.cc b/net/tools/content_decoder_tool/content_decoder_tool.cc
index cf70028..6ff7eb1 100644
--- a/net/tools/content_decoder_tool/content_decoder_tool.cc
+++ b/net/tools/content_decoder_tool/content_decoder_tool.cc
@@ -30,7 +30,7 @@
public:
explicit StdinSourceStream(std::istream* input_stream)
: SourceStream(SourceStream::TYPE_NONE), input_stream_(input_stream) {}
- ~StdinSourceStream() override {}
+ ~StdinSourceStream() override = default;
// SourceStream implementation.
int Read(IOBuffer* dest_buffer,
diff --git a/net/tools/gdig/file_net_log.cc b/net/tools/gdig/file_net_log.cc
index 0e55682..c160ae3 100644
--- a/net/tools/gdig/file_net_log.cc
+++ b/net/tools/gdig/file_net_log.cc
@@ -20,8 +20,7 @@
DCHECK(destination != NULL);
}
-FileNetLogObserver::~FileNetLogObserver() {
-}
+FileNetLogObserver::~FileNetLogObserver() = default;
void FileNetLogObserver::OnAddEntry(const net::NetLogEntry& entry) {
// Only NetLogWithSources without a NetLog should have an invalid source.
diff --git a/net/tools/get_server_time/get_server_time.cc b/net/tools/get_server_time/get_server_time.cc
index 9582b265a..60efacc6 100644
--- a/net/tools/get_server_time/get_server_time.cc
+++ b/net/tools/get_server_time/get_server_time.cc
@@ -71,9 +71,9 @@
// URLFetcher synchronous.
class QuitDelegate : public net::URLFetcherDelegate {
public:
- QuitDelegate() {}
+ QuitDelegate() = default;
- ~QuitDelegate() override {}
+ ~QuitDelegate() override = default;
// net::URLFetcherDelegate implementation.
void OnURLFetchComplete(const net::URLFetcher* source) override {
@@ -101,7 +101,7 @@
// to the logs.
class PrintingLogObserver : public net::NetLog::ThreadSafeObserver {
public:
- PrintingLogObserver() {}
+ PrintingLogObserver() = default;
~PrintingLogObserver() override {
// This is guaranteed to be safe as this program is single threaded.
diff --git a/net/tools/net_watcher/net_watcher.cc b/net/tools/net_watcher/net_watcher.cc
index 53ca175..8f6f61f 100644
--- a/net/tools/net_watcher/net_watcher.cc
+++ b/net/tools/net_watcher/net_watcher.cc
@@ -101,9 +101,9 @@
public net::NetworkChangeNotifier::NetworkChangeObserver,
public net::ProxyConfigService::Observer {
public:
- NetWatcher() {}
+ NetWatcher() = default;
- ~NetWatcher() override {}
+ ~NetWatcher() override = default;
// net::NetworkChangeNotifier::IPAddressObserver implementation.
void OnIPAddressChanged() override { LOG(INFO) << "OnIPAddressChanged()"; }
diff --git a/net/tools/quic/chlo_extractor.cc b/net/tools/quic/chlo_extractor.cc
index 078d6a05..38cb989 100644
--- a/net/tools/quic/chlo_extractor.cc
+++ b/net/tools/quic/chlo_extractor.cc
@@ -22,7 +22,7 @@
public:
ChloFramerVisitor(QuicFramer* framer, ChloExtractor::Delegate* delegate);
- ~ChloFramerVisitor() override {}
+ ~ChloFramerVisitor() override = default;
// QuicFramerVisitorInterface implementation
void OnError(QuicFramer* framer) override {}
diff --git a/net/tools/quic/chlo_extractor_test.cc b/net/tools/quic/chlo_extractor_test.cc
index 488b0bd..4fdd591a 100644
--- a/net/tools/quic/chlo_extractor_test.cc
+++ b/net/tools/quic/chlo_extractor_test.cc
@@ -18,8 +18,8 @@
class TestDelegate : public ChloExtractor::Delegate {
public:
- TestDelegate() {}
- ~TestDelegate() override {}
+ TestDelegate() = default;
+ ~TestDelegate() override = default;
// ChloExtractor::Delegate implementation
void OnChlo(QuicTransportVersion version,
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index dc1ff7d..ceeca25d 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -242,7 +242,7 @@
public:
explicit ServerDelegate(QuicDispatcher* dispatcher)
: dispatcher_(dispatcher) {}
- ~ServerDelegate() override {}
+ ~ServerDelegate() override = default;
void OnCanWrite() override { dispatcher_->OnCanWrite(); }
private:
@@ -252,7 +252,7 @@
class ClientDelegate : public PacketDroppingTestWriter::Delegate {
public:
explicit ClientDelegate(QuicClient* client) : client_(client) {}
- ~ClientDelegate() override {}
+ ~ClientDelegate() override = default;
void OnCanWrite() override {
EpollEvent event(EPOLLOUT);
client_->epoll_network_helper()->OnEvent(client_->GetLatestFD(), &event);
@@ -2214,7 +2214,7 @@
: QuicSimpleServerStream(id, session, response_cache),
response_body_(std::move(response_body)) {}
- ~ServerStreamWithErrorResponseBody() override {}
+ ~ServerStreamWithErrorResponseBody() override = default;
protected:
void SendErrorResponse() override {
@@ -2237,7 +2237,7 @@
explicit StreamWithErrorFactory(string response_body)
: response_body_(std::move(response_body)) {}
- ~StreamWithErrorFactory() override {}
+ ~StreamWithErrorFactory() override = default;
QuicSimpleServerStream* CreateStream(
QuicStreamId id,
@@ -2259,7 +2259,7 @@
QuicHttpResponseCache* response_cache)
: QuicSimpleServerStream(id, session, response_cache) {}
- ~ServerStreamThatDropsBody() override {}
+ ~ServerStreamThatDropsBody() override = default;
protected:
void OnDataAvailable() override {
@@ -2293,9 +2293,9 @@
class ServerStreamThatDropsBodyFactory : public QuicTestServer::StreamFactory {
public:
- ServerStreamThatDropsBodyFactory() {}
+ ServerStreamThatDropsBodyFactory() = default;
- ~ServerStreamThatDropsBodyFactory() override {}
+ ~ServerStreamThatDropsBodyFactory() override = default;
QuicSimpleServerStream* CreateStream(
QuicStreamId id,
@@ -2315,7 +2315,7 @@
: QuicSimpleServerStream(id, session, response_cache),
body_bytes_(body_bytes) {}
- ~ServerStreamThatSendsHugeResponse() override {}
+ ~ServerStreamThatSendsHugeResponse() override = default;
protected:
void SendResponse() override {
@@ -2338,7 +2338,7 @@
explicit ServerStreamThatSendsHugeResponseFactory(int64_t body_bytes)
: body_bytes_(body_bytes) {}
- ~ServerStreamThatSendsHugeResponseFactory() override {}
+ ~ServerStreamThatSendsHugeResponseFactory() override = default;
QuicSimpleServerStream* CreateStream(
QuicStreamId id,
@@ -2356,7 +2356,7 @@
public:
ClientStreamThatDropsBody(QuicStreamId id, QuicSpdyClientSession* session)
: QuicSpdyClientStream(id, session) {}
- ~ClientStreamThatDropsBody() override {}
+ ~ClientStreamThatDropsBody() override = default;
void OnDataAvailable() override {
while (HasBytesToRead()) {
@@ -2387,7 +2387,7 @@
crypto_config,
push_promise_index) {}
- ~ClientSessionThatDropsBody() override {}
+ ~ClientSessionThatDropsBody() override = default;
std::unique_ptr<QuicSpdyClientStream> CreateClientStream() override {
return QuicMakeUnique<ClientStreamThatDropsBody>(GetNextOutgoingStreamId(),
@@ -2408,7 +2408,7 @@
config,
supported_versions,
epoll_server) {}
- ~MockableQuicClientThatDropsBody() override {}
+ ~MockableQuicClientThatDropsBody() override = default;
std::unique_ptr<QuicSession> CreateQuicClientSession(
QuicConnection* connection) override {
@@ -2435,7 +2435,7 @@
PRIVACY_MODE_DISABLED),
config, supported_versions, epoll_server()));
}
- ~QuicTestClientThatDropsBody() override {}
+ ~QuicTestClientThatDropsBody() override = default;
};
TEST_P(EndToEndTest, EarlyResponseFinRecording) {
diff --git a/net/tools/quic/platform/impl/quic_epoll_clock.cc b/net/tools/quic/platform/impl/quic_epoll_clock.cc
index ce484dc..c44c9dd4 100644
--- a/net/tools/quic/platform/impl/quic_epoll_clock.cc
+++ b/net/tools/quic/platform/impl/quic_epoll_clock.cc
@@ -11,7 +11,7 @@
QuicEpollClock::QuicEpollClock(EpollServer* epoll_server)
: epoll_server_(epoll_server) {}
-QuicEpollClock::~QuicEpollClock() {}
+QuicEpollClock::~QuicEpollClock() = default;
QuicTime QuicEpollClock::ApproximateNow() const {
return QuicTime::Zero() + QuicTime::Delta::FromMicroseconds(
diff --git a/net/tools/quic/quic_client.cc b/net/tools/quic/quic_client.cc
index aacb3f0..ee4e584 100644
--- a/net/tools/quic/quic_client.cc
+++ b/net/tools/quic/quic_client.cc
@@ -83,7 +83,7 @@
set_server_address(server_address);
}
-QuicClient::~QuicClient() {}
+QuicClient::~QuicClient() = default;
QuicClientEpollNetworkHelper* QuicClient::epoll_network_helper() {
return static_cast<QuicClientEpollNetworkHelper*>(network_helper());
diff --git a/net/tools/quic/quic_client_base.cc b/net/tools/quic/quic_client_base.cc
index f664ef9d..0ef9999 100644
--- a/net/tools/quic/quic_client_base.cc
+++ b/net/tools/quic/quic_client_base.cc
@@ -16,7 +16,7 @@
namespace net {
-QuicClientBase::NetworkHelper::~NetworkHelper() {}
+QuicClientBase::NetworkHelper::~NetworkHelper() = default;
QuicClientBase::QuicClientBase(
const QuicServerId& server_id,
@@ -41,7 +41,7 @@
connected_or_attempting_connect_(false),
network_helper_(std::move(network_helper)) {}
-QuicClientBase::~QuicClientBase() {}
+QuicClientBase::~QuicClientBase() = default;
bool QuicClientBase::Initialize() {
num_sent_client_hellos_ = 0;
diff --git a/net/tools/quic/quic_client_message_loop_network_helper.cc b/net/tools/quic/quic_client_message_loop_network_helper.cc
index 7930221..6c524fa 100644
--- a/net/tools/quic/quic_client_message_loop_network_helper.cc
+++ b/net/tools/quic/quic_client_message_loop_network_helper.cc
@@ -38,7 +38,8 @@
QuicClientBase* client)
: packet_reader_started_(false), clock_(clock), client_(client) {}
-QuicClientMessageLooplNetworkHelper::~QuicClientMessageLooplNetworkHelper() {}
+QuicClientMessageLooplNetworkHelper::~QuicClientMessageLooplNetworkHelper() =
+ default;
bool QuicClientMessageLooplNetworkHelper::CreateUDPSocketAndBind(
QuicSocketAddress server_address,
diff --git a/net/tools/quic/quic_default_packet_writer.cc b/net/tools/quic/quic_default_packet_writer.cc
index e7aa91d..34c1bab 100644
--- a/net/tools/quic/quic_default_packet_writer.cc
+++ b/net/tools/quic/quic_default_packet_writer.cc
@@ -11,7 +11,7 @@
QuicDefaultPacketWriter::QuicDefaultPacketWriter(int fd)
: fd_(fd), write_blocked_(false) {}
-QuicDefaultPacketWriter::~QuicDefaultPacketWriter() {}
+QuicDefaultPacketWriter::~QuicDefaultPacketWriter() = default;
WriteResult QuicDefaultPacketWriter::WritePacket(
const char* buffer,
diff --git a/net/tools/quic/quic_dispatcher.cc b/net/tools/quic/quic_dispatcher.cc
index caedc70..3d1188d 100644
--- a/net/tools/quic/quic_dispatcher.cc
+++ b/net/tools/quic/quic_dispatcher.cc
@@ -57,7 +57,7 @@
: send_buffer_(
allocator,
FLAGS_quic_reloadable_flag_quic_allow_multiple_acks_for_data2) {}
- ~PacketCollector() override {}
+ ~PacketCollector() override = default;
// QuicPacketCreator::DelegateInterface methods:
void OnSerializedPacket(SerializedPacket* serialized_packet) override {
diff --git a/net/tools/quic/quic_dispatcher_test.cc b/net/tools/quic/quic_dispatcher_test.cc
index 7fd76f7..9fb6b3c 100644
--- a/net/tools/quic/quic_dispatcher_test.cc
+++ b/net/tools/quic/quic_dispatcher_test.cc
@@ -198,7 +198,7 @@
.WillByDefault(Return(true));
}
- ~QuicDispatcherTest() override {}
+ ~QuicDispatcherTest() override = default;
MockQuicConnection* connection1() {
return reinterpret_cast<MockQuicConnection*>(session1_->connection());
diff --git a/net/tools/quic/quic_epoll_alarm_factory.cc b/net/tools/quic/quic_epoll_alarm_factory.cc
index 11e8190..deb95597 100644
--- a/net/tools/quic/quic_epoll_alarm_factory.cc
+++ b/net/tools/quic/quic_epoll_alarm_factory.cc
@@ -55,7 +55,7 @@
QuicEpollAlarmFactory::QuicEpollAlarmFactory(EpollServer* epoll_server)
: epoll_server_(epoll_server) {}
-QuicEpollAlarmFactory::~QuicEpollAlarmFactory() {}
+QuicEpollAlarmFactory::~QuicEpollAlarmFactory() = default;
QuicAlarm* QuicEpollAlarmFactory::CreateAlarm(QuicAlarm::Delegate* delegate) {
return new QuicEpollAlarm(epoll_server_,
diff --git a/net/tools/quic/quic_epoll_connection_helper.cc b/net/tools/quic/quic_epoll_connection_helper.cc
index d72c538..2c7f9537 100644
--- a/net/tools/quic/quic_epoll_connection_helper.cc
+++ b/net/tools/quic/quic_epoll_connection_helper.cc
@@ -19,7 +19,7 @@
random_generator_(QuicRandom::GetInstance()),
allocator_type_(type) {}
-QuicEpollConnectionHelper::~QuicEpollConnectionHelper() {}
+QuicEpollConnectionHelper::~QuicEpollConnectionHelper() = default;
const QuicClock* QuicEpollConnectionHelper::GetClock() const {
return &clock_;
diff --git a/net/tools/quic/quic_http_response_cache.cc b/net/tools/quic/quic_http_response_cache.cc
index 8ad7b7a..90c221a 100644
--- a/net/tools/quic/quic_http_response_cache.cc
+++ b/net/tools/quic/quic_http_response_cache.cc
@@ -41,13 +41,13 @@
QuicHttpResponseCache::Response::Response()
: response_type_(REGULAR_RESPONSE) {}
-QuicHttpResponseCache::Response::~Response() {}
+QuicHttpResponseCache::Response::~Response() = default;
QuicHttpResponseCache::ResourceFile::ResourceFile(
const base::FilePath& file_name)
: file_name_(file_name), file_name_string_(file_name.AsUTF8Unsafe()) {}
-QuicHttpResponseCache::ResourceFile::~ResourceFile() {}
+QuicHttpResponseCache::ResourceFile::~ResourceFile() = default;
void QuicHttpResponseCache::ResourceFile::Read() {
base::ReadFileToString(FilePath(file_name_), &file_contents_);
@@ -227,7 +227,7 @@
SpdyHeaderBlock());
}
-QuicHttpResponseCache::QuicHttpResponseCache() {}
+QuicHttpResponseCache::QuicHttpResponseCache() = default;
void QuicHttpResponseCache::InitializeFromDirectory(
const string& cache_directory) {
diff --git a/net/tools/quic/quic_packet_reader.cc b/net/tools/quic/quic_packet_reader.cc
index e4cbbf34..76de5b2 100644
--- a/net/tools/quic/quic_packet_reader.cc
+++ b/net/tools/quic/quic_packet_reader.cc
@@ -54,7 +54,7 @@
#endif
}
-QuicPacketReader::~QuicPacketReader() {}
+QuicPacketReader::~QuicPacketReader() = default;
bool QuicPacketReader::ReadAndDispatchPackets(
int fd,
diff --git a/net/tools/quic/quic_packet_writer_wrapper.cc b/net/tools/quic/quic_packet_writer_wrapper.cc
index 1104e69..42f7d0a 100644
--- a/net/tools/quic/quic_packet_writer_wrapper.cc
+++ b/net/tools/quic/quic_packet_writer_wrapper.cc
@@ -8,9 +8,9 @@
namespace net {
-QuicPacketWriterWrapper::QuicPacketWriterWrapper() {}
+QuicPacketWriterWrapper::QuicPacketWriterWrapper() = default;
-QuicPacketWriterWrapper::~QuicPacketWriterWrapper() {}
+QuicPacketWriterWrapper::~QuicPacketWriterWrapper() = default;
WriteResult QuicPacketWriterWrapper::WritePacket(
const char* buffer,
diff --git a/net/tools/quic/quic_per_connection_packet_writer.cc b/net/tools/quic/quic_per_connection_packet_writer.cc
index 0d98cc8..c9d3b514 100644
--- a/net/tools/quic/quic_per_connection_packet_writer.cc
+++ b/net/tools/quic/quic_per_connection_packet_writer.cc
@@ -10,7 +10,7 @@
QuicPacketWriter* shared_writer)
: shared_writer_(shared_writer) {}
-QuicPerConnectionPacketWriter::~QuicPerConnectionPacketWriter() {}
+QuicPerConnectionPacketWriter::~QuicPerConnectionPacketWriter() = default;
WriteResult QuicPerConnectionPacketWriter::WritePacket(
const char* buffer,
diff --git a/net/tools/quic/quic_server.cc b/net/tools/quic/quic_server.cc
index b3d7414..bfaefc0 100644
--- a/net/tools/quic/quic_server.cc
+++ b/net/tools/quic/quic_server.cc
@@ -109,7 +109,7 @@
QuicRandom::GetInstance(), &clock, crypto_config_options_));
}
-QuicServer::~QuicServer() {}
+QuicServer::~QuicServer() = default;
bool QuicServer::CreateUDPSocketAndListen(const QuicSocketAddress& address) {
fd_ = QuicSocketUtils::CreateUDPSocket(address, &overflow_supported_);
diff --git a/net/tools/quic/quic_server_test.cc b/net/tools/quic/quic_server_test.cc
index e0da550..1c3451b 100644
--- a/net/tools/quic/quic_server_test.cc
+++ b/net/tools/quic/quic_server_test.cc
@@ -42,7 +42,7 @@
std::move(session_helper),
std::move(alarm_factory),
response_cache) {}
- ~MockQuicSimpleDispatcher() override {}
+ ~MockQuicSimpleDispatcher() override = default;
MOCK_METHOD0(OnCanWrite, void());
MOCK_CONST_METHOD0(HasPendingWrites, bool());
@@ -56,7 +56,7 @@
: QuicServer(crypto_test_utils::ProofSourceForTesting(),
&response_cache_) {}
- ~TestQuicServer() override {}
+ ~TestQuicServer() override = default;
MockQuicSimpleDispatcher* mock_dispatcher() { return mock_dispatcher_; }
diff --git a/net/tools/quic/quic_simple_crypto_server_stream_helper.cc b/net/tools/quic/quic_simple_crypto_server_stream_helper.cc
index 6f310eb..56afbf82 100644
--- a/net/tools/quic/quic_simple_crypto_server_stream_helper.cc
+++ b/net/tools/quic/quic_simple_crypto_server_stream_helper.cc
@@ -10,7 +10,8 @@
QuicRandom* random)
: random_(random) {}
-QuicSimpleCryptoServerStreamHelper::~QuicSimpleCryptoServerStreamHelper() {}
+QuicSimpleCryptoServerStreamHelper::~QuicSimpleCryptoServerStreamHelper() =
+ default;
QuicConnectionId
QuicSimpleCryptoServerStreamHelper::GenerateConnectionIdForReject(
diff --git a/net/tools/quic/quic_simple_dispatcher.cc b/net/tools/quic/quic_simple_dispatcher.cc
index 663783ad..832415c 100644
--- a/net/tools/quic/quic_simple_dispatcher.cc
+++ b/net/tools/quic/quic_simple_dispatcher.cc
@@ -24,7 +24,7 @@
std::move(alarm_factory)),
response_cache_(response_cache) {}
-QuicSimpleDispatcher::~QuicSimpleDispatcher() {}
+QuicSimpleDispatcher::~QuicSimpleDispatcher() = default;
int QuicSimpleDispatcher::GetRstErrorCount(
QuicRstStreamErrorCode error_code) const {
diff --git a/net/tools/quic/quic_simple_per_connection_packet_writer.cc b/net/tools/quic/quic_simple_per_connection_packet_writer.cc
index 4889724a..9046a9b 100644
--- a/net/tools/quic/quic_simple_per_connection_packet_writer.cc
+++ b/net/tools/quic/quic_simple_per_connection_packet_writer.cc
@@ -15,7 +15,8 @@
connection_(nullptr),
weak_factory_(this) {}
-QuicSimplePerConnectionPacketWriter::~QuicSimplePerConnectionPacketWriter() {}
+QuicSimplePerConnectionPacketWriter::~QuicSimplePerConnectionPacketWriter() =
+ default;
QuicPacketWriter* QuicSimplePerConnectionPacketWriter::shared_writer() const {
return shared_writer_;
diff --git a/net/tools/quic/quic_simple_server.cc b/net/tools/quic/quic_simple_server.cc
index 9f0f9d15..4ecbf75 100644
--- a/net/tools/quic/quic_simple_server.cc
+++ b/net/tools/quic/quic_simple_server.cc
@@ -86,7 +86,7 @@
crypto_config_options_));
}
-QuicSimpleServer::~QuicSimpleServer() {}
+QuicSimpleServer::~QuicSimpleServer() = default;
int QuicSimpleServer::Listen(const IPEndPoint& address) {
std::unique_ptr<UDPServerSocket> socket(
diff --git a/net/tools/quic/quic_simple_server_packet_writer.cc b/net/tools/quic/quic_simple_server_packet_writer.cc
index 575ceca..fa7ece1 100644
--- a/net/tools/quic/quic_simple_server_packet_writer.cc
+++ b/net/tools/quic/quic_simple_server_packet_writer.cc
@@ -23,7 +23,7 @@
write_blocked_(false),
weak_factory_(this) {}
-QuicSimpleServerPacketWriter::~QuicSimpleServerPacketWriter() {}
+QuicSimpleServerPacketWriter::~QuicSimpleServerPacketWriter() = default;
WriteResult QuicSimpleServerPacketWriter::WritePacketWithCallback(
const char* buffer,
diff --git a/net/tools/quic/quic_simple_server_session_helper.cc b/net/tools/quic/quic_simple_server_session_helper.cc
index 51a2e42..819553a 100644
--- a/net/tools/quic/quic_simple_server_session_helper.cc
+++ b/net/tools/quic/quic_simple_server_session_helper.cc
@@ -9,7 +9,7 @@
QuicSimpleServerSessionHelper::QuicSimpleServerSessionHelper(QuicRandom* random)
: random_(random) {}
-QuicSimpleServerSessionHelper::~QuicSimpleServerSessionHelper() {}
+QuicSimpleServerSessionHelper::~QuicSimpleServerSessionHelper() = default;
QuicConnectionId QuicSimpleServerSessionHelper::GenerateConnectionIdForReject(
QuicConnectionId /*connection_id*/) const {
diff --git a/net/tools/quic/quic_simple_server_session_test.cc b/net/tools/quic/quic_simple_server_session_test.cc
index de80c5e..712fff9e 100644
--- a/net/tools/quic/quic_simple_server_session_test.cc
+++ b/net/tools/quic/quic_simple_server_session_test.cc
@@ -92,7 +92,7 @@
FLAGS_quic_reloadable_flag_enable_quic_stateless_reject_support,
session,
helper) {}
- ~MockQuicCryptoServerStream() override {}
+ ~MockQuicCryptoServerStream() override = default;
MOCK_METHOD1(SendServerConfigUpdate,
void(const CachedNetworkParameters* cached_network_parameters));
diff --git a/net/tools/quic/quic_simple_server_stream.cc b/net/tools/quic/quic_simple_server_stream.cc
index d7aad712..c0ee02d 100644
--- a/net/tools/quic/quic_simple_server_stream.cc
+++ b/net/tools/quic/quic_simple_server_stream.cc
@@ -30,7 +30,7 @@
content_length_(-1),
response_cache_(response_cache) {}
-QuicSimpleServerStream::~QuicSimpleServerStream() {}
+QuicSimpleServerStream::~QuicSimpleServerStream() = default;
void QuicSimpleServerStream::OnInitialHeadersComplete(
bool fin,
diff --git a/net/tools/quic/quic_simple_server_stream_test.cc b/net/tools/quic/quic_simple_server_stream_test.cc
index 222a88b..7a1040d 100644
--- a/net/tools/quic/quic_simple_server_stream_test.cc
+++ b/net/tools/quic/quic_simple_server_stream_test.cc
@@ -43,7 +43,7 @@
QuicHttpResponseCache* response_cache)
: QuicSimpleServerStream(stream_id, session, response_cache) {}
- ~QuicSimpleServerStreamPeer() override {}
+ ~QuicSimpleServerStreamPeer() override = default;
using QuicSimpleServerStream::SendErrorResponse;
using QuicSimpleServerStream::SendResponse;
@@ -97,7 +97,7 @@
.WillByDefault(testing::Return(QuicConsumedData(0, false)));
}
- ~MockQuicSimpleServerSession() override {}
+ ~MockQuicSimpleServerSession() override = default;
MOCK_METHOD3(OnConnectionClosed,
void(QuicErrorCode error,
diff --git a/net/tools/quic/quic_spdy_client_base.cc b/net/tools/quic/quic_spdy_client_base.cc
index 7eca30d..d285648 100644
--- a/net/tools/quic/quic_spdy_client_base.cc
+++ b/net/tools/quic/quic_spdy_client_base.cc
@@ -28,7 +28,7 @@
bool fin)
: headers_(std::move(headers)), body_(body), fin_(fin) {}
-QuicSpdyClientBase::QuicDataToResend::~QuicDataToResend() {}
+QuicSpdyClientBase::QuicDataToResend::~QuicDataToResend() = default;
QuicSpdyClientBase::QuicSpdyClientBase(
const QuicServerId& server_id,
diff --git a/net/tools/quic/quic_spdy_client_session.cc b/net/tools/quic/quic_spdy_client_session.cc
index c823716..78c3880 100644
--- a/net/tools/quic/quic_spdy_client_session.cc
+++ b/net/tools/quic/quic_spdy_client_session.cc
@@ -29,7 +29,7 @@
crypto_config_(crypto_config),
respect_goaway_(true) {}
-QuicSpdyClientSession::~QuicSpdyClientSession() {}
+QuicSpdyClientSession::~QuicSpdyClientSession() = default;
void QuicSpdyClientSession::Initialize() {
crypto_stream_ = CreateQuicCryptoStream();
diff --git a/net/tools/quic/quic_spdy_client_stream.cc b/net/tools/quic/quic_spdy_client_stream.cc
index 4b76855..ac0ff0d 100644
--- a/net/tools/quic/quic_spdy_client_stream.cc
+++ b/net/tools/quic/quic_spdy_client_stream.cc
@@ -27,7 +27,7 @@
session_(session),
has_preliminary_headers_(false) {}
-QuicSpdyClientStream::~QuicSpdyClientStream() {}
+QuicSpdyClientStream::~QuicSpdyClientStream() = default;
void QuicSpdyClientStream::OnInitialHeadersComplete(
bool fin,
diff --git a/net/tools/quic/quic_spdy_client_stream_test.cc b/net/tools/quic/quic_spdy_client_stream_test.cc
index c2e41176e..361f87e 100644
--- a/net/tools/quic/quic_spdy_client_stream_test.cc
+++ b/net/tools/quic/quic_spdy_client_stream_test.cc
@@ -39,7 +39,7 @@
&crypto_config_,
push_promise_index),
crypto_config_(crypto_test_utils::ProofVerifierForTesting()) {}
- ~MockQuicSpdyClientSession() override {}
+ ~MockQuicSpdyClientSession() override = default;
MOCK_METHOD1(CloseStream, void(QuicStreamId stream_id));
diff --git a/net/tools/quic/quic_time_wait_list_manager.cc b/net/tools/quic/quic_time_wait_list_manager.cc
index f52f66f..9f54816 100644
--- a/net/tools/quic/quic_time_wait_list_manager.cc
+++ b/net/tools/quic/quic_time_wait_list_manager.cc
@@ -319,6 +319,6 @@
QuicTimeWaitListManager::ConnectionIdData::ConnectionIdData(
ConnectionIdData&& other) = default;
-QuicTimeWaitListManager::ConnectionIdData::~ConnectionIdData() {}
+QuicTimeWaitListManager::ConnectionIdData::~ConnectionIdData() = default;
} // namespace net
diff --git a/net/tools/quic/quic_time_wait_list_manager_test.cc b/net/tools/quic/quic_time_wait_list_manager_test.cc
index e5d2185b..a157676 100644
--- a/net/tools/quic/quic_time_wait_list_manager_test.cc
+++ b/net/tools/quic/quic_time_wait_list_manager_test.cc
@@ -44,8 +44,8 @@
class FramerVisitorCapturingPublicReset : public NoOpFramerVisitor {
public:
- FramerVisitorCapturingPublicReset() {}
- ~FramerVisitorCapturingPublicReset() override {}
+ FramerVisitorCapturingPublicReset() = default;
+ ~FramerVisitorCapturingPublicReset() override = default;
void OnPublicResetPacket(const QuicPublicResetPacket& public_reset) override {
public_reset_packet_ = public_reset;
@@ -77,7 +77,7 @@
client_address_(net::test::TestPeerIPAddress(), kTestPort),
writer_is_blocked_(false) {}
- ~QuicTimeWaitListManagerTest() override {}
+ ~QuicTimeWaitListManagerTest() override = default;
void SetUp() override {
EXPECT_CALL(writer_, IsWriteBlocked())
diff --git a/net/tools/quic/stateless_rejector.cc b/net/tools/quic/stateless_rejector.cc
index c2ded3b..668065c 100644
--- a/net/tools/quic/stateless_rejector.cc
+++ b/net/tools/quic/stateless_rejector.cc
@@ -18,7 +18,7 @@
std::unique_ptr<StatelessRejector::ProcessDoneCallback> cb)
: rejector_(std::move(rejector)), cb_(std::move(cb)) {}
- ~ValidateCallback() override {}
+ ~ValidateCallback() override = default;
void Run(QuicReferenceCountedPointer<Result> result,
std::unique_ptr<ProofSource::Details> /* proof_source_details */)
@@ -58,7 +58,7 @@
signed_config_(new QuicSignedServerConfig),
params_(new QuicCryptoNegotiatedParameters) {}
-StatelessRejector::~StatelessRejector() {}
+StatelessRejector::~StatelessRejector() = default;
void StatelessRejector::OnChlo(QuicTransportVersion version,
QuicConnectionId connection_id,
diff --git a/net/tools/quic/synchronous_host_resolver.cc b/net/tools/quic/synchronous_host_resolver.cc
index 165fafe..e9423a2 100644
--- a/net/tools/quic/synchronous_host_resolver.cc
+++ b/net/tools/quic/synchronous_host_resolver.cc
@@ -53,7 +53,7 @@
rv_(ERR_UNEXPECTED),
weak_factory_(this) {}
-ResolverThread::~ResolverThread() {}
+ResolverThread::~ResolverThread() = default;
void ResolverThread::Run() {
base::MessageLoopForIO loop;
diff --git a/net/tools/quic/test_tools/limited_mtu_test_writer.cc b/net/tools/quic/test_tools/limited_mtu_test_writer.cc
index 3d2ee877..f37ace7 100644
--- a/net/tools/quic/test_tools/limited_mtu_test_writer.cc
+++ b/net/tools/quic/test_tools/limited_mtu_test_writer.cc
@@ -9,7 +9,7 @@
LimitedMtuTestWriter::LimitedMtuTestWriter(QuicByteCount mtu) : mtu_(mtu) {}
-LimitedMtuTestWriter::~LimitedMtuTestWriter() {}
+LimitedMtuTestWriter::~LimitedMtuTestWriter() = default;
WriteResult LimitedMtuTestWriter::WritePacket(
const char* buffer,
diff --git a/net/tools/quic/test_tools/mock_epoll_server.cc b/net/tools/quic/test_tools/mock_epoll_server.cc
index 11b6ada7..ffca8d98 100644
--- a/net/tools/quic/test_tools/mock_epoll_server.cc
+++ b/net/tools/quic/test_tools/mock_epoll_server.cc
@@ -9,7 +9,7 @@
FakeTimeEpollServer::FakeTimeEpollServer() : now_in_usec_(0) {}
-FakeTimeEpollServer::~FakeTimeEpollServer() {}
+FakeTimeEpollServer::~FakeTimeEpollServer() = default;
int64_t FakeTimeEpollServer::NowInUsec() const {
return now_in_usec_;
@@ -17,7 +17,7 @@
MockEpollServer::MockEpollServer() : until_in_usec_(-1) {}
-MockEpollServer::~MockEpollServer() {}
+MockEpollServer::~MockEpollServer() = default;
int MockEpollServer::epoll_wait_impl(int epfd,
struct epoll_event* events,
diff --git a/net/tools/quic/test_tools/mock_quic_session_visitor.cc b/net/tools/quic/test_tools/mock_quic_session_visitor.cc
index ea52f14e..8bca2752 100644
--- a/net/tools/quic/test_tools/mock_quic_session_visitor.cc
+++ b/net/tools/quic/test_tools/mock_quic_session_visitor.cc
@@ -7,13 +7,13 @@
namespace net {
namespace test {
-MockQuicSessionVisitor::MockQuicSessionVisitor() {}
+MockQuicSessionVisitor::MockQuicSessionVisitor() = default;
-MockQuicSessionVisitor::~MockQuicSessionVisitor() {}
+MockQuicSessionVisitor::~MockQuicSessionVisitor() = default;
-MockQuicCryptoServerStreamHelper::MockQuicCryptoServerStreamHelper() {}
+MockQuicCryptoServerStreamHelper::MockQuicCryptoServerStreamHelper() = default;
-MockQuicCryptoServerStreamHelper::~MockQuicCryptoServerStreamHelper() {}
+MockQuicCryptoServerStreamHelper::~MockQuicCryptoServerStreamHelper() = default;
} // namespace test
} // namespace net
diff --git a/net/tools/quic/test_tools/mock_quic_time_wait_list_manager.cc b/net/tools/quic/test_tools/mock_quic_time_wait_list_manager.cc
index a3de570..33907839 100644
--- a/net/tools/quic/test_tools/mock_quic_time_wait_list_manager.cc
+++ b/net/tools/quic/test_tools/mock_quic_time_wait_list_manager.cc
@@ -26,7 +26,7 @@
QuicTimeWaitListManager_AddConnectionIdToTimeWait));
}
-MockTimeWaitListManager::~MockTimeWaitListManager() {}
+MockTimeWaitListManager::~MockTimeWaitListManager() = default;
} // namespace test
} // namespace net
diff --git a/net/tools/quic/test_tools/packet_dropping_test_writer.cc b/net/tools/quic/test_tools/packet_dropping_test_writer.cc
index 3de6dba..815000d90 100644
--- a/net/tools/quic/test_tools/packet_dropping_test_writer.cc
+++ b/net/tools/quic/test_tools/packet_dropping_test_writer.cc
@@ -64,7 +64,7 @@
simple_random_.set_seed(seed);
}
-PacketDroppingTestWriter::~PacketDroppingTestWriter() {}
+PacketDroppingTestWriter::~PacketDroppingTestWriter() = default;
void PacketDroppingTestWriter::Initialize(QuicConnectionHelperInterface* helper,
QuicAlarmFactory* alarm_factory,
@@ -241,7 +241,7 @@
// PacketDroppingTestWriter::DelayedWrite::operator=(
// PacketDroppingTestWriter::DelayedWrite&& other) = default;
-PacketDroppingTestWriter::DelayedWrite::~DelayedWrite() {}
+PacketDroppingTestWriter::DelayedWrite::~DelayedWrite() = default;
} // namespace test
} // namespace net
diff --git a/net/tools/quic/test_tools/packet_reordering_writer.cc b/net/tools/quic/test_tools/packet_reordering_writer.cc
index a5262847..99c965f 100644
--- a/net/tools/quic/test_tools/packet_reordering_writer.cc
+++ b/net/tools/quic/test_tools/packet_reordering_writer.cc
@@ -7,9 +7,9 @@
namespace net {
namespace test {
-PacketReorderingWriter::PacketReorderingWriter() {}
+PacketReorderingWriter::PacketReorderingWriter() = default;
-PacketReorderingWriter::~PacketReorderingWriter() {}
+PacketReorderingWriter::~PacketReorderingWriter() = default;
WriteResult PacketReorderingWriter::WritePacket(
const char* buffer,
diff --git a/net/tools/quic/test_tools/quic_test_client.cc b/net/tools/quic/test_tools/quic_test_client.cc
index c6320242..83ed299 100644
--- a/net/tools/quic/test_tools/quic_test_client.cc
+++ b/net/tools/quic/test_tools/quic_test_client.cc
@@ -114,7 +114,7 @@
: public QuicClientEpollNetworkHelper {
public:
using QuicClientEpollNetworkHelper::QuicClientEpollNetworkHelper;
- ~MockableQuicClientEpollNetworkHelper() override {}
+ ~MockableQuicClientEpollNetworkHelper() override = default;
void ProcessPacket(const QuicSocketAddress& self_address,
const QuicSocketAddress& peer_address,
@@ -289,7 +289,7 @@
Initialize();
}
-QuicTestClient::QuicTestClient() {}
+QuicTestClient::QuicTestClient() = default;
QuicTestClient::~QuicTestClient() {
for (std::pair<QuicStreamId, QuicSpdyClientStream*> stream : open_streams_) {
@@ -760,7 +760,7 @@
test_client_(test_client),
ack_listener_(std::move(ack_listener)) {}
-QuicTestClient::TestClientDataToResend::~TestClientDataToResend() {}
+QuicTestClient::TestClientDataToResend::~TestClientDataToResend() = default;
void QuicTestClient::TestClientDataToResend::Resend() {
test_client_->GetOrCreateStreamAndSendRequest(headers_.get(), body_, fin_,
@@ -802,7 +802,7 @@
bytes_written(bytes_written),
response_body_size(response_body_size) {}
-QuicTestClient::PerStreamState::~PerStreamState() {}
+QuicTestClient::PerStreamState::~PerStreamState() = default;
bool QuicTestClient::PopulateHeaderBlockFromUrl(const string& uri,
SpdyHeaderBlock* headers) {
diff --git a/net/tools/quic/test_tools/server_thread.cc b/net/tools/quic/test_tools/server_thread.cc
index 22f52ce9..641c5fc 100644
--- a/net/tools/quic/test_tools/server_thread.cc
+++ b/net/tools/quic/test_tools/server_thread.cc
@@ -29,7 +29,7 @@
port_(0),
initialized_(false) {}
-ServerThread::~ServerThread() {}
+ServerThread::~ServerThread() = default;
void ServerThread::Initialize() {
if (initialized_) {
diff --git a/net/tools/transport_security_state_generator/bit_writer.cc b/net/tools/transport_security_state_generator/bit_writer.cc
index 82da76a..7f1b8ef 100644
--- a/net/tools/transport_security_state_generator/bit_writer.cc
+++ b/net/tools/transport_security_state_generator/bit_writer.cc
@@ -10,9 +10,9 @@
namespace transport_security_state {
-BitWriter::BitWriter() {}
+BitWriter::BitWriter() = default;
-BitWriter::~BitWriter() {}
+BitWriter::~BitWriter() = default;
void BitWriter::WriteBits(uint32_t bits, uint8_t number_of_bits) {
DCHECK(number_of_bits <= 32);
diff --git a/net/tools/transport_security_state_generator/huffman/huffman_builder.cc b/net/tools/transport_security_state_generator/huffman/huffman_builder.cc
index c185c9d..ac625fd 100644
--- a/net/tools/transport_security_state_generator/huffman/huffman_builder.cc
+++ b/net/tools/transport_security_state_generator/huffman/huffman_builder.cc
@@ -24,7 +24,7 @@
count_(count),
left_(std::move(left)),
right_(std::move(right)) {}
- ~HuffmanNode() {}
+ ~HuffmanNode() = default;
bool IsLeaf() const {
return left_.get() == nullptr && right_.get() == nullptr;
@@ -49,9 +49,9 @@
} // namespace
-HuffmanBuilder::HuffmanBuilder() {}
+HuffmanBuilder::HuffmanBuilder() = default;
-HuffmanBuilder::~HuffmanBuilder() {}
+HuffmanBuilder::~HuffmanBuilder() = default;
void HuffmanBuilder::RecordUsage(uint8_t character) {
DCHECK(character < 128);
diff --git a/net/tools/transport_security_state_generator/pinset.cc b/net/tools/transport_security_state_generator/pinset.cc
index 03c2d9e4..dffd86c 100644
--- a/net/tools/transport_security_state_generator/pinset.cc
+++ b/net/tools/transport_security_state_generator/pinset.cc
@@ -11,7 +11,7 @@
Pinset::Pinset(std::string name, std::string report_uri)
: name_(name), report_uri_(report_uri) {}
-Pinset::~Pinset() {}
+Pinset::~Pinset() = default;
void Pinset::AddStaticSPKIHash(const std::string& hash_name) {
static_spki_hashes_.push_back(hash_name);
diff --git a/net/tools/transport_security_state_generator/pinsets.cc b/net/tools/transport_security_state_generator/pinsets.cc
index a9e7446a..5bf81f2 100644
--- a/net/tools/transport_security_state_generator/pinsets.cc
+++ b/net/tools/transport_security_state_generator/pinsets.cc
@@ -10,9 +10,9 @@
namespace transport_security_state {
-Pinsets::Pinsets() {}
+Pinsets::Pinsets() = default;
-Pinsets::~Pinsets() {}
+Pinsets::~Pinsets() = default;
void Pinsets::RegisterSPKIHash(base::StringPiece name, const SPKIHash& hash) {
spki_hashes_.insert(std::pair<std::string, SPKIHash>(name.as_string(), hash));
diff --git a/net/tools/transport_security_state_generator/preloaded_state_generator.cc b/net/tools/transport_security_state_generator/preloaded_state_generator.cc
index a7f6db0..976cb071 100644
--- a/net/tools/transport_security_state_generator/preloaded_state_generator.cc
+++ b/net/tools/transport_security_state_generator/preloaded_state_generator.cc
@@ -124,9 +124,9 @@
} // namespace
-PreloadedStateGenerator::PreloadedStateGenerator() {}
+PreloadedStateGenerator::PreloadedStateGenerator() = default;
-PreloadedStateGenerator::~PreloadedStateGenerator() {}
+PreloadedStateGenerator::~PreloadedStateGenerator() = default;
std::string PreloadedStateGenerator::Generate(
const std::string& preload_template,
diff --git a/net/tools/transport_security_state_generator/spki_hash.cc b/net/tools/transport_security_state_generator/spki_hash.cc
index e7914c3..1fcc61e 100644
--- a/net/tools/transport_security_state_generator/spki_hash.cc
+++ b/net/tools/transport_security_state_generator/spki_hash.cc
@@ -15,9 +15,9 @@
namespace transport_security_state {
-SPKIHash::SPKIHash() {}
+SPKIHash::SPKIHash() = default;
-SPKIHash::~SPKIHash() {}
+SPKIHash::~SPKIHash() = default;
bool SPKIHash::FromString(base::StringPiece hash_string) {
base::StringPiece base64_string;
diff --git a/net/tools/transport_security_state_generator/transport_security_state_entry.cc b/net/tools/transport_security_state_generator/transport_security_state_entry.cc
index 0a56beef..ac1c9db 100644
--- a/net/tools/transport_security_state_generator/transport_security_state_entry.cc
+++ b/net/tools/transport_security_state_generator/transport_security_state_entry.cc
@@ -8,8 +8,8 @@
namespace transport_security_state {
-TransportSecurityStateEntry::TransportSecurityStateEntry() {}
-TransportSecurityStateEntry::~TransportSecurityStateEntry() {}
+TransportSecurityStateEntry::TransportSecurityStateEntry() = default;
+TransportSecurityStateEntry::~TransportSecurityStateEntry() = default;
} // namespace transport_security_state
diff --git a/net/tools/transport_security_state_generator/trie/trie_bit_buffer.cc b/net/tools/transport_security_state_generator/trie/trie_bit_buffer.cc
index 5add4ea..654efc77 100644
--- a/net/tools/transport_security_state_generator/trie/trie_bit_buffer.cc
+++ b/net/tools/transport_security_state_generator/trie/trie_bit_buffer.cc
@@ -11,9 +11,9 @@
namespace transport_security_state {
-TrieBitBuffer::TrieBitBuffer() {}
+TrieBitBuffer::TrieBitBuffer() = default;
-TrieBitBuffer::~TrieBitBuffer() {}
+TrieBitBuffer::~TrieBitBuffer() = default;
void TrieBitBuffer::WriteBit(uint8_t bit) {
current_byte_ |= bit << (7 - used_);
diff --git a/net/tools/transport_security_state_generator/trie/trie_writer.cc b/net/tools/transport_security_state_generator/trie/trie_writer.cc
index 0f92d5b..5d83d8f 100644
--- a/net/tools/transport_security_state_generator/trie/trie_writer.cc
+++ b/net/tools/transport_security_state_generator/trie/trie_writer.cc
@@ -34,7 +34,7 @@
const TransportSecurityStateEntry* entry)
: reversed_name(reversed_name), entry(entry) {}
-ReversedEntry::~ReversedEntry() {}
+ReversedEntry::~ReversedEntry() = default;
TrieWriter::TrieWriter(const HuffmanRepresentationTable& huffman_table,
const NameIDMap& expect_ct_report_uri_map,
@@ -47,7 +47,7 @@
pinsets_map_(pinsets_map),
huffman_builder_(huffman_builder) {}
-TrieWriter::~TrieWriter() {}
+TrieWriter::~TrieWriter() = default;
bool TrieWriter::WriteEntries(const TransportSecurityStateEntries& entries,
uint32_t* root_position) {
diff --git a/net/url_request/data_protocol_handler.cc b/net/url_request/data_protocol_handler.cc
index c6d9716..3f4d318e 100644
--- a/net/url_request/data_protocol_handler.cc
+++ b/net/url_request/data_protocol_handler.cc
@@ -8,8 +8,7 @@
namespace net {
-DataProtocolHandler::DataProtocolHandler() {
-}
+DataProtocolHandler::DataProtocolHandler() = default;
URLRequestJob* DataProtocolHandler::MaybeCreateJob(
URLRequest* request, NetworkDelegate* network_delegate) const {
diff --git a/net/url_request/file_protocol_handler.cc b/net/url_request/file_protocol_handler.cc
index ff19d16ee..eb15fa2 100644
--- a/net/url_request/file_protocol_handler.cc
+++ b/net/url_request/file_protocol_handler.cc
@@ -19,7 +19,7 @@
const scoped_refptr<base::TaskRunner>& file_task_runner)
: file_task_runner_(file_task_runner) {}
-FileProtocolHandler::~FileProtocolHandler() {}
+FileProtocolHandler::~FileProtocolHandler() = default;
URLRequestJob* FileProtocolHandler::MaybeCreateJob(
URLRequest* request, NetworkDelegate* network_delegate) const {
diff --git a/net/url_request/ftp_protocol_handler.cc b/net/url_request/ftp_protocol_handler.cc
index 5a71ecb..f8b4b56 100644
--- a/net/url_request/ftp_protocol_handler.cc
+++ b/net/url_request/ftp_protocol_handler.cc
@@ -29,8 +29,7 @@
new FtpProtocolHandler(std::move(ftp_transaction_factory)));
}
-FtpProtocolHandler::~FtpProtocolHandler() {
-}
+FtpProtocolHandler::~FtpProtocolHandler() = default;
URLRequestJob* FtpProtocolHandler::MaybeCreateJob(
URLRequest* request, NetworkDelegate* network_delegate) const {
diff --git a/net/url_request/network_error_logging_delegate.cc b/net/url_request/network_error_logging_delegate.cc
index 365e759..c9d773a 100644
--- a/net/url_request/network_error_logging_delegate.cc
+++ b/net/url_request/network_error_logging_delegate.cc
@@ -6,22 +6,15 @@
namespace net {
-NetworkErrorLoggingDelegate::ErrorDetails::ErrorDetails() {}
+NetworkErrorLoggingDelegate::ErrorDetails::ErrorDetails() = default;
NetworkErrorLoggingDelegate::ErrorDetails::ErrorDetails(
- const ErrorDetails& other)
- : uri(other.uri),
- referrer(other.referrer),
- server_ip(other.server_ip),
- protocol(other.protocol),
- status_code(other.status_code),
- elapsed_time(other.elapsed_time),
- type(other.type) {}
+ const ErrorDetails& other) = default;
-NetworkErrorLoggingDelegate::ErrorDetails::~ErrorDetails() {}
+NetworkErrorLoggingDelegate::ErrorDetails::~ErrorDetails() = default;
const char NetworkErrorLoggingDelegate::kHeaderName[] = "NEL";
-NetworkErrorLoggingDelegate::~NetworkErrorLoggingDelegate() {}
+NetworkErrorLoggingDelegate::~NetworkErrorLoggingDelegate() = default;
} // namespace net
diff --git a/net/url_request/redirect_info.cc b/net/url_request/redirect_info.cc
index 3df301e..ef4cc2a 100644
--- a/net/url_request/redirect_info.cc
+++ b/net/url_request/redirect_info.cc
@@ -111,7 +111,7 @@
RedirectInfo::RedirectInfo(const RedirectInfo& other) = default;
-RedirectInfo::~RedirectInfo() {}
+RedirectInfo::~RedirectInfo() = default;
RedirectInfo RedirectInfo::ComputeRedirectInfo(
const std::string& original_method,
diff --git a/net/url_request/report_sender.cc b/net/url_request/report_sender.cc
index f41347b..63fc6e3 100644
--- a/net/url_request/report_sender.cc
+++ b/net/url_request/report_sender.cc
@@ -23,7 +23,7 @@
const net::ReportSender::ErrorCallback& error_callback)
: success_callback_(success_callback), error_callback_(error_callback) {}
- ~CallbackInfo() override {}
+ ~CallbackInfo() override = default;
const net::ReportSender::SuccessCallback& success_callback() const {
return success_callback_;
@@ -45,8 +45,7 @@
: request_context_(request_context),
traffic_annotation_(traffic_annotation) {}
-ReportSender::~ReportSender() {
-}
+ReportSender::~ReportSender() = default;
void ReportSender::Send(const GURL& report_uri,
base::StringPiece content_type,
diff --git a/net/url_request/report_sender_unittest.cc b/net/url_request/report_sender_unittest.cc
index c12720b..abf3f5a 100644
--- a/net/url_request/report_sender_unittest.cc
+++ b/net/url_request/report_sender_unittest.cc
@@ -82,7 +82,7 @@
public:
MockServerErrorJob(URLRequest* request, NetworkDelegate* network_delegate)
: URLRequestJob(request, network_delegate) {}
- ~MockServerErrorJob() override {}
+ ~MockServerErrorJob() override = default;
protected:
void GetResponseInfo(HttpResponseInfo* info) override {
@@ -99,8 +99,8 @@
class MockServerErrorJobInterceptor : public URLRequestInterceptor {
public:
- MockServerErrorJobInterceptor() {}
- ~MockServerErrorJobInterceptor() override {}
+ MockServerErrorJobInterceptor() = default;
+ ~MockServerErrorJobInterceptor() override = default;
URLRequestJob* MaybeInterceptRequest(
URLRequest* request,
diff --git a/net/url_request/static_http_user_agent_settings.cc b/net/url_request/static_http_user_agent_settings.cc
index 84f82c4..7cc1847 100644
--- a/net/url_request/static_http_user_agent_settings.cc
+++ b/net/url_request/static_http_user_agent_settings.cc
@@ -13,8 +13,7 @@
user_agent_(user_agent) {
}
-StaticHttpUserAgentSettings::~StaticHttpUserAgentSettings() {
-}
+StaticHttpUserAgentSettings::~StaticHttpUserAgentSettings() = default;
std::string StaticHttpUserAgentSettings::GetAcceptLanguage() const {
return accept_language_;
diff --git a/net/url_request/test_url_fetcher_factory.cc b/net/url_request/test_url_fetcher_factory.cc
index 8191bfb..04027fca 100644
--- a/net/url_request/test_url_fetcher_factory.cc
+++ b/net/url_request/test_url_fetcher_factory.cc
@@ -332,7 +332,7 @@
remove_fetcher_on_delete_(false) {
}
-TestURLFetcherFactory::~TestURLFetcherFactory() {}
+TestURLFetcherFactory::~TestURLFetcherFactory() = default;
std::unique_ptr<URLFetcher> TestURLFetcherFactory::CreateURLFetcher(
int id,
@@ -392,7 +392,7 @@
response_bytes_ = response_data.size();
}
-FakeURLFetcher::~FakeURLFetcher() {}
+FakeURLFetcher::~FakeURLFetcher() = default;
void FakeURLFetcher::Start() {
TestURLFetcher::Start();
@@ -442,7 +442,7 @@
new FakeURLFetcher(url, delegate, response_data, response_code, status));
}
-FakeURLFetcherFactory::~FakeURLFetcherFactory() {}
+FakeURLFetcherFactory::~FakeURLFetcherFactory() = default;
std::unique_ptr<URLFetcher> FakeURLFetcherFactory::CreateURLFetcher(
int id,
@@ -485,9 +485,9 @@
fake_responses_.clear();
}
-URLFetcherImplFactory::URLFetcherImplFactory() {}
+URLFetcherImplFactory::URLFetcherImplFactory() = default;
-URLFetcherImplFactory::~URLFetcherImplFactory() {}
+URLFetcherImplFactory::~URLFetcherImplFactory() = default;
std::unique_ptr<URLFetcher> URLFetcherImplFactory::CreateURLFetcher(
int id,
diff --git a/net/url_request/test_url_request_interceptor.cc b/net/url_request/test_url_request_interceptor.cc
index 063a4b5..56b8d66 100644
--- a/net/url_request/test_url_request_interceptor.cc
+++ b/net/url_request/test_url_request_interceptor.cc
@@ -38,7 +38,7 @@
}
private:
- ~TestURLRequestJob() override {}
+ ~TestURLRequestJob() override = default;
DISALLOW_COPY_AND_ASSIGN(TestURLRequestJob);
};
@@ -59,7 +59,7 @@
network_task_runner_(network_task_runner),
worker_task_runner_(worker_task_runner),
hit_count_(0) {}
- ~Delegate() override {}
+ ~Delegate() override = default;
void Register() {
URLRequestFilter::GetInstance()->AddHostnameInterceptor(
diff --git a/net/url_request/url_fetcher.cc b/net/url_request/url_fetcher.cc
index 52d67c8c..e815b57 100644
--- a/net/url_request/url_fetcher.cc
+++ b/net/url_request/url_fetcher.cc
@@ -9,7 +9,7 @@
namespace net {
-URLFetcher::~URLFetcher() {}
+URLFetcher::~URLFetcher() = default;
// static
std::unique_ptr<URLFetcher> URLFetcher::Create(
diff --git a/net/url_request/url_fetcher_core.cc b/net/url_request/url_fetcher_core.cc
index e55d11b..e8254a9 100644
--- a/net/url_request/url_fetcher_core.cc
+++ b/net/url_request/url_fetcher_core.cc
@@ -44,8 +44,8 @@
// URLFetcherCore::Registry ---------------------------------------------------
-URLFetcherCore::Registry::Registry() {}
-URLFetcherCore::Registry::~Registry() {}
+URLFetcherCore::Registry::Registry() = default;
+URLFetcherCore::Registry::~Registry() = default;
void URLFetcherCore::Registry::AddURLFetcherCore(URLFetcherCore* core) {
DCHECK(!base::ContainsKey(fetchers_, core));
diff --git a/net/url_request/url_fetcher_delegate.cc b/net/url_request/url_fetcher_delegate.cc
index 18b9ab1..359b8172 100644
--- a/net/url_request/url_fetcher_delegate.cc
+++ b/net/url_request/url_fetcher_delegate.cc
@@ -16,6 +16,6 @@
int64_t current,
int64_t total) {}
-URLFetcherDelegate::~URLFetcherDelegate() {}
+URLFetcherDelegate::~URLFetcherDelegate() = default;
} // namespace net
diff --git a/net/url_request/url_fetcher_impl_unittest.cc b/net/url_request/url_fetcher_impl_unittest.cc
index ea72642..080d1101 100644
--- a/net/url_request/url_fetcher_impl_unittest.cc
+++ b/net/url_request/url_fetcher_impl_unittest.cc
@@ -488,7 +488,7 @@
// Version of URLFetcherTest that tests bad HTTPS requests.
class URLFetcherBadHTTPSTest : public URLFetcherTest {
public:
- URLFetcherBadHTTPSTest() {}
+ URLFetcherBadHTTPSTest() = default;
// URLFetcherTest:
void SetUpServer() override {
@@ -933,7 +933,7 @@
public:
CheckUploadProgressDelegate()
: chunk_(1 << 16, 'a'), num_chunks_appended_(0), last_seen_progress_(0) {}
- ~CheckUploadProgressDelegate() override {}
+ ~CheckUploadProgressDelegate() override = default;
void OnURLFetchUploadProgress(const URLFetcher* source,
int64_t current,
@@ -1000,7 +1000,7 @@
public:
CheckDownloadProgressDelegate(int64_t file_size)
: file_size_(file_size), last_seen_progress_(0) {}
- ~CheckDownloadProgressDelegate() override {}
+ ~CheckDownloadProgressDelegate() override = default;
void OnURLFetchDownloadProgress(const URLFetcher* source,
int64_t current,
@@ -1050,8 +1050,8 @@
class CancelOnUploadProgressDelegate : public WaitingURLFetcherDelegate {
public:
- CancelOnUploadProgressDelegate() {}
- ~CancelOnUploadProgressDelegate() override {}
+ CancelOnUploadProgressDelegate() = default;
+ ~CancelOnUploadProgressDelegate() override = default;
void OnURLFetchUploadProgress(const URLFetcher* source,
int64_t current,
@@ -1087,8 +1087,8 @@
class CancelOnDownloadProgressDelegate : public WaitingURLFetcherDelegate {
public:
- CancelOnDownloadProgressDelegate() {}
- ~CancelOnDownloadProgressDelegate() override {}
+ CancelOnDownloadProgressDelegate() = default;
+ ~CancelOnDownloadProgressDelegate() override = default;
void OnURLFetchDownloadProgress(const URLFetcher* source,
int64_t current,
@@ -1402,7 +1402,7 @@
: first_request_complete_(false),
second_request_context_getter_(second_request_context_getter) {}
- ~ReuseFetcherDelegate() override {}
+ ~ReuseFetcherDelegate() override = default;
void OnURLFetchComplete(const URLFetcher* source) override {
EXPECT_EQ(fetcher(), source);
diff --git a/net/url_request/url_fetcher_response_writer.cc b/net/url_request/url_fetcher_response_writer.cc
index 3286e675..de0edd5 100644
--- a/net/url_request/url_fetcher_response_writer.cc
+++ b/net/url_request/url_fetcher_response_writer.cc
@@ -23,11 +23,9 @@
return NULL;
}
-URLFetcherStringWriter::URLFetcherStringWriter() {
-}
+URLFetcherStringWriter::URLFetcherStringWriter() = default;
-URLFetcherStringWriter::~URLFetcherStringWriter() {
-}
+URLFetcherStringWriter::~URLFetcherStringWriter() = default;
int URLFetcherStringWriter::Initialize(const CompletionCallback& callback) {
data_.clear();
diff --git a/net/url_request/url_range_request_job.cc b/net/url_request/url_range_request_job.cc
index cad7b836..68cf156 100644
--- a/net/url_request/url_range_request_job.cc
+++ b/net/url_request/url_range_request_job.cc
@@ -15,8 +15,7 @@
: URLRequestJob(request, delegate), range_parse_result_(OK) {
}
-URLRangeRequestJob::~URLRangeRequestJob() {
-}
+URLRangeRequestJob::~URLRangeRequestJob() = default;
void URLRangeRequestJob::SetExtraRequestHeaders(
const HttpRequestHeaders& headers) {
diff --git a/net/url_request/url_request_context_builder.cc b/net/url_request/url_request_context_builder.cc
index fb354c3a..0d566da 100644
--- a/net/url_request/url_request_context_builder.cc
+++ b/net/url_request/url_request_context_builder.cc
@@ -71,8 +71,8 @@
class BasicNetworkDelegate : public NetworkDelegateImpl {
public:
- BasicNetworkDelegate() {}
- ~BasicNetworkDelegate() override {}
+ BasicNetworkDelegate() = default;
+ ~BasicNetworkDelegate() override = default;
private:
int OnBeforeURLRequest(URLRequest* request,
@@ -186,7 +186,7 @@
URLRequestContextBuilder::HttpCacheParams::HttpCacheParams()
: type(IN_MEMORY),
max_size(0) {}
-URLRequestContextBuilder::HttpCacheParams::~HttpCacheParams() {}
+URLRequestContextBuilder::HttpCacheParams::~HttpCacheParams() = default;
URLRequestContextBuilder::URLRequestContextBuilder()
: enable_brotli_(false),
@@ -215,7 +215,7 @@
#endif // !BUILDFLAG(ENABLE_REPORTING)
}
-URLRequestContextBuilder::~URLRequestContextBuilder() {}
+URLRequestContextBuilder::~URLRequestContextBuilder() = default;
void URLRequestContextBuilder::SetHttpNetworkSessionComponents(
const URLRequestContext* request_context,
diff --git a/net/url_request/url_request_context_builder_unittest.cc b/net/url_request/url_request_context_builder_unittest.cc
index 3987f1a..bb0e450 100644
--- a/net/url_request/url_request_context_builder_unittest.cc
+++ b/net/url_request/url_request_context_builder_unittest.cc
@@ -32,7 +32,7 @@
public:
MockHttpAuthHandlerFactory(std::string supported_scheme, int return_code)
: return_code_(return_code), supported_scheme_(supported_scheme) {}
- ~MockHttpAuthHandlerFactory() override {}
+ ~MockHttpAuthHandlerFactory() override = default;
int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge,
HttpAuth::Target target,
diff --git a/net/url_request/url_request_context_getter.cc b/net/url_request/url_request_context_getter.cc
index 0bad748..028a449 100644
--- a/net/url_request/url_request_context_getter.cc
+++ b/net/url_request/url_request_context_getter.cc
@@ -24,9 +24,9 @@
observer_list_.RemoveObserver(observer);
}
-URLRequestContextGetter::URLRequestContextGetter() {}
+URLRequestContextGetter::URLRequestContextGetter() = default;
-URLRequestContextGetter::~URLRequestContextGetter() {}
+URLRequestContextGetter::~URLRequestContextGetter() = default;
void URLRequestContextGetter::OnDestruct() const {
scoped_refptr<base::SingleThreadTaskRunner> network_task_runner =
@@ -67,7 +67,7 @@
: context_(context), main_task_runner_(main_task_runner) {
}
-TrivialURLRequestContextGetter::~TrivialURLRequestContextGetter() {}
+TrivialURLRequestContextGetter::~TrivialURLRequestContextGetter() = default;
URLRequestContext* TrivialURLRequestContextGetter::GetURLRequestContext() {
return context_;
diff --git a/net/url_request/url_request_context_storage.cc b/net/url_request/url_request_context_storage.cc
index 703bf56..b804e251 100644
--- a/net/url_request/url_request_context_storage.cc
+++ b/net/url_request/url_request_context_storage.cc
@@ -37,7 +37,7 @@
DCHECK(context);
}
-URLRequestContextStorage::~URLRequestContextStorage() {}
+URLRequestContextStorage::~URLRequestContextStorage() = default;
void URLRequestContextStorage::set_net_log(std::unique_ptr<NetLog> net_log) {
context_->set_net_log(net_log.get());
diff --git a/net/url_request/url_request_data_job.cc b/net/url_request/url_request_data_job.cc
index 56d243f..a3c7b7b 100644
--- a/net/url_request/url_request_data_job.cc
+++ b/net/url_request/url_request_data_job.cc
@@ -63,7 +63,6 @@
return BuildResponse(url, mime_type, charset, data, NULL);
}
-URLRequestDataJob::~URLRequestDataJob() {
-}
+URLRequestDataJob::~URLRequestDataJob() = default;
} // namespace net
diff --git a/net/url_request/url_request_error_job.cc b/net/url_request/url_request_error_job.cc
index 8a6b5c8..85ab61f2 100644
--- a/net/url_request/url_request_error_job.cc
+++ b/net/url_request/url_request_error_job.cc
@@ -20,7 +20,7 @@
error_(error),
weak_factory_(this) {}
-URLRequestErrorJob::~URLRequestErrorJob() {}
+URLRequestErrorJob::~URLRequestErrorJob() = default;
void URLRequestErrorJob::Start() {
base::ThreadTaskRunnerHandle::Get()->PostTask(
diff --git a/net/url_request/url_request_file_dir_job.cc b/net/url_request/url_request_file_dir_job.cc
index b34b571..1d44ad6 100644
--- a/net/url_request/url_request_file_dir_job.cc
+++ b/net/url_request/url_request_file_dir_job.cc
@@ -153,7 +153,7 @@
CompleteRead(list_complete_result_);
}
-URLRequestFileDirJob::~URLRequestFileDirJob() {}
+URLRequestFileDirJob::~URLRequestFileDirJob() = default;
void URLRequestFileDirJob::DidMakeAbsolutePath(
const base::FilePath& absolute_path) {
diff --git a/net/url_request/url_request_file_dir_job_unittest.cc b/net/url_request/url_request_file_dir_job_unittest.cc
index de0f004a..443766d 100644
--- a/net/url_request/url_request_file_dir_job_unittest.cc
+++ b/net/url_request/url_request_file_dir_job_unittest.cc
@@ -85,7 +85,7 @@
class TestJobFactory : public URLRequestJobFactory {
public:
explicit TestJobFactory(const base::FilePath& path) : path_(path) {}
- ~TestJobFactory() override {}
+ ~TestJobFactory() override = default;
URLRequestJob* MaybeCreateJobWithProtocolHandler(
const std::string& scheme,
@@ -125,9 +125,9 @@
class TestDirectoryURLRequestDelegate : public TestDelegate {
public:
- TestDirectoryURLRequestDelegate() {}
+ TestDirectoryURLRequestDelegate() = default;
- ~TestDirectoryURLRequestDelegate() override {}
+ ~TestDirectoryURLRequestDelegate() override = default;
void OnResponseStarted(URLRequest* request, int net_error) override {
got_response_started_ = true;
diff --git a/net/url_request/url_request_file_job.cc b/net/url_request/url_request_file_job.cc
index 8951925..7076a8ca 100644
--- a/net/url_request/url_request_file_job.cc
+++ b/net/url_request/url_request_file_job.cc
@@ -184,8 +184,7 @@
void URLRequestFileJob::OnReadComplete(IOBuffer* buf, int result) {
}
-URLRequestFileJob::~URLRequestFileJob() {
-}
+URLRequestFileJob::~URLRequestFileJob() = default;
std::unique_ptr<SourceStream> URLRequestFileJob::SetUpSourceStream() {
std::unique_ptr<SourceStream> source = URLRequestJob::SetUpSourceStream();
diff --git a/net/url_request/url_request_file_job_unittest.cc b/net/url_request/url_request_file_job_unittest.cc
index 7e8cddc3..6033669 100644
--- a/net/url_request/url_request_file_job_unittest.cc
+++ b/net/url_request/url_request_file_job_unittest.cc
@@ -54,7 +54,7 @@
observed_content_->clear();
}
- ~TestURLRequestFileJob() override {}
+ ~TestURLRequestFileJob() override = default;
protected:
void OnOpenComplete(int result) override {
@@ -105,7 +105,7 @@
CHECK(observed_content_);
}
- ~TestJobFactory() override {}
+ ~TestJobFactory() override = default;
URLRequestJob* MaybeCreateJobWithProtocolHandler(
const std::string& scheme,
@@ -219,7 +219,7 @@
TestDelegate delegate_;
};
-URLRequestFileJobEventsTest::URLRequestFileJobEventsTest() {}
+URLRequestFileJobEventsTest::URLRequestFileJobEventsTest() = default;
void URLRequestFileJobEventsTest::TearDown() {
// Gives a chance to close the opening file.
diff --git a/net/url_request/url_request_filter_unittest.cc b/net/url_request/url_request_filter_unittest.cc
index 9ee52df..be5e3f6 100644
--- a/net/url_request/url_request_filter_unittest.cc
+++ b/net/url_request/url_request_filter_unittest.cc
@@ -24,7 +24,7 @@
class TestURLRequestInterceptor : public URLRequestInterceptor {
public:
TestURLRequestInterceptor() : job_(nullptr) {}
- ~TestURLRequestInterceptor() override {}
+ ~TestURLRequestInterceptor() override = default;
// URLRequestInterceptor implementation:
URLRequestJob* MaybeInterceptRequest(
diff --git a/net/url_request/url_request_ftp_job.cc b/net/url_request/url_request_ftp_job.cc
index e73bac0..8037581 100644
--- a/net/url_request/url_request_ftp_job.cc
+++ b/net/url_request/url_request_ftp_job.cc
@@ -35,7 +35,7 @@
URLRequestFtpJob::AuthData::AuthData() : state(AUTH_STATE_NEED_AUTH) {}
-URLRequestFtpJob::AuthData::~AuthData() {}
+URLRequestFtpJob::AuthData::~AuthData() = default;
URLRequestFtpJob::URLRequestFtpJob(
URLRequest* request,
diff --git a/net/url_request/url_request_ftp_job_unittest.cc b/net/url_request/url_request_ftp_job_unittest.cc
index e3eb668..770c5ab 100644
--- a/net/url_request/url_request_ftp_job_unittest.cc
+++ b/net/url_request/url_request_ftp_job_unittest.cc
@@ -144,7 +144,7 @@
FtpTransactionFactory* ftp_factory,
FtpAuthCache* ftp_auth_cache)
: URLRequestFtpJob(request, NULL, ftp_factory, ftp_auth_cache) {}
- ~TestURLRequestFtpJob() override {}
+ ~TestURLRequestFtpJob() override = default;
using URLRequestFtpJob::SetPriority;
using URLRequestFtpJob::Start;
diff --git a/net/url_request/url_request_http_job_unittest.cc b/net/url_request/url_request_http_job_unittest.cc
index 577e4b1..5d5377e 100644
--- a/net/url_request/url_request_http_job_unittest.cc
+++ b/net/url_request/url_request_http_job_unittest.cc
@@ -94,7 +94,7 @@
request->context()->http_user_agent_settings()),
use_null_source_stream_(false) {}
- ~TestURLRequestHttpJob() override {}
+ ~TestURLRequestHttpJob() override = default;
// URLRequestJob implementation:
std::unique_ptr<SourceStream> SetUpSourceStream() override {
diff --git a/net/url_request/url_request_interceptor.cc b/net/url_request/url_request_interceptor.cc
index b93611b..29801d7 100644
--- a/net/url_request/url_request_interceptor.cc
+++ b/net/url_request/url_request_interceptor.cc
@@ -6,11 +6,9 @@
namespace net {
-URLRequestInterceptor::URLRequestInterceptor() {
-}
+URLRequestInterceptor::URLRequestInterceptor() = default;
-URLRequestInterceptor::~URLRequestInterceptor() {
-}
+URLRequestInterceptor::~URLRequestInterceptor() = default;
URLRequestJob* URLRequestInterceptor::MaybeInterceptRedirect(
URLRequest* request,
diff --git a/net/url_request/url_request_job.cc b/net/url_request/url_request_job.cc
index 706696d..25e971d7 100644
--- a/net/url_request/url_request_job.cc
+++ b/net/url_request/url_request_job.cc
@@ -58,7 +58,7 @@
DCHECK(job_);
}
- ~URLRequestJobSourceStream() override {}
+ ~URLRequestJobSourceStream() override = default;
// SourceStream implementation:
int Read(IOBuffer* dest_buffer,
diff --git a/net/url_request/url_request_job_factory.cc b/net/url_request/url_request_job_factory.cc
index 9895ae1c..7df9291 100644
--- a/net/url_request/url_request_job_factory.cc
+++ b/net/url_request/url_request_job_factory.cc
@@ -6,14 +6,14 @@
namespace net {
-URLRequestJobFactory::ProtocolHandler::~ProtocolHandler() {}
+URLRequestJobFactory::ProtocolHandler::~ProtocolHandler() = default;
bool URLRequestJobFactory::ProtocolHandler::IsSafeRedirectTarget(
const GURL& location) const {
return true;
}
-URLRequestJobFactory::URLRequestJobFactory() {}
+URLRequestJobFactory::URLRequestJobFactory() = default;
URLRequestJobFactory::~URLRequestJobFactory() {
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
diff --git a/net/url_request/url_request_job_factory_impl.cc b/net/url_request/url_request_job_factory_impl.cc
index 9bc8cd48..61187634 100644
--- a/net/url_request/url_request_job_factory_impl.cc
+++ b/net/url_request/url_request_job_factory_impl.cc
@@ -18,9 +18,9 @@
} // namespace
-URLRequestJobFactoryImpl::URLRequestJobFactoryImpl() {}
+URLRequestJobFactoryImpl::URLRequestJobFactoryImpl() = default;
-URLRequestJobFactoryImpl::~URLRequestJobFactoryImpl() {}
+URLRequestJobFactoryImpl::~URLRequestJobFactoryImpl() = default;
bool URLRequestJobFactoryImpl::SetProtocolHandler(
const std::string& scheme,
diff --git a/net/url_request/url_request_job_factory_impl_unittest.cc b/net/url_request/url_request_job_factory_impl_unittest.cc
index 3fc08177..0034152c 100644
--- a/net/url_request/url_request_job_factory_impl_unittest.cc
+++ b/net/url_request/url_request_job_factory_impl_unittest.cc
@@ -40,7 +40,7 @@
}
protected:
- ~MockURLRequestJob() override {}
+ ~MockURLRequestJob() override = default;
private:
void StartAsync() {
diff --git a/net/url_request/url_request_job_manager.cc b/net/url_request/url_request_job_manager.cc
index 7d630ee0..0817a12 100644
--- a/net/url_request/url_request_job_manager.cc
+++ b/net/url_request/url_request_job_manager.cc
@@ -151,9 +151,8 @@
return false;
}
-URLRequestJobManager::URLRequestJobManager() {
-}
+URLRequestJobManager::URLRequestJobManager() = default;
-URLRequestJobManager::~URLRequestJobManager() {}
+URLRequestJobManager::~URLRequestJobManager() = default;
} // namespace net
diff --git a/net/url_request/url_request_redirect_job.cc b/net/url_request/url_request_redirect_job.cc
index 3ca1ef37..a53e3dc2 100644
--- a/net/url_request/url_request_redirect_job.cc
+++ b/net/url_request/url_request_redirect_job.cc
@@ -38,7 +38,7 @@
DCHECK(!redirect_reason_.empty());
}
-URLRequestRedirectJob::~URLRequestRedirectJob() {}
+URLRequestRedirectJob::~URLRequestRedirectJob() = default;
void URLRequestRedirectJob::GetResponseInfo(HttpResponseInfo* info) {
// Should only be called after the URLRequest has been notified there's header
diff --git a/net/url_request/url_request_simple_job.cc b/net/url_request/url_request_simple_job.cc
index df8bca28..3e1dec95 100644
--- a/net/url_request/url_request_simple_job.cc
+++ b/net/url_request/url_request_simple_job.cc
@@ -62,7 +62,7 @@
return true;
}
-URLRequestSimpleJob::~URLRequestSimpleJob() {}
+URLRequestSimpleJob::~URLRequestSimpleJob() = default;
int URLRequestSimpleJob::ReadRawData(IOBuffer* buf, int buf_size) {
buf_size = std::min(static_cast<int64_t>(buf_size),
diff --git a/net/url_request/url_request_simple_job_unittest.cc b/net/url_request/url_request_simple_job_unittest.cc
index 69796e6..71ec521 100644
--- a/net/url_request/url_request_simple_job_unittest.cc
+++ b/net/url_request/url_request_simple_job_unittest.cc
@@ -60,7 +60,7 @@
}
private:
- ~MockSimpleJob() override {}
+ ~MockSimpleJob() override = default;
const std::string data_;
@@ -71,7 +71,7 @@
public:
CancelAfterFirstReadURLRequestDelegate() : run_loop_(new base::RunLoop) {}
- ~CancelAfterFirstReadURLRequestDelegate() override {}
+ ~CancelAfterFirstReadURLRequestDelegate() override = default;
void OnResponseStarted(URLRequest* request, int net_error) override {
DCHECK_NE(ERR_IO_PENDING, net_error);
@@ -101,7 +101,7 @@
return new MockSimpleJob(request, network_delegate, kTestData);
}
- ~SimpleJobProtocolHandler() override {}
+ ~SimpleJobProtocolHandler() override = default;
private:
DISALLOW_COPY_AND_ASSIGN(SimpleJobProtocolHandler);
diff --git a/net/url_request/url_request_test_util.cc b/net/url_request/url_request_test_util.cc
index 17cd976..9a34c24e 100644
--- a/net/url_request/url_request_test_util.cc
+++ b/net/url_request/url_request_test_util.cc
@@ -162,7 +162,7 @@
DCHECK(network_task_runner_.get());
}
-TestURLRequestContextGetter::~TestURLRequestContextGetter() {}
+TestURLRequestContextGetter::~TestURLRequestContextGetter() = default;
TestURLRequestContext* TestURLRequestContextGetter::GetURLRequestContext() {
if (!context_.get())
@@ -197,7 +197,7 @@
request_status_(ERR_IO_PENDING),
buf_(new IOBuffer(kBufferSize)) {}
-TestDelegate::~TestDelegate() {}
+TestDelegate::~TestDelegate() = default;
void TestDelegate::ClearFullRequestHeaders() {
full_request_headers_.Clear();
@@ -667,9 +667,9 @@
return cancel_request_with_policy_violating_referrer_;
}
-TestJobInterceptor::TestJobInterceptor() {}
+TestJobInterceptor::TestJobInterceptor() = default;
-TestJobInterceptor::~TestJobInterceptor() {}
+TestJobInterceptor::~TestJobInterceptor() = default;
URLRequestJob* TestJobInterceptor::MaybeCreateJob(
URLRequest* request,
diff --git a/net/url_request/url_request_throttler_entry.cc b/net/url_request/url_request_throttler_entry.cc
index f81e1b5..463c0ee5 100644
--- a/net/url_request/url_request_throttler_entry.cc
+++ b/net/url_request/url_request_throttler_entry.cc
@@ -236,8 +236,7 @@
}
}
-URLRequestThrottlerEntry::~URLRequestThrottlerEntry() {
-}
+URLRequestThrottlerEntry::~URLRequestThrottlerEntry() = default;
void URLRequestThrottlerEntry::Initialize() {
sliding_window_release_time_ = base::TimeTicks::Now();
diff --git a/net/url_request/url_request_throttler_simulation_unittest.cc b/net/url_request/url_request_throttler_simulation_unittest.cc
index f332084..7041118 100644
--- a/net/url_request/url_request_throttler_simulation_unittest.cc
+++ b/net/url_request/url_request_throttler_simulation_unittest.cc
@@ -70,12 +70,12 @@
public:
class Actor {
public:
- virtual ~Actor() {}
+ virtual ~Actor() = default;
virtual void AdvanceTime(const TimeTicks& absolute_time) = 0;
virtual void PerformAction() = 0;
};
- DiscreteTimeSimulation() {}
+ DiscreteTimeSimulation() = default;
// Adds an |actor| to the simulation. The client of the simulation maintains
// ownership of |actor| and must ensure its lifetime exceeds that of the
@@ -322,7 +322,7 @@
}
protected:
- ~MockURLRequestThrottlerEntry() override {}
+ ~MockURLRequestThrottlerEntry() override = default;
private:
mutable TestTickClock fake_clock_;
diff --git a/net/url_request/url_request_throttler_test_support.cc b/net/url_request/url_request_throttler_test_support.cc
index 8d10335..d1ef6ca 100644
--- a/net/url_request/url_request_throttler_test_support.cc
+++ b/net/url_request/url_request_throttler_test_support.cc
@@ -8,11 +8,11 @@
namespace net {
-TestTickClock::TestTickClock() {}
+TestTickClock::TestTickClock() = default;
TestTickClock::TestTickClock(base::TimeTicks now) : now_ticks_(now) {}
-TestTickClock::~TestTickClock() {}
+TestTickClock::~TestTickClock() = default;
base::TimeTicks TestTickClock::NowTicks() {
return now_ticks_;
diff --git a/net/url_request/url_request_throttler_unittest.cc b/net/url_request/url_request_throttler_unittest.cc
index 702c1348..c2301e51 100644
--- a/net/url_request/url_request_throttler_unittest.cc
+++ b/net/url_request/url_request_throttler_unittest.cc
@@ -92,7 +92,7 @@
}
protected:
- ~MockURLRequestThrottlerEntry() override {}
+ ~MockURLRequestThrottlerEntry() override = default;
private:
mutable TestTickClock fake_clock_;
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 07a8d4e..1aa782f 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -320,8 +320,8 @@
// the one in base/ because it insists on bringing its own MessageLoop.
class TestPowerMonitorSource : public base::PowerMonitorSource {
public:
- TestPowerMonitorSource() {}
- ~TestPowerMonitorSource() override {}
+ TestPowerMonitorSource() = default;
+ ~TestPowerMonitorSource() override = default;
void Suspend() { ProcessPowerEvent(SUSPEND_EVENT); }
@@ -736,7 +736,7 @@
set_network_delegate(delegate);
Init();
}
- ~TestURLRequestContextWithProxy() override {}
+ ~TestURLRequestContextWithProxy() override = default;
};
// A mock ReportSenderInterface that just remembers the latest report
@@ -744,8 +744,8 @@
class MockCertificateReportSender
: public TransportSecurityState::ReportSenderInterface {
public:
- MockCertificateReportSender() {}
- ~MockCertificateReportSender() override {}
+ MockCertificateReportSender() = default;
+ ~MockCertificateReportSender() override = default;
void Send(const GURL& report_uri,
base::StringPiece content_type,
@@ -880,7 +880,8 @@
// whitelisted files are allowed.
class CookieBlockingNetworkDelegate : public TestNetworkDelegate {
public:
- CookieBlockingNetworkDelegate(){};
+ CookieBlockingNetworkDelegate() = default;
+ ;
// Adds |directory| to the access white list.
void AddToWhitelist(const base::FilePath& directory) {
@@ -1499,7 +1500,7 @@
protected:
void StartAsync() override { this->NotifyRestartRequired(); }
private:
- ~RestartTestJob() override {}
+ ~RestartTestJob() override = default;
};
class CancelTestJob : public URLRequestTestJob {
@@ -1509,7 +1510,7 @@
protected:
void StartAsync() override { request_->Cancel(); }
private:
- ~CancelTestJob() override {}
+ ~CancelTestJob() override = default;
};
class CancelThenRestartTestJob : public URLRequestTestJob {
@@ -1524,7 +1525,7 @@
this->NotifyRestartRequired();
}
private:
- ~CancelThenRestartTestJob() override {}
+ ~CancelThenRestartTestJob() override = default;
};
// An Interceptor for use with interceptor tests.
@@ -1569,8 +1570,7 @@
did_intercept_final_(false), did_cancel_final_(false) {
}
- ~MockURLRequestInterceptor() override {
- }
+ ~MockURLRequestInterceptor() override = default;
// URLRequestInterceptor implementation:
URLRequestJob* MaybeInterceptRequest(
@@ -3398,7 +3398,7 @@
public:
explicit FixedDateNetworkDelegate(const std::string& fixed_date)
: fixed_date_(fixed_date) {}
- ~FixedDateNetworkDelegate() override {}
+ ~FixedDateNetworkDelegate() override = default;
// NetworkDelegate implementation
int OnHeadersReceived(
@@ -3749,7 +3749,7 @@
}
protected:
- ~TestSSLConfigService() override {}
+ ~TestSSLConfigService() override = default;
private:
const bool ev_enabled_;
@@ -5231,7 +5231,7 @@
callback_(callback) {
}
- ~AsyncDelegateLogger() {}
+ ~AsyncDelegateLogger() = default;
void Start() {
url_request_->LogBlockedBy(kFirstDelegateInfo);
@@ -5278,8 +5278,8 @@
// is requested. Uses AsyncDelegateLogger.
class AsyncLoggingNetworkDelegate : public TestNetworkDelegate {
public:
- AsyncLoggingNetworkDelegate() {}
- ~AsyncLoggingNetworkDelegate() override {}
+ AsyncLoggingNetworkDelegate() = default;
+ ~AsyncLoggingNetworkDelegate() override = default;
// NetworkDelegate implementation.
int OnBeforeURLRequest(URLRequest* request,
@@ -5371,7 +5371,7 @@
else if (cancel_stage == CANCEL_ON_READ_COMPLETED)
set_cancel_in_received_data(true);
}
- ~AsyncLoggingUrlRequestDelegate() override {}
+ ~AsyncLoggingUrlRequestDelegate() override = default;
// URLRequest::Delegate implementation:
void OnReceivedRedirect(URLRequest* request,
@@ -6783,7 +6783,7 @@
class MockExpectCTReporter : public TransportSecurityState::ExpectCTReporter {
public:
MockExpectCTReporter() : num_failures_(0) {}
- ~MockExpectCTReporter() override {}
+ ~MockExpectCTReporter() override = default;
void OnExpectCTFailed(const HostPortPair& host_port_pair,
const GURL& report_uri,
@@ -6807,7 +6807,7 @@
public:
MockCTPolicyEnforcer()
: default_result_(ct::CTPolicyCompliance::CT_POLICY_COMPLIES_VIA_SCTS) {}
- ~MockCTPolicyEnforcer() override {}
+ ~MockCTPolicyEnforcer() override = default;
ct::CTPolicyCompliance CheckCompliance(
X509Certificate* cert,
@@ -7023,7 +7023,7 @@
// ReportingService implementation:
- ~TestReportingService() override {}
+ ~TestReportingService() override = default;
void QueueReport(const GURL& url,
const std::string& group,
@@ -7155,8 +7155,8 @@
class TestNetworkErrorLoggingDelegate : public NetworkErrorLoggingDelegate {
public:
struct Header {
- Header() {}
- ~Header() {}
+ Header() = default;
+ ~Header() = default;
url::Origin origin;
std::string value;
@@ -7167,7 +7167,7 @@
// NetworkErrorLoggingDelegate implementation:
- ~TestNetworkErrorLoggingDelegate() override {}
+ ~TestNetworkErrorLoggingDelegate() override = default;
void SetReportingService(ReportingService* reporting_service) override {
NOTREACHED();
@@ -8646,7 +8646,7 @@
explicit FailingHttpTransactionFactory(HttpNetworkSession* network_session)
: network_session_(network_session) {}
- ~FailingHttpTransactionFactory() override {}
+ ~FailingHttpTransactionFactory() override = default;
// HttpTransactionFactory methods:
int CreateTransaction(RequestPriority priority,
@@ -9223,7 +9223,7 @@
class URLRequestTestReferrerPolicy : public URLRequestTest {
public:
- URLRequestTestReferrerPolicy() {}
+ URLRequestTestReferrerPolicy() = default;
void InstantiateSameOriginServers(net::EmbeddedTestServer::Type type) {
origin_server_.reset(new EmbeddedTestServer(type));
@@ -10136,7 +10136,7 @@
false /* token binding enabled */);
context_.set_ssl_config_service(ssl_config_service_.get());
}
- ~HTTPSFallbackTest() override {}
+ ~HTTPSFallbackTest() override = default;
protected:
TestSSLConfigService* ssl_config_service() {
@@ -10235,7 +10235,7 @@
default_context_.set_cert_verifier(&cert_verifier_);
default_context_.Init();
}
- ~HTTPSSessionTest() override {}
+ ~HTTPSSessionTest() override = default;
protected:
MockCertVerifier cert_verifier_;