| commit | 7d04c29327c384306bf55278844d477c58b63274 | [log] [tgz] |
|---|---|---|
| author | Pu Shi <pushi@google.com> | Tue Apr 11 20:13:59 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Apr 11 20:13:59 2023 |
| tree | 7149ccd5619cc6e9ef99491db09cfc010e5fc3fd | |
| parent | a29eefe9c521999f125bb85a248a9a07b439bc46 [diff] [blame] |
[EXO] Fix ghost view when closing Phone Hub bubble from app stream launcher view When Phone Hub bubble dismissed from App Streaming Launcher view, the list will move out of bubble area and visible for a short time after bubble is closed. This CL fixes the issue by remove all child views before bubble closed. Screen recording: https://drive.google.com/file/d/1D39V8sTMHsYjohDZksDqJ6LUaj64jE9T/view?usp=sharing&resourcekey=0-qN6nfBFkxshD8pehf6IdUQ Tested: manually verified the behavior when collapsing bubble from launcher view. Bug: b/277652794 Change-Id: I875d25dce3f45be1edd92364ed2b4d5626e302dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4412916 Reviewed-by: Jon Mann <jonmann@chromium.org> Commit-Queue: Pu Shi <pushi@google.com> Reviewed-by: Crisrael Lucero <crisrael@google.com> Cr-Commit-Position: refs/heads/main@{#1128861}
diff --git a/ash/system/phonehub/app_stream_launcher_view.h b/ash/system/phonehub/app_stream_launcher_view.h index db55554..ffa5de98 100644 --- a/ash/system/phonehub/app_stream_launcher_view.h +++ b/ash/system/phonehub/app_stream_launcher_view.h
@@ -43,6 +43,7 @@ // PhoneHubContentView: phone_hub_metrics::Screen GetScreenForMetrics() const override; + void OnBubbleClose() override; // phonehub::AppStreamLauncherDataModel::Observer: void OnAppListChanged() override;