[go: nahoru, domu]
Google Git
Sign in
chromium / chromium / src / 851477c6a5e68a414d66fce5fab3bbb70a941692
commit851477c6a5e68a414d66fce5fab3bbb70a941692[log] [tgz]
authorDavid Benjamin <davidben@chromium.org>Mon Jun 24 21:52:44 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jun 24 21:52:44 2024
tree7a9bdc0c47943e44cde1bf681bb5e590875eccfe
parent9edf00451c7df4b940adb5cbde768590da50abf6 [diff]
Don't mark ipcz wire structures as 8-byte aligned

On macOS, we don't actually achieve the specified alignment. I suspect
this is because mach messages only give you 4-byte alignment, not 8.

Sample failures:
https://ci.chromium.org/ui/labs/p/chromium/inv/build-8744363917858885313/test/ninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FAutofillInteractiveFormSubmissionTest.ProbableSubmission/variant/c986399db6573e01?resultIndex=0
https://ci.chromium.org/ui/labs/p/chromium/inv/build-8744316879698860305/test/ninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FAboutFlagsBrowserTest.ExpiryHidesFlag%2FAll.1/variant/c986399db6573e01

Just remove the alignment markers, which causes the unaligned pragma
pack expectations to go through. (Strictly speaking, the casts are
still questionably allowed because of C++'s strict aliasing
requirements, but we build with -fno-strict-aliasing.)

Bug: 40248746
Change-Id: I6c4e8df9c8c56658fb6a9732bf28f76702296a18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5649953
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1318810}
2 files changed
tree: 7a9bdc0c47943e44cde1bf681bb5e590875eccfe
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.