[go: nahoru, domu]

media: Remove base::BindRepeating() + base::Passed() usage.

base::BindRepeating() + base::Passed() is an anti-pattern, as the
resulting callback should typically only be run once. The existing media
usage has been converted to use base::BindOnce() + std::move() instead,
with tests updated as needed.

Bug: 751838, 1180750
Change-Id: I469bdbc9df2a9d894c5b7032fb32e2287b867dcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2715960
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857224}
diff --git a/media/renderers/renderer_impl.h b/media/renderers/renderer_impl.h
index d23baa6..5c0d688 100644
--- a/media/renderers/renderer_impl.h
+++ b/media/renderers/renderer_impl.h
@@ -152,7 +152,7 @@
                             base::OnceClosure restart_completed_cb);
 
   // Fix state booleans after the stream switching is finished.
-  void CleanUpTrackChange(base::RepeatingClosure on_finished,
+  void CleanUpTrackChange(base::OnceClosure on_finished,
                           bool* ended,
                           bool* playing);