commit | 86f939fd8d21f3982ce70a4563d17639408b596d | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Tue Aug 15 09:39:27 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Aug 15 09:39:27 2023 |
tree | 33d32fffdd994cb9201d032d8e8ae80c8e5354c6 | |
parent | 71961908446f09783ec4913e2722a064f9f3f108 [diff] |
More cross-platform pixel test support in MockPrinter. It used to only work on Mac (maybe; no pixels were actually tested due to no test coverage), and possibly Windows as well, using platform code. It should now work in Linux, Mac and Windows, but not Android (because PDF isn't enabled there). Remove platform-specific code from printing::Image. Instead provide a constructor that takes raw pixel data. Generate the raw pixel data from PDF in MockPrinter. MockPrinter::PrintPage() was confused (now named OnDocumentPrinted()). It expected to be called once per page, but it is in fact only called once per print job. Not that it really mattered, since no tests tested more than one page. :-p Enable PrintRenderFrameHelperTest.PrintWithIframe on all platforms that support pixel testing. Remove PrintRenderFrameHelperTest.PrintLayoutTest, since it's not very useful. It was only enabled on Mac, and it essentially only tested if the page size was *roughly* as expected. We can do better than this now. Add PrintRenderFrameHelperTest.Pixels, which checks all the pixels in a two-page printed document with mixed page size. Change-Id: If275acb230b5834c0f843365d0ea9dfa26a70e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4765574 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1183555}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.