commit | 89f824bbb1bf0df2760331cde51be1754dcab143 | [log] [tgz] |
---|---|---|
author | Trent Apted <tapted@chromium.org> | Fri Oct 20 05:45:12 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 20 05:45:12 2017 |
tree | cf12d4df0c66e0d952d5fe9b3527ee3c4b4ff783 | |
parent | db0868eb17e4f5a0ca928a14024f6ee8c061c0e8 [diff] |
Mac: If a modal window is detected, do not pump private message loop modes. It's possible for [NSApp modalWindow] to be set under some rare circumstances when pumping regular tasks. This was unexpected, so if a menu is shown in these cases, Chrome currently CHECK()s. Instead, detect this, and run the menu in a "safe" mode, without pumping regular tasks in the private runloop modes used for menu animations. Crash stacks suggest that one possibility may be that a background thread is showing an NSAlert and setting the global [NSApp modalWindow]. This is fine but it confuses the CHECK(). Bug: 775738 Change-Id: I6a60f77f3c6c229c4809a4718d128ad2c59c7309 Reviewed-on: https://chromium-review.googlesource.com/724759 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#510350}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .