commit | 82d376fcbceb27323ec14b12ce6d45f18ebf2bb2 | [log] [tgz] |
---|---|---|
author | Edman Anjos <edmanp@google.com> | Thu Jan 04 10:26:15 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 04 10:26:15 2024 |
tree | 8d9b9158fd02bc0f67a7e01f3cc1796b6f0fb3ff | |
parent | c5736728b45535acc432dd2d7b0a0a59b4c98d9b [diff] |
kiosk: Dismiss the "launch cancelled" toast after sign in The "Kiosk application launch cancelled" toast is shown by the kiosk_apps_menu_controller.cc in the lock screen after the user cancels Kiosk launch. Currently the toast remains open until the user manually clicks "dismiss". This leads to a dangling pointer once the lock screen is destroyed. This change makes sure the toast is dismissed when destroying the lock screen. Fixed: b:316344752 Test: testing/xvfb.py tools/autotest.py -C out/Default --run-all ash/login/login_screen_controller_unittest.cc Change-Id: I674fb4b91713b3a94ea03c8a945aa60ead4425b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5150803 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Edman Anjos <edman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1242837}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.