[go: nahoru, domu]

Revert "Update last interacted form when JS modifies a field's value"

This reverts commit 05c6be3dfec78f091d537673fbf65605f7a41776.

Reason for revert: Speedometer2 regressions. I will reupload another CL
that tries to achieve the same result with possibly no regressions

Original change's description:
> Update last interacted form when JS modifies a field's value
>
> Autofill is currently working on replacing the observer it uses for
> disappearing elements by a direct blink connection notifying of removals
> and hiding of elements.
>
> Some notification about hidden elements are provided to Autofill during
> style recalc (e.g. changing visibility attribute to 'hidden') and during
> this Autofill is not allowed to query the focusability of a node.
>
> This causes a problem for Autofill: When submission is inferred,
> Autofill tries to extract the form of the element it was tracking, and
> part of this is querying the focusability of fields. Which means that
> if submission is inferred from a notification sent during style recalc,
> Autofill is not allowed to extract a form at submission time.
>
> The alternative is to use the provisionally saved form, which is a form
> that Autofill updates on autofill operations and user edits. In this
> context, form means either an HTML <form> tagged section or the
> collection of all unowned control elements.
>
> This CL tries to make the provisionally saved form approach the state of
> the extracted form at submission time (should we have extracted it)
> by also updating it on JS changes. To achieve that, we modify the signal
> JavaScriptModifiedAutofilledValue to JavaScriptModifiedValue.
>
> Note that this update is only performed if JS modifies the form that is
> already tracked by autofill. Which means that only user edits and
> autofill (also user triggered) have permission to change the form
> tracked by autofill from one form to another, but JS only has permission
> to update the currently tracked form.
>
> The CL also adds logic to default to the provisionally save form
> unconditionally at submission time instead of extraction.
>
> All behavior changes are gated behind a feature flag.
>
> Bug: 1483242
> Change-Id: I34635ddbe88dc49aeb31e23f2999e7bca95952bb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5238376
> Reviewed-by: Dominic Battre <battre@chromium.org>
> Reviewed-by: Christoph Schwering <schwering@google.com>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Jihad Hanna <jihadghanna@google.com>
> Cr-Commit-Position: refs/heads/main@{#1257853}

(cherry picked from commit 0cdb5e55e108d9287ed0aeb5a5e2bfe17566114b)

Bug: 1483242
Change-Id: Ia641dfeb7d22cf8ec89804876febe6bb1a256f24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310179
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: Dominic Battre <battre@chromium.org>
Reviewed-by: Christoph Schwering <schwering@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jihad Hanna <jihadghanna@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1264454}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5344511
Auto-Submit: Jihad Hanna <jihadghanna@google.com>
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/branch-heads/6312@{#391}
Cr-Branched-From: 6711dcdae48edaf98cbc6964f90fac85b7d9986e-refs/heads/main@{#1262506}
12 files changed
tree: 83baf7ce40c560bead32088dcd2f64760df2c9e1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.