[go: nahoru, domu]

desks_restore: Restore windows to their parent desks.

- save a workspace in window's property.
- trigger saving to browser session when property is updated, but
need force saving in `WindowOpened()` for newly created window.
- restore each window to the right desk by assigning to the right
parent desk container in `GetDefaultParentForWindow()`.
- resolve desk activation conflict between browser session and
an active desk restore by checking `IsSessionRestoreInProgress()`
in ash to avoid every single window activation during restore.
- resolve the parent desk conflict between the first restored window
and a blank window by stop reusing the blank window for restore
and always create a new window during restoration.
- resolve clobbering tab restore by passing null browser when using
desks restore feature.
- add browser tests checking that each window restore to the parent
desk if DesksRestore enabled, otherwise to the first desk, which is a
default active desk after a crash.

`browser_tests --gtest_filter=*SessionRestoreTestChromeOS*`

Bug: 996999
Test: Manual test (a video in crbug comment 27) and browser tests
Change-Id: I0f9202e10a7b861a676725e7390b15fd71a00933
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572316
Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840778}
20 files changed
tree: f5d4ffbc3193bb131a56cd8589d885e90bfbf3d2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.