commit | 8c45e308cf6f8acfc5307bced41a9a978deaaae0 | [log] [tgz] |
---|---|---|
author | Cattalyya Nuengsigkapian <cattalyya@chromium.org> | Wed Jan 06 21:48:08 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jan 06 21:48:08 2021 |
tree | f5d4ffbc3193bb131a56cd8589d885e90bfbf3d2 | |
parent | c8d90cd6e4b26bcaf83050acfdf83af557812a78 [diff] |
desks_restore: Restore windows to their parent desks. - save a workspace in window's property. - trigger saving to browser session when property is updated, but need force saving in `WindowOpened()` for newly created window. - restore each window to the right desk by assigning to the right parent desk container in `GetDefaultParentForWindow()`. - resolve desk activation conflict between browser session and an active desk restore by checking `IsSessionRestoreInProgress()` in ash to avoid every single window activation during restore. - resolve the parent desk conflict between the first restored window and a blank window by stop reusing the blank window for restore and always create a new window during restoration. - resolve clobbering tab restore by passing null browser when using desks restore feature. - add browser tests checking that each window restore to the parent desk if DesksRestore enabled, otherwise to the first desk, which is a default active desk after a crash. `browser_tests --gtest_filter=*SessionRestoreTestChromeOS*` Bug: 996999 Test: Manual test (a video in crbug comment 27) and browser tests Change-Id: I0f9202e10a7b861a676725e7390b15fd71a00933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572316 Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#840778}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.