[go: nahoru, domu]
Google Git
Sign in
chromium / chromium / src / 8ca948398a6850a9f53e215b9ca9d87f0b3fd6a9
commit8ca948398a6850a9f53e215b9ca9d87f0b3fd6a9[log] [tgz]
authorJoanmarie Diggs <jdiggs@igalia.com>Thu Sep 29 17:11:00 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Sep 29 17:11:00 2022
treedf635779e910967b4ced1be1f580852ef2b02e1a
parent493aef2570e776cbfadc4f951212d55d339f76a4 [diff]
Create AXNodeData::SetNameChecked

There are two desires / expectations regarding AXNodeData::SetName:

1. Callers should call AXNodeData::SetNameExplicitlyEmpty rather than
   SetName to remove the accessible name (e.g. from a View).

2. Callers are expected to set a valid role prior to calling SetName.

With respect to the former, nothing enforces that. The latter is
now enforced by crrev.com/c/3816142. This change:

* Creates AXNodeData::SetNameChecked with DCHECKs for empty names
* Marks AXNodeData::SetName as deprecated

Follow-up changes will migrate Views from SetName to SetNameChecked,
fixing any unmet expectations in the process.

AX-Relnotes: n/a

Bug: 1348081
Change-Id: I610172ae339f767b1d430dc410ccf71e54e9d604
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3789984
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1053061}
3 files changed
tree: df635779e910967b4ced1be1f580852ef2b02e1a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.