[infra] Enable remote devtools-frontend typescript on experimental builders
As described in https://crrev.com/c/5061870, remote
devtools-frontend typescript slows down builds with cache misses.
Enable it only on experimental CQ builders and build perf
builders to collect the data.
Bug: b/308405411
Change-Id: I4accfb1f6aaff8d9953892b821065d6d7da12d66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5064531
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#1229834}
diff --git a/build/config/siso/devtools_frontend.star b/build/config/siso/devtools_frontend.star
index 0fb39d7..a2b6af3 100644
--- a/build/config/siso/devtools_frontend.star
+++ b/build/config/siso/devtools_frontend.star
@@ -48,6 +48,7 @@
"exclude_input_patterns": [
"*.stamp",
],
+ # TODO: b/308405411 - Enable remote-devtools-frontend-typescript by default.
"remote": config.get(ctx, "remote-devtools-frontend-typescript"),
"handler": "devtools_frontend/typescript_ts_library",
"output_local": True,
diff --git a/infra/config/generated/builders/try/android-arm64-siso-rel-compilator/properties.json b/infra/config/generated/builders/try/android-arm64-siso-rel-compilator/properties.json
index 7bc03af2..90d0c4e 100644
--- a/infra/config/generated/builders/try/android-arm64-siso-rel-compilator/properties.json
+++ b/infra/config/generated/builders/try/android-arm64-siso-rel-compilator/properties.json
@@ -104,7 +104,8 @@
},
"$build/siso": {
"configs": [
- "builder"
+ "builder",
+ "remote-devtools-frontend-typescript"
],
"enable_cloud_profiler": true,
"enable_cloud_trace": true,
diff --git a/infra/config/generated/builders/try/android_compile_siso_dbg/properties.json b/infra/config/generated/builders/try/android_compile_siso_dbg/properties.json
index ead6b94..42af94e2 100644
--- a/infra/config/generated/builders/try/android_compile_siso_dbg/properties.json
+++ b/infra/config/generated/builders/try/android_compile_siso_dbg/properties.json
@@ -60,7 +60,8 @@
},
"$build/siso": {
"configs": [
- "builder"
+ "builder",
+ "remote-devtools-frontend-typescript"
],
"enable_cloud_profiler": true,
"enable_cloud_trace": true,
diff --git a/infra/config/generated/builders/try/chromeos-amd64-generic-siso-rel-compilator/properties.json b/infra/config/generated/builders/try/chromeos-amd64-generic-siso-rel-compilator/properties.json
index a78f39c4..38cb81e60 100644
--- a/infra/config/generated/builders/try/chromeos-amd64-generic-siso-rel-compilator/properties.json
+++ b/infra/config/generated/builders/try/chromeos-amd64-generic-siso-rel-compilator/properties.json
@@ -62,7 +62,8 @@
},
"$build/siso": {
"configs": [
- "builder"
+ "builder",
+ "remote-devtools-frontend-typescript"
],
"enable_cloud_profiler": true,
"enable_cloud_trace": true,
diff --git a/infra/config/generated/builders/try/linux-chromeos-compile-siso-dbg/properties.json b/infra/config/generated/builders/try/linux-chromeos-compile-siso-dbg/properties.json
index c2b1a0c..6d77c81 100644
--- a/infra/config/generated/builders/try/linux-chromeos-compile-siso-dbg/properties.json
+++ b/infra/config/generated/builders/try/linux-chromeos-compile-siso-dbg/properties.json
@@ -54,7 +54,8 @@
},
"$build/siso": {
"configs": [
- "builder"
+ "builder",
+ "remote-devtools-frontend-typescript"
],
"enable_cloud_profiler": true,
"enable_cloud_trace": true,
diff --git a/infra/config/generated/builders/try/linux-siso-rel-compilator/properties.json b/infra/config/generated/builders/try/linux-siso-rel-compilator/properties.json
index dc12af9..f76fb4f 100644
--- a/infra/config/generated/builders/try/linux-siso-rel-compilator/properties.json
+++ b/infra/config/generated/builders/try/linux-siso-rel-compilator/properties.json
@@ -168,7 +168,8 @@
},
"$build/siso": {
"configs": [
- "builder"
+ "builder",
+ "remote-devtools-frontend-typescript"
],
"enable_cloud_profiler": true,
"enable_cloud_trace": true,
diff --git a/infra/config/generated/builders/try/mac-siso-rel-compilator/properties.json b/infra/config/generated/builders/try/mac-siso-rel-compilator/properties.json
index 8ab5fa9..75ed2ee2 100644
--- a/infra/config/generated/builders/try/mac-siso-rel-compilator/properties.json
+++ b/infra/config/generated/builders/try/mac-siso-rel-compilator/properties.json
@@ -199,7 +199,8 @@
},
"$build/siso": {
"configs": [
- "builder"
+ "builder",
+ "remote-devtools-frontend-typescript"
],
"enable_cloud_profiler": true,
"enable_cloud_trace": true,
diff --git a/infra/config/generated/luci/cr-buildbucket.cfg b/infra/config/generated/luci/cr-buildbucket.cfg
index 032c11f..5c80b22 100644
--- a/infra/config/generated/luci/cr-buildbucket.cfg
+++ b/infra/config/generated/luci/cr-buildbucket.cfg
@@ -209,7 +209,8 @@
' },'
' "$build/siso": {'
' "configs": ['
- ' "builder"'
+ ' "builder",'
+ ' "remote-devtools-frontend-typescript"'
' ],'
' "enable_cloud_profiler": true,'
' "enable_cloud_trace": true,'
@@ -345,7 +346,8 @@
' },'
' "$build/siso": {'
' "configs": ['
- ' "builder"'
+ ' "builder",'
+ ' "remote-devtools-frontend-typescript"'
' ],'
' "enable_cloud_profiler": true,'
' "enable_cloud_trace": true,'
@@ -471,7 +473,8 @@
' },'
' "$build/siso": {'
' "configs": ['
- ' "builder"'
+ ' "builder",'
+ ' "remote-devtools-frontend-typescript"'
' ],'
' "enable_cloud_profiler": true,'
' "enable_cloud_trace": true,'
@@ -600,7 +603,8 @@
' },'
' "$build/siso": {'
' "configs": ['
- ' "builder"'
+ ' "builder",'
+ ' "remote-devtools-frontend-typescript"'
' ],'
' "enable_cloud_profiler": true,'
' "enable_cloud_trace": true,'
@@ -726,7 +730,8 @@
' },'
' "$build/siso": {'
' "configs": ['
- ' "builder"'
+ ' "builder",'
+ ' "remote-devtools-frontend-typescript"'
' ],'
' "enable_cloud_profiler": true,'
' "enable_cloud_trace": true,'
@@ -855,7 +860,8 @@
' },'
' "$build/siso": {'
' "configs": ['
- ' "builder"'
+ ' "builder",'
+ ' "remote-devtools-frontend-typescript"'
' ],'
' "enable_cloud_profiler": true,'
' "enable_cloud_trace": true,'
@@ -1108,7 +1114,8 @@
' },'
' "$build/siso": {'
' "configs": ['
- ' "builder"'
+ ' "builder",'
+ ' "remote-devtools-frontend-typescript"'
' ],'
' "enable_cloud_profiler": true,'
' "enable_cloud_trace": true,'
@@ -1238,7 +1245,8 @@
' },'
' "$build/siso": {'
' "configs": ['
- ' "builder"'
+ ' "builder",'
+ ' "remote-devtools-frontend-typescript"'
' ],'
' "enable_cloud_profiler": true,'
' "enable_cloud_trace": true,'
@@ -1368,7 +1376,8 @@
' },'
' "$build/siso": {'
' "configs": ['
- ' "builder"'
+ ' "builder",'
+ ' "remote-devtools-frontend-typescript"'
' ],'
' "enable_cloud_profiler": true,'
' "enable_cloud_trace": true,'
@@ -1626,7 +1635,8 @@
' },'
' "$build/siso": {'
' "configs": ['
- ' "builder"'
+ ' "builder",'
+ ' "remote-devtools-frontend-typescript"'
' ],'
' "enable_cloud_profiler": true,'
' "enable_cloud_trace": true,'
diff --git a/infra/config/subprojects/build/build.star b/infra/config/subprojects/build/build.star
index 401e3d5e..c745802 100644
--- a/infra/config/subprojects/build/build.star
+++ b/infra/config/subprojects/build/build.star
@@ -77,7 +77,8 @@
reclient_instance = reclient.instance.DEFAULT_UNTRUSTED,
siso_project = siso.project.DEFAULT_UNTRUSTED,
use_clang_coverage = True,
- siso_configs = ["builder"],
+ # TODO: b/308405411 - Enable remote-devtools-frontend-typescript by default.
+ siso_configs = ["builder", "remote-devtools-frontend-typescript"],
**kwargs
)
diff --git a/infra/config/subprojects/chromium/try/tryserver.chromium.android.star b/infra/config/subprojects/chromium/try/tryserver.chromium.android.star
index db7ce12..d5f5120 100644
--- a/infra/config/subprojects/chromium/try/tryserver.chromium.android.star
+++ b/infra/config/subprojects/chromium/try/tryserver.chromium.android.star
@@ -217,6 +217,8 @@
try_.compilator_builder(
name = "android-arm64-siso-rel-compilator",
main_list_view = "try",
+ # TODO: b/308405411 - Enable remote-devtools-frontend-typescript by default.
+ siso_configs = ["builder", "remote-devtools-frontend-typescript"],
siso_enabled = True,
)
@@ -1023,6 +1025,8 @@
gn_args = "try/android_compile_dbg",
main_list_view = "try",
reclient_jobs = reclient.jobs.HIGH_JOBS_FOR_CQ,
+ # TODO: b/308405411 - Enable remote-devtools-frontend-typescript by default.
+ siso_configs = ["builder", "remote-devtools-frontend-typescript"],
siso_enabled = True,
tryjob = try_.job(
experiment_percentage = 10,
diff --git a/infra/config/subprojects/chromium/try/tryserver.chromium.chromiumos.star b/infra/config/subprojects/chromium/try/tryserver.chromium.chromiumos.star
index 99ca795..aebdcdb5 100644
--- a/infra/config/subprojects/chromium/try/tryserver.chromium.chromiumos.star
+++ b/infra/config/subprojects/chromium/try/tryserver.chromium.chromiumos.star
@@ -258,6 +258,8 @@
try_.compilator_builder(
name = "chromeos-amd64-generic-siso-rel-compilator",
main_list_view = "try",
+ # TODO: b/308405411 - Enable remote-devtools-frontend-typescript by default.
+ siso_configs = ["builder", "remote-devtools-frontend-typescript"],
siso_enabled = True,
)
@@ -458,6 +460,8 @@
contact_team_email = "chrome-build-team@google.com",
main_list_view = "try",
reclient_jobs = reclient.jobs.HIGH_JOBS_FOR_CQ,
+ # TODO: b/308405411 - Enable remote-devtools-frontend-typescript by default.
+ siso_configs = ["builder", "remote-devtools-frontend-typescript"],
siso_enabled = True,
tryjob = try_.job(
experiment_percentage = 10,
diff --git a/infra/config/subprojects/chromium/try/tryserver.chromium.linux.star b/infra/config/subprojects/chromium/try/tryserver.chromium.linux.star
index 87cb92c..7a7f732 100644
--- a/infra/config/subprojects/chromium/try/tryserver.chromium.linux.star
+++ b/infra/config/subprojects/chromium/try/tryserver.chromium.linux.star
@@ -327,6 +327,8 @@
try_.compilator_builder(
name = "linux-siso-rel-compilator",
main_list_view = "try",
+ # TODO: b/308405411 - Enable remote-devtools-frontend-typescript by default.
+ siso_configs = ["builder", "remote-devtools-frontend-typescript"],
siso_enabled = True,
)
diff --git a/infra/config/subprojects/chromium/try/tryserver.chromium.mac.star b/infra/config/subprojects/chromium/try/tryserver.chromium.mac.star
index dd237ce..eeb8562a 100644
--- a/infra/config/subprojects/chromium/try/tryserver.chromium.mac.star
+++ b/infra/config/subprojects/chromium/try/tryserver.chromium.mac.star
@@ -205,6 +205,8 @@
cpu = cpu.ARM64,
contact_team_email = "chrome-build-team@google.com",
main_list_view = "try",
+ # TODO: b/308405411 - Enable remote-devtools-frontend-typescript by default.
+ siso_configs = ["builder", "remote-devtools-frontend-typescript"],
siso_enabled = True,
)