commit | 944479f20490ad1bb8a7f486e2afe1f6ac55025a | [log] [tgz] |
---|---|---|
author | Hans Wennborg <hans@chromium.org> | Thu Jun 25 21:39:25 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jun 25 21:39:25 2020 |
tree | 87d048892b0b87721975c15abf09ec7b7e3b48d9 | |
parent | d577af5dcf55348d971048a98ad026b226a8bcdb [diff] |
Reland "[base] Stop including check.h, notreached.h, etc. in logging.h" This is a reland of f85481f892e03cd068e7f7543d76222c678b0bdb Fixes since the previous commit: https://chrome-internal-review.googlesource.com/c/chrome/deps/amd/+/3133484 https://chrome-internal-review.googlesource.com/c/chrome/assistant/+/3133487 https://chrome-internal-review.googlesource.com/c/chrome/assistant/+/3135083 https://chromium-review.googlesource.com/c/chromium/src/+/2264371 Original change's description: > [base] Stop including check.h, notreached.h, etc. in logging.h > > The CHECK, CHECK_EQ etc., and NOTREACHED macros have moved out > of logging.h into separate, much cheaper to include, headers. > > Now that the code has been updated to use the new headers, and > to not rergess on that, stop including them in logging.h. > > Bug: 1031540 > Change-Id: Idfa891b991cbca1dfef93630c0f37b1b022f99df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264413 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Hans Wennborg <hans@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781970} TBR=thakis Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: 1031540 Change-Id: Ie889e031d229745f93363c7bb2605c4f65591f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264297 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#782682}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.