commit | 96a123958a12f321d3cec3fab3839052edd4fc68 | [log] [tgz] |
---|---|---|
author | Alan Screen <awscreen@chromium.org> | Mon Nov 06 21:53:16 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Nov 06 21:53:16 2023 |
tree | fa68499873bec7a687ae4e219e6b4e11412e5d4b | |
parent | a68eb000c9bd9e9dde7d1d1b564c0bac3dc59305 [diff] |
Use process behavior field in PrintingContext In order to support a policy override for controlling out-of-process printing, the low-level //printing layer cannot rely solely upon the printing feature flags. Since policy preferences reside at a higher level than //printing, this state information needs to be provided to PrintingContext. All logic under //printing which uses ShouldPrintJobOop() needs to be changed. In some cases it is insufficient to just rely upon the existing signal for whether system calls should be skipped, so a more detailed signal is needed. Replace the PrintingContext "skip system calls" mechanism with an enum to identify the process behavior desired. This can provide the details for whether OOP printing is involved in addition to whether system calls should be skipped for the PrintingContext instance being created. This API change ripples through the rest of the printing stack. This prepares the upper levels of the printing stack to be ready to override the behavior if OOP printing policy is specified. Printing support in Pepper is unused, so this code no longer even needs to check the feature flags. This code is just changed to use a placeholder value of OOP disabled. Bug: 1497035 Low-Coverage-Reason: HARD_TO_TEST, https://crbug.com/1256506, https://crbug.com/1451540 Change-Id: I8724631551aeeeb954560f3c28f5ffb1f5c0b1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987444 Reviewed-by: Derek Schuff <dschuff@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1220535}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.