commit | 92b4922b63eca826f14524af6d2dfd06fa845d7b | [log] [tgz] |
---|---|---|
author | Siyu An <siyua@chromium.org> | Mon Mar 04 19:54:51 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 04 19:54:51 2024 |
tree | ea8f654739a229d0e4efb9e48372833c01ae73f0 | |
parent | b8b779f4935585732efdeacd2ab44f1807feb436 [diff] |
[Merge][Reauth] Fix crash for mandatory reauth switch Can reproduce if clicking the toggle multiple times in a very short time (0.5s) before the device unlock is triggered. So when this check happens, the switch UI's value may be same as the user preference's value if the switch is being tapped multiple times. A straightforward fix is to simply remove this CHECK as this is not relevant: We record the original user preference value and do a device unlock and update the toggle to the most up-to-date value, so the UI state during this process does not really matter. (cherry picked from commit 2f87ef38bd2e41cd64d2c088fe9ab2709c601476) Bug: b/325608728 Change-Id: I3524491581c6d27409a801ea3113348885bad2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5333563 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Vidhan Jain <vidhanj@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1267105} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5340499 Commit-Queue: Krishna Govind <govind@chromium.org> Owners-Override: Krishna Govind <govind@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6312@{#357} Cr-Branched-From: 6711dcdae48edaf98cbc6964f90fac85b7d9986e-refs/heads/main@{#1262506}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.