commit | 9b911f2f81d8bde89b659e8a40d7db9748c9e072 | [log] [tgz] |
---|---|---|
author | Sammie Quon <sammiequon@google.com> | Fri Dec 15 02:53:15 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Dec 15 02:53:15 2017 |
tree | a95ef4ed65a34bd6e30a7fcf8b1564e01f49cd4f | |
parent | c8be452f932dfeb6590aa6f276f4c2e39794cba0 [diff] |
shelf: Separate back button and app list button. Seperate the back button and app list button into separate elements. Draws the background in ShelfView::OnPaint. This fixes issues with ink drop and accessibility focusing not working correctly. Made changes to ShelfView focus search to accommodate this. Add back_button_unittest. Removed app_list_button/back button ink drop unittest which tested if different parts of the old app list button's ink drop acted different if different parts were pressed. Not needed as the two separate buttons' ink drops should work normally. Removed app_list_button rtl unittest as the buttons should be flipped normally by the views rtl handling. Test: ash_unittests *Shelf* *ApplistButton* *BackButton* Bug: 791638, 758402 Change-Id: I07bdd0b490ffb2619a13cebacf388e2e08190114 Reviewed-on: https://chromium-review.googlesource.com/761856 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#524301}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .