[go: nahoru, domu]
Google Git
Sign in
chromium / chromium / src / 9c84166b919a35d5bf023c2f0eb73414bb9dd6a2
commit9c84166b919a35d5bf023c2f0eb73414bb9dd6a2[log] [tgz]
authorAndrew Rayskiy <greengrape@google.com>Fri Feb 09 14:07:05 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Feb 09 14:07:05 2024
tree51fd936b2c44329c86aa60706b2d0f42bb9979e7
parentfa4720b8cc33a07b0c687c426913f05dafec11dc [diff]
[Printing] Enrich CupsPrintingNotification for Web Printing API jobs

Jobs initiated by Isolated Web Apps (IWAs) via the Web Printing API do
not require a print dialog which allows these apps to print silently.
To keep the user aware of what is actually happening, it's necessary to
augment the existing printing notification with a few important details:
* The name of the initiating IWA;
* An option to revoke the IWA's permission to print.

To achieve the latter while preserving the existing behavior (open the
print management app on click), the notification is now equipped with
two buttons: one brings the user to the content settings page, and the
other opens the print management app as before.

Note that these changes only apply to jobs submitted via the Web
Printing API; for all others notifications follow the existing model.

On top of that, a few messages are updated to align with the modern
UX guidance:
* Printing started -> Printing...
* Printing complete -> Done

See go/advanced-printer-features-wd for details on wordsmithing.

Bug: b/302505962
Change-Id: Ie2c62ae1f9c271070a352a0d4f11cc5a00f7cafa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5224206
Commit-Queue: Andrew Rayskiy <greengrape@google.com>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Benjamin Gordon <bmgordon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1258479}
14 files changed
tree: 51fd936b2c44329c86aa60706b2d0f42bb9979e7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.