[go: nahoru, domu]

Reland "[Files SWA]: Chrome App API cleanup"

This is a reland of 0a1158be66a6730d0d8a3d7c9295783cd39fc7e2

I do not believe this CL was the reason for failing tests. As one
can see on https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/24411/overview
the same tests failed, even though at the revisions these tests failed
(6d6e70194b5ad31b93d372981e6fe79d45ddd944) this CL was already
reverted. Notice lack of url_constants.js in
https://chromium.googlesource.com/chromium/src/+/6d6e70194b5ad31b93d372981e6fe79d45ddd944/ui/file_manager/file_manager/common/js/

Original change's description:
> [Files SWA]: Chrome App API cleanup
>
> Removing dependencies on chrome.runtime.getManifest and
> chrome.runtime.getURL APIs. Since those require URLs based
> on the Files App ID (host), adds url_constants.js.
> The new module centralizes building File Manager URLs for
> files.
>
> Bug: b/194251406, b/194251405
> Change-Id: Ifae98ead43db329c45afac054df9f72709d58cdf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3056256
> Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
> Commit-Queue: Bo Majewski <majewski@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#906435}

Bug: b/194251406, b/194251405
Change-Id: I9115cf449bd759e0442fcb8da8f460eb5f5732b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3060136
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#906902}
diff --git a/ui/file_manager/file_manager/BUILD.gn b/ui/file_manager/file_manager/BUILD.gn
index 5b0ea272..720fba0 100644
--- a/ui/file_manager/file_manager/BUILD.gn
+++ b/ui/file_manager/file_manager/BUILD.gn
@@ -39,6 +39,7 @@
     "common/js/storage_adapter.js",
     "common/js/test_error_reporting.js",
     "common/js/volume_manager_types.js",
+    "common/js/url_constants.js",
     "common/js/xfm.js",
     "foreground/js/metadata/image_orientation.js",
     "externs/background/background_base.js",