Publish DEPS for Chromium 67.0.3396.78
Incrementing VERSION to 67.0.3396.78
TBR=dimu@chromium.org
Change-Id: Ie77f84be59134d8b2e03fc6ce89ef802facf5766
Reviewed-on: https://chromium-review.googlesource.com/1087580
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#753}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Fix crash in variations simulation code.
Crash was cauded by a null experiment, which is something we handled
elsewhere but not in this particular code. Also adds a unit test is
able to trigger the crash before the fix, although I'm not very
convinced this is the exact edge case from the wild (but either
way the fix should apply to both).
Also adds some comments about some code that was a bit confusing.
One is about using the previous group for kill switch type and
another about the threading when simulation.
TBR=asvitkine@chromium.org
(cherry picked from commit 59e4b212dc6877ffc890d142de4da5719e75dcea)
Bug: 837540
Change-Id: If93f4658cd18019f3f40c82ec3172d10f61356f3
Reviewed-on: https://chromium-review.googlesource.com/1036104
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#556115}
Reviewed-on: https://chromium-review.googlesource.com/1087405
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#752}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Network config: Support OpenVPN with no user cert
TBR=stevenjb@chromium.org
(cherry picked from commit a02de1ab8e0c82fc05daaf68af1c1532998a48f6)
Bug: 839195
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I20514f612345a16629e5a1370277885b6b2e3ad3
Reviewed-on: https://chromium-review.googlesource.com/1066610
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#560657}
Reviewed-on: https://chromium-review.googlesource.com/1087538
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#751}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Restore selection events for autofill popup menu
In a menu, ChromeVox expects selection events, not focus events. Other
screen readers can use either type events. Therefore, we should revert
to using selection events in the Autofill popup.
TBR=aleventhal@chromium.org
(cherry picked from commit ccc90b0f9fe600a119c3a592df18c1b28655c3c1)
Bug: 848297
Change-Id: I8642a6b1889ae05972b71009a3f7df3f422ec02d
Reviewed-on: https://chromium-review.googlesource.com/1085273
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564196}
Reviewed-on: https://chromium-review.googlesource.com/1087411
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#750}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Incrementing VERSION to 67.0.3396.77
TBR=dimu@chromium.org
Change-Id: If7a37b741fad45fcb85e887900e2a88c48957229
Reviewed-on: https://chromium-review.googlesource.com/1087178
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#749}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Omnibox: Fix bad merge to M67 part 2.
There's a unit test that was merged in that simply cannot run, because
the supporting code had not landed back then.
This CL excises this code from the M67 branch.
Bug: 847270
Change-Id: I2081d127b83f1e4634b04478d6700ff9404bfa38
Reviewed-on: https://chromium-review.googlesource.com/1087044
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#748}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Add null check in LocationBarPhone#updateGoogleG
TBR=thildebr@chromium.org
Bug: 843024, 848700
Change-Id: I559a2d65f5112724112a0a57b38e4da4ef375bc4
Reviewed-on: https://chromium-review.googlesource.com/1060116
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#558813}(cherry picked from commit 6fbb920fcbdef0e1b3d87f6836e9068b284f99f0)
Reviewed-on: https://chromium-review.googlesource.com/1086767
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#747}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}[exo] Set the render pass output rect to a consistent size
The render pass output rectangle needs to be set to a consistent size
that does not change unless the window size also changes.
The prior process involved computing the pixel size output rectangle
affected by each exo surface, and taking the union of all those to get
the render pass output rect.
The window size however is computed by taking the union of the
rectangles in device-independent pixels, and only converting the size of
the resulting rectangle to device pixels at the end.
Rectangle conversions are done to bound the floating-point
intermediates. Size conversions always round down. And with some
interesting device scale factors like "1.6" the intermediate floating
point values did not have a nice conversion from integer values.
This patch alters how the render pass output rectangle is computed so
that a consistent value is calculated.
If the window size does change, then a new surface will be allocated,
and a new surface will be allocated for the new size.
TBR=lpique@chromium.org
(cherry picked from commit 070e165a53f1abcb2bd3eeac2d89bdb4c0870049)
Bug: 846169
Change-Id: I05b5dff53b7c5c050150571b5334b06c8de2ee32
Reviewed-on: https://chromium-review.googlesource.com/1071118
Commit-Queue: Lloyd Pique <lpique@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562068}
Reviewed-on: https://chromium-review.googlesource.com/1086282
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#746}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Incrementing VERSION to 67.0.3396.76
TBR=dimu@chromium.org
Change-Id: If93fbefbdd29b8bc5da957e24d8addf53d6b72a8
Reviewed-on: https://chromium-review.googlesource.com/1086140
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#745}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Omnibox: Fix a bad merge to M67.
Fix a bad merge here:
https://chromium-review.googlesource.com/c/chromium/src/+/1086158
Two lines were transposed.
Bug: 849270, 838830
Change-Id: If942472b8e4c077c5253ec2711d7fe42705045e5
Reviewed-on: https://chromium-review.googlesource.com/1086347
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#744}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Fix duplicate entries in InstalledApplications for 32-bit OSes
Duplicate entries would mess with the association of modules to their
application.
The current logic discards a conflict when it has multiple application
matches. This is because we can't know for sure which of the
applications really owns the module.
Bug: 845274
Change-Id: I3fc70d3782a56721ae7e0754230fdb761401000e
Reviewed-on: https://chromium-review.googlesource.com/1086235
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#743}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Incrementing VERSION to 67.0.3396.75
TBR=dimu@chromium.org
Change-Id: Idb4d0c633393db6882cae7ff615f5d6f00010267
Reviewed-on: https://chromium-review.googlesource.com/1086135
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#742}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}[ForeignObject] Apply an infinite cull rect when painting <foreignObject>.
Bug: 848179
TBR=chrishtr@chromium.org
(cherry picked from commit 96f1ff917189c07e9a4002bf8a0cca0afe2b5031)
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibf31b9e4df4366363da473ee18d5ff319c1cc56b
Reviewed-on: https://chromium-review.googlesource.com/1085560
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564207}
Reviewed-on: https://chromium-review.googlesource.com/1086207
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#741}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Omnibox UI Experiments: Steady State Elisions - Fix drag threshold bug.
Previously, the drag threshold calculation had a bug. The last-click
event was stored as a root_location, which was tested against the drag
event's location relative to the View origin.
This CL makes both the stored last-click and the current drag event
use the root_location. Using root_location is most robust, since the
View itself can move in response to edit-in-progress state.
It also updates the API of textfield to make more explicit that the
stored last click location is a root_location rather than relative
to the position of the View.
This CL also adds a test.
TBR=tommycli@chromium.org
(cherry picked from commit 90a71482c170466725cb4e217d8932cb8ac508e9)
Bug: 838830, 797354
Change-Id: Iedff486a3c6e842bc5c87c6fd597e1faf7a2930d
Reviewed-on: https://chromium-review.googlesource.com/1040347
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555613}
Reviewed-on: https://chromium-review.googlesource.com/1086158
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#740}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}[Merge to M67] Linux package: Handle 'openSUSE' when determining RPM package manager
> BUG=849123
> R=thestig
>
> Change-Id: I9114cccf3cb3915c6004d4147da6be75f02260f2
> Reviewed-on: https://chromium-review.googlesource.com/1085553
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564168}
BUG=849123
TBR=thestig
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Change-Id: I198db9f5c87cef2ba4baf6d300f7252d41575f4e
Reviewed-on: https://chromium-review.googlesource.com/1085988
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#739}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}[Merge to M67] cros: Wait for cryptohome D-bus service in AutoEnrollmentController
The code is run during early stage of the first boot, it is possible
that cryptohomed hasn't yet registered on dbus at that point. So it
should wait for the service to be available. An example of this pattern
can be found in install_attributes.cc.
TBR=wzang@chromium.org
(cherry picked from commit 9a374af14a9813c83f766d6d8ab2215e879bcca5)
Bug: 841627
Change-Id: I87125bc68bfbaec2b9468af7d22f7a4f4508f03d
Reviewed-on: https://chromium-review.googlesource.com/1072718
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562640}
Reviewed-on: https://chromium-review.googlesource.com/1085902
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#738}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}[ForeignObject] Preserve PointInInnerNodeFrame across foreignObject hit tests.
This regressed in a recent patch, which created a new HitTestResult.
TBR=chrishtr@chromium.org
(cherry picked from commit 7ab0b6e91a28e881354ab5a440537ee3c198af9a)
Bug: 848179
Change-Id: I976f6d9742ca2f785e78ed56a09c77f76dc9e271
Reviewed-on: https://chromium-review.googlesource.com/1082987
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563859}
Reviewed-on: https://chromium-review.googlesource.com/1085807
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#737}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}[foreignObject] Fix hit testing of positioned, clipped descendants of <foreignObject>
The code was broken in three ways:
1. Failing to not re-apply LayoutBoxLocation in PaintLayer. This caused the cull rect
check in LayoutBox::HitTestAllPhases to fail because the coordinate space of the
accumulated offset was wrong by 100px.
2. Coordinate space of the hit test location was wrong in callsite in LayoutSVGForeignObject.
This resulted in culling in PaintLayer::HitTestContentsForFragments early outing because
of lack of intersection with the foreground/background clip rect.
rect will be infinite and therefore it doesn't matter what the coordinate space was.
3. Transforms of <foreignObject> were applied twice: once in LayoutSVGForeignObject, and once
in PaintLayer. Now we apply it in LayoutSVGForeignObject only.
Bug:848179
TBR=chrishtr@chromium.org
(cherry picked from commit 427f64a95fe021629f0fb51642ba27852d4411a8)
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I335416a267bfa9a9df2dc600231fe1518439e790
Reviewed-on: https://chromium-review.googlesource.com/1081241
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563518}
Reviewed-on: https://chromium-review.googlesource.com/1085748
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#736}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Fail gracefully instead of crashing.
This change can be merged into Beta or Stable to prevent the crash from
happening for the time being. Later it can be reverted and the
underlying issue investigated and fixed.
Bug: 842575
Change-Id: I66daf2d6f2f41a4b2d7bde6c3001934e862320dd
Reviewed-on: https://chromium-review.googlesource.com/1070327
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561468}(cherry picked from commit f3eac2a3a2db5b4f6ee7b8789097e2104c1a1cc5)
Reviewed-on: https://chromium-review.googlesource.com/1085387
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#735}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}[Mac] Fix suspicious lifetime issue in KeystoneGlue.
The |brandFile_| ivar is stored and referenced in different methods, but
no memory management is applied. This object is likely resulting in
zombie crashes.
Bug: 847755
Change-Id: If0ae22356422b59b6537a09924f4d1a73b230d3e
Reviewed-on: https://chromium-review.googlesource.com/1081008
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563325}(cherry picked from commit 621c3bed01cd52d371580de545983a19aae695fa)
Reviewed-on: https://chromium-review.googlesource.com/1085267
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#734}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Fix a crash in the save password bubble on Mac.
It's possible that click event is dispatched after WebContents is closed. In that case we should check that we still have a pointer to profile.
TBR=vasilii@chromium.org
(cherry picked from commit 99d98207d0cf21f30b5abbdb00fe7328529e847c)
Bug: 845675
Change-Id: Iffa67dc6321c2b20f9b2c2dbe5f097915eb71985
Reviewed-on: https://chromium-review.googlesource.com/1070161
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561058}
Reviewed-on: https://chromium-review.googlesource.com/1084592
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#733}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Incrementing VERSION to 67.0.3396.74
TBR=dimu@chromium.org
Change-Id: I56ccbd03f93c1cd45ef53d728270092b530b3ebe
Reviewed-on: https://chromium-review.googlesource.com/1083724
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#732}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Incrementing VERSION to 67.0.3396.73
TBR=dimu@chromium.org
Change-Id: I24d03fc88cabb861075eef5c44cd1553557a0650
Reviewed-on: https://chromium-review.googlesource.com/1083638
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#731}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Incrementing VERSION to 67.0.3396.72
TBR=dimu@chromium.org
Change-Id: Ia02f54e2d89e63c2c9efa8c452253f2373f98198
Reviewed-on: https://chromium-review.googlesource.com/1083891
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#730}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Fix crash on Linux when system proxy settings change and fail to be interpreted.
TBR=eroman@chromium.org
(cherry picked from commit 3e1858436ff61c26296d35ea9e8ade57fcd1c37d)
Bug: 848237
Change-Id: Ie010d64f9e4c91d14e65cd558fe203b078d3ace6
Reviewed-on: https://chromium-review.googlesource.com/1081237
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563722}
Reviewed-on: https://chromium-review.googlesource.com/1083334
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#729}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Incrementing VERSION to 67.0.3396.71
TBR=dimu@chromium.org
Change-Id: Icc5047adef99dffeb34f900aee3a9b60c05b24e3
Reviewed-on: https://chromium-review.googlesource.com/1081762
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#728}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Revert "[Merging to M67] Stop resetting 10 sec timeout in FetchParameters::MakeSynchronous()"
This reverts commit e11497bc51059c4c1b2ebf0cd4537ef8e1d20972.
The original CL was intended to fix the 10 second default timeout issue (crbug.com/844268).
But this CL introduced 100% CPU usage issue by using OneShotTimer with INT_MAX (crbug.com/848210).
So this CL reverts e11497bc51059c4c1b2ebf0cd4537ef8e1d20972, using a large timeout (1 day) to mitigate the timeout issue (crbug.com/844268).
Bug: 848210, 844268
Change-Id: Iccd4a7a9b416e11aca354c658d2e6c9bfc530db4
Reviewed-on: https://chromium-review.googlesource.com/1081777
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#727}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Incrementing VERSION to 67.0.3396.70
TBR=dimu@chromium.org
Change-Id: I6230996a7ffcb8f7c9f15f3273a10f3561bb1eec
Reviewed-on: https://chromium-review.googlesource.com/1081373
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#726}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Remove WeakPtrFactory from ModuleDatabase
That factory was only used for the thread-bouncing in OnModuleLoad(),
which is unnecessary given that the ModuleDatabase is a singleton that
never gets freed.
This fixes a crash where WeakPtrFactory::GetWeakPtr() was called from
multiple threads concurrently, even though it isn't thread-safe.
Merging to m67 stable
(cherry picked from commit bb402619b01df30bb0b758a7f40d19859df3ac8c)
Bug: 845110
Change-Id: I071ab52d8938922c93eeac6adc4d592669d15ae7
Reviewed-on: https://chromium-review.googlesource.com/1069328
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#560729}
Reviewed-on: https://chromium-review.googlesource.com/1081429
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#725}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}Fix UninstallAppController
The callback was cleared for each focus changed event even if it wasn't
for the right element. This meant that SetValue() was never called since
the first focus changed event we received was never the right one.
Fix it by swapping the callback after the right element is found.
Merging to m57 stable
(cherry picked from commit bc84dc82d13115138000a6b4b578e9fca655556a)
Bug: 844185
Change-Id: I7dabce15513c0346e6c78adf1802a562002de08a
Reviewed-on: https://chromium-review.googlesource.com/1064543
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#559684}
Reviewed-on: https://chromium-review.googlesource.com/1081337
Cr-Commit-Position: refs/branch-heads/3396@{#724}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}[M67 Merge] Fixed CSP directive value parsing accepted character range
TBR=andypaicu@chromium.org
(cherry picked from commit 5b8466d84c801a9dfe140cb9a9f6be3a8caba230)
Bug: 845961
Change-Id: Ifc9609058cd7cbd268785db46534e3ed09da6ce3
Reviewed-on: https://chromium-review.googlesource.com/1071510
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561834}
Reviewed-on: https://chromium-review.googlesource.com/1080931
Reviewed-by: Andrew Whalley <awhalley@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#723}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}