| commit | 415f6e5494372ba67cf055fce9b61471f930e242 | [log] [tgz] |
|---|---|---|
| author | Mattias Nissler <mnissler@chromium.org> | Wed Jul 08 07:15:56 2020 |
| committer | Jack Neus <jackneus@google.com> | Wed Sep 22 16:13:59 2021 |
| tree | 9bce4399e9836ea4a1d33dcddc961715edcf5ef2 | |
| parent | 1bfd6ad754cafccd309f62e024a6ede552733395 [diff] |
login: Pass feature flags in separate command line switch. This changes the code to maintain the set of feature flags separately from command line switches and pass them in encoded form as the argument to the new --feature-flags command line switch. This will allow Chrome to translate feature flag configuration to command line switches internally as is already the case for non-Chrome OS platforms. BUG=chromium:1073940 TEST=New unit test. Cq-Depend: chromium:2593204 Change-Id: I450e60c128d53cfe24dcff20787ab5d61c86c664 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2560128 Tested-by: Mattias Nissler <mnissler@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> NOKEYCHECK=True GitOrigin-RevId: 9c3e7d9e3db591bb5dfaac32470afda8f537578a
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.