commit | 8ab5e075c57a2f752eef66bef64c7f342f56bb56 | [log] [tgz] |
---|---|---|
author | Pavol Marko <pmarko@google.com> | Wed May 12 12:57:57 2021 |
committer | Jack Neus <jackneus@google.com> | Wed Sep 22 16:26:15 2021 |
tree | 3314315b4afca1ea62c3d437f6c844947cb0a751 | |
parent | 7ca67f609784ad277517a416bf86b7fdd679fa3d [diff] |
[M90-LTS] system_api: Add session_manager method to load shill profile Add a session_manager DBus method which will be used to trigger loading of a shill user profile. BUG=b:183084821 TEST=none Disallow-Recycled-Builds: all Change-Id: I14b7974bac281bd52fbccddab9cab68c79e13fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2891561 Tested-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3054090 Tested-by: Roger Felipe Zanoni da Silva <rzanoni@google.com> Commit-Queue: Roger Felipe Zanoni da Silva <rzanoni@google.com> Reviewed-by: Jana Grill <janagrill@google.com> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Owners-Override: Achuith Bhandarkar <achuith@chromium.org> NOKEYCHECK=True GitOrigin-RevId: 93dc3f11029906a4a19ec3bbf9b4eea7e06fd28c
This directory (platform2/system_api
) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.