[go: nahoru, domu]
Google Git
Sign in
chromium / devtools / devtools-frontend / 3aa26a5613bc5ea4ee42f9ca55b902703e1c1b99
commit3aa26a5613bc5ea4ee42f9ca55b902703e1c1b99[log] [tgz]
authorErgün Erdoğmuş <ergunsh@chromium.org>Wed Nov 23 15:53:53 2022
committerDevtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Nov 24 10:56:11 2022
tree6a2bc7505933448f4aa07a31013bf3e6dea81cf4
parent7c7428e91df8a1031d2f8ff020633324b4df905e [diff]
Use css parser for formatting CSS and exclude var() from property start

We were using SCSS parser for formatting CSS before which is
fixed in crrev/c/3789375 but re-introduced in crrev/c/3792110. This CL
changes that back to using CSS parser.

Currently we have a custom formatting logic in `CSSProperty` which kind
of relies on the internal details of CodeMirror. We were marking `var()`
calls as a start of a property which they are not. So, this CL excludes
them from being a property start.

I've doubts about having a custom formatting logic in `CSSProperty`
and relying on the internal details of CodeMirror. (For example,
to understand which token type is which, we need to check out the
implementation in CodeMirror side) Though for now, I don't have
a better suggestion.

We might re-evaluate why we need this formatting logic in the future
and how we can make it more robust.

Fixed: 1392813
Change-Id: I240c4dd86f0f2fc6a175fdb25e708263ae818495
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4051382
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
6 files changed
tree: 6a2bc7505933448f4aa07a31013bf3e6dea81cf4
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .gitattributes
  18. .gitignore
  19. .gn
  20. .mailmap
  21. .npmignore
  22. .npmrc
  23. .style.yapf
  24. .stylelintignore
  25. .stylelintrc.json
  26. AUTHORS
  27. BUILD.gn
  28. codereview.settings
  29. DEPS
  30. LICENSE
  31. OWNERS
  32. package-lock.json
  33. package.json
  34. PRESUBMIT.py
  35. README.md
  36. tsconfig.json
  37. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Project documentation

Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch