[go: nahoru, domu]

Partially parse animation shorthand and render keyframe links

I was thinking parsing `animation` shorthand to be an overkill
in crrev.com/c/4300470 however it felt hacky to do otherwise and I've
finally opted in to partially parsing it.

Created a `CSSAnimationModel` that tokenizes the given shorthand
value and finds the parts in it that should be rendered as text,
easing function or animation name.

I did not split the text part into other longhand properties since we
render them as text anyways. If we feel the need for this (i.e. a new
swatch for some longhand property), we can do that on top of this patch.

Here is the screenshot for animation shorthand to keyframe links:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=589773&signed_aid=PLB9MrSIsiAh5-VSfHCZXQ==&inline=1

Fixed: 1420656
Change-Id: I254d9fdc6f4f8896b99cdad3049af983d8265447
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4316322
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
9 files changed
tree: 06bdacad0e4a1fae151b0fa931d508c46dc5028e
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .git-blame-ignore-revs
  18. .gitattributes
  19. .gitignore
  20. .gn
  21. .mailmap
  22. .npmignore
  23. .npmrc
  24. .style.yapf
  25. .stylelintignore
  26. .stylelintrc.json
  27. AUTHORS
  28. BUILD.gn
  29. codereview.settings
  30. DEPS
  31. LICENSE
  32. OWNERS
  33. package-lock.json
  34. package.json
  35. PRESUBMIT.py
  36. README.md
  37. tsconfig.json
  38. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Project documentation

Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch